hg: jigsaw/jake/langtools: 2 new changesets

Changeset: 562e51ce8df5 Author:jjg Date: 2016-04-25 15:09 -0700 URL: http://hg.openjdk.java.net/jigsaw/jake/langtools/rev/562e51ce8df5 minor adjustment to javadoc ! src/java.compiler/share/classes/javax/lang/model/util/Elements.java Changeset: 116f2acc53e6 Author:jjg Date:

Re: automatic modules leaking types when using addmods

On 04/25/2016 09:09 PM, Alex Buckley wrote: Consider an automatic module MA which is required by an explicit named module MN. MA could mention, in its exported API, public types from other automatic modules (e.g. seems reasonable for jackson.databind to have a method whose return type is from

Re: automatic modules leaking types when using addmods

Consider an automatic module MA which is required by an explicit named module MN. MA could mention, in its exported API, public types from other automatic modules (e.g. seems reasonable for jackson.databind to have a method whose return type is from jackson.core) so we want MN to read those oth

Re: RFR: JDK-8132994 - /modules and /packages should not be parsed by the jimage parser

"if(" in second if statement [missing whitespace after keyword] +1 -Sundar On 4/25/2016 8:08 PM, Jim Laskey (Oracle) wrote: > Changed to special case parse /modules/ and /packages/. Will actually reduce > string table size slightly (better common string match.) > > http://cr.openjdk.java.net/~

RFR: JDK-8132994 - /modules and /packages should not be parsed by the jimage parser

Changed to special case parse /modules/ and /packages/. Will actually reduce string table size slightly (better common string match.) http://cr.openjdk.java.net/~jlaskey/8132994/webrev/index.html https://bugs.openjdk.java.net/brows

Re: RFR JDK-8155005: java.lang.reflect.Module.WeakSet is not thread-safe

On 2016-04-25 15:02, Alan Bateman wrote: On 25/04/2016 13:54, Claes Redestad wrote: Hi, I think this looks good, but since these WeakPairMaps won't be used for many applications I wonder if it's worth keeping the implementation lazy, for example by moving the maps to a holder class: http:

Re: RFR JDK-8155005: java.lang.reflect.Module.WeakSet is not thread-safe

On 25/04/2016 13:54, Claes Redestad wrote: Hi, I think this looks good, but since these WeakPairMaps won't be used for many applications I wonder if it's worth keeping the implementation lazy, for example by moving the maps to a holder class: http://cr.openjdk.java.net/~redestad/scratch/tran

Re: RFR JDK-8155005: java.lang.reflect.Module.WeakSet is not thread-safe

On 25/04/2016 12:13, Peter Levart wrote: Hi Alan, I created an issue for this: JDK-8155005: java.lang.reflect.Module.WeakSet is not thread-safe https://bugs.openjdk.java.net/browse/JDK-8155005 I did what you suggested, renamed type parameters to , split long line in Module and modif

Re: RFR JDK-8155005: java.lang.reflect.Module.WeakSet is not thread-safe

Hi, I think this looks good, but since these WeakPairMaps won't be used for many applications I wonder if it's worth keeping the implementation lazy, for example by moving the maps to a holder class: http://cr.openjdk.java.net/~redestad/scratch/transients.01/ I verified this avoids loading t

RFR JDK-8155005: java.lang.reflect.Module.WeakSet is not thread-safe

Hi Alan, I created an issue for this: JDK-8155005: java.lang.reflect.Module.WeakSet is not thread-safe https://bugs.openjdk.java.net/browse/JDK-8155005 I did what you suggested, renamed type parameters to , split long line in Module and modified the test so that it now waits for entr

Re: automatic modules leaking types when using addmods

I now understand (and tested) that when I use any automatic module from a named module, the named module gets implicit readability to *all* automatic modules. What is the reasoning behind this? If a module A has a dependency on B and C, I get the impression during migration that "requires B" w

Re: automatic modules leaking types when using addmods

On 25/04/2016 07:35, Paul Bakker wrote: That doesn't seem to be the case, I can run successfully, as long as I have the right -addmods. I've pushed my example here if you want to take a further look at it: https://github.com/paulbakker/automaticmodules-example I wasn't clear. My comment was