Re: RFR 8154733, Fix module dependencies missed in java.rmi tests

2016-04-26 Thread Amy Lu
On 4/27/16 1:00 AM, Alan Bateman wrote: On 26/04/2016 13:50, Felix Yang wrote: Hi Amy, thanks for pointing this out. Updated webrev: http://cr.openjdk.java.net/~xiaofeya/8154733/webrev.01/ This looks okay to me. -Alan Thank you Alan! Felix, I'll sponsor this change for you. Thanks,

hg: jigsaw/jake/jdk: On windows jmod hashes not close jmod file before being renamed

2016-04-26 Thread mandy . chung
Changeset: 92edcd03489a Author:mchung Date: 2016-04-26 19:47 -0700 URL: http://hg.openjdk.java.net/jigsaw/jake/jdk/rev/92edcd03489a On windows jmod hashes not close jmod file before being renamed ! src/jdk.jlink/share/classes/jdk/tools/jmod/JmodTask.java ! test/tools/jmod/hashes/Ha

hg: jigsaw/jake/langtools: fix javac, javadoc help text for -Xpatch

2016-04-26 Thread jonathan . gibbons
Changeset: 9c18d735860c Author:jjg Date: 2016-04-26 19:27 -0700 URL: http://hg.openjdk.java.net/jigsaw/jake/langtools/rev/9c18d735860c fix javac, javadoc help text for -Xpatch ! src/jdk.compiler/share/classes/com/sun/tools/javac/main/Option.java ! src/jdk.compiler/share/classes/com

Re: Review request 8154905: Rename jdk.jvmstat.rmi to jdk.jstatd

2016-04-26 Thread Sundararajan Athijegannathan
+1 -Sundar On 4/27/2016 1:59 AM, Mandy Chung wrote: > http://cr.openjdk.java.net/~mchung/jdk9/webrevs/8154905/webrev.00/ > > jdk.jvmstat.rmi does not have any API but instead is a tool module. This > patch proposes to rename jdk.jvmstat.rmi to jdk.statd to follow JDK module > naming convention.

Review request 8154905: Rename jdk.jvmstat.rmi to jdk.jstatd

2016-04-26 Thread Mandy Chung
http://cr.openjdk.java.net/~mchung/jdk9/webrevs/8154905/webrev.00/ jdk.jvmstat.rmi does not have any API but instead is a tool module. This patch proposes to rename jdk.jvmstat.rmi to jdk.statd to follow JDK module naming convention. Mandy

Re: RFR JDK-8155005: java.lang.reflect.Module.WeakSet is not thread-safe

2016-04-26 Thread Peter Levart
On 04/26/2016 04:56 PM, Alan Bateman wrote: On 26/04/2016 15:42, Peter Levart wrote: I increased the timeout to 30 seconds. It is not exactly 30 seconds, but 300 iterations with sleep(100L) + check in each iteration. If the system is really overloaded then this loop should stretch automatic

Re: RFR 8154733, Fix module dependencies missed in java.rmi tests

2016-04-26 Thread Alan Bateman
On 26/04/2016 13:50, Felix Yang wrote: Hi Amy, thanks for pointing this out. Updated webrev: http://cr.openjdk.java.net/~xiaofeya/8154733/webrev.01/ This looks okay to me. -Alan

Re: RFR JDK-8155005: java.lang.reflect.Module.WeakSet is not thread-safe

2016-04-26 Thread Alan Bateman
On 26/04/2016 15:42, Peter Levart wrote: I increased the timeout to 30 seconds. It is not exactly 30 seconds, but 300 iterations with sleep(100L) + check in each iteration. If the system is really overloaded then this loop should stretch automatically: http://cr.openjdk.java.net/~plevart/jdk

Re: RFR JDK-8155005: java.lang.reflect.Module.WeakSet is not thread-safe

2016-04-26 Thread Peter Levart
Hi Alan, On 04/25/2016 02:58 PM, Alan Bateman wrote: On 25/04/2016 12:13, Peter Levart wrote: Hi Alan, I created an issue for this: JDK-8155005: java.lang.reflect.Module.WeakSet is not thread-safe https://bugs.openjdk.java.net/browse/JDK-8155005 I did what you suggested, renamed ty

Re: RFR 8154733, Fix module dependencies missed in java.rmi tests

2016-04-26 Thread Amy Lu
On 4/26/16 8:50 PM, Felix Yang wrote: Hi Amy, thanks for pointing this out. Updated webrev: http://cr.openjdk.java.net/~xiaofeya/8154733/webrev.01/ Thank you Felix for the updated webrev. This looks clear and good :-) Just one question, does this fix for all tests for jdk_rmi test group?

hg: jigsaw/jake/jaxp: Change TemplatesImpl to use addReadsAllUnnamed

2016-04-26 Thread alan . bateman
Changeset: fc1bbc598b18 Author:alanb Date: 2016-04-26 14:35 +0100 URL: http://hg.openjdk.java.net/jigsaw/jake/jaxp/rev/fc1bbc598b18 Change TemplatesImpl to use addReadsAllUnnamed ! src/java.xml/share/classes/com/sun/org/apache/xalan/internal/xsltc/trax/TemplatesImpl.java

hg: jigsaw/jake/jdk: 5 new changesets

2016-04-26 Thread alan . bateman
Changeset: 91efdb8e72c8 Author:alanb Date: 2016-04-26 11:00 +0100 URL: http://hg.openjdk.java.net/jigsaw/jake/jdk/rev/91efdb8e72c8 Move test to invoke javac with new form of -Xpatch ! test/javax/xml/jaxp/common/8035437/run.sh Changeset: 6952106ecba3 Author:alanb Date: 201

hg: jigsaw/jake/hotspot: Change tests to use addReadsAllUnnamed

2016-04-26 Thread alan . bateman
Changeset: e39333ff8016 Author:alanb Date: 2016-04-26 14:35 +0100 URL: http://hg.openjdk.java.net/jigsaw/jake/hotspot/rev/e39333ff8016 Change tests to use addReadsAllUnnamed ! test/runtime/modules/AccessCheck/DiffCL_Umod.java ! test/runtime/modules/AccessCheck/Umod.java ! test/runt

Re: RFR 8154733, Fix module dependencies missed in java.rmi tests

2016-04-26 Thread Felix Yang
Hi Amy, thanks for pointing this out. Updated webrev: http://cr.openjdk.java.net/~xiaofeya/8154733/webrev.01/ Felix On 2016/4/26 17:21, Amy Lu wrote: Hi, Felix With modules declares in TEST.propertiesshould avoid have to modify test file one by one... Maybe I missed things please correct

Re: RFR 8154733, Fix module dependencies missed in java.rmi tests

2016-04-26 Thread Alan Bateman
On 26/04/2016 10:21, Amy Lu wrote: Hi, Felix With modules declares in TEST.propertiesshould avoid have to modify test file one by one... Maybe I missed things please correct me. Example: $ cat jdk/test/java/rmi/TEST.properties modules = java.rmi Yes, this avoid needing to add @modules to e

Re: RFR 8154733, Fix module dependencies missed in java.rmi tests

2016-04-26 Thread Amy Lu
Hi, Felix With modules declares in TEST.propertiesshould avoid have to modify test file one by one... Maybe I missed things please correct me. Example: $ cat jdk/test/java/rmi/TEST.properties modules = java.rmi Thanks, Amy On 4/26/16 4:53 PM, Felix Yang wrote: Hi all, please review the

RFR 8154733, Fix module dependencies missed in java.rmi tests

2016-04-26 Thread Felix Yang
Hi all, please review the fix to explicitly declare module dependencies for rmi tests. Bug: https://bugs.openjdk.java.net/browse/JDK-8154733 Webrev: http://cr.openjdk.java.net/~xiaofeya/8154733/webrev.00/ Thanks, Felix