RFR 8156972: java/lang/reflect/Layer/LayerAndLoadersTest.java test requires jdk.compiler

2016-05-13 Thread Alexandre (Shura) Iline
Hi. Could you please take a look on the fix: http://cr.openjdk.java.net/~shurailine/8156972/webrev.00/ Besides adding @modules, I have also added a couple of lines to the library class, because I have found the NPE which I was getting originally non-informative. Shura

Re: jtreg 4.2-b02 -agentvm + jdk-9+118 = FAIL

2016-05-13 Thread Alan Bateman
On 13/05/2016 20:29, Martin Buchholz wrote: : Thanks! That explains why I can still run jtreg -agentvm on openjdk itself. (But useNewXpatch feels wrong because it's not a property of the test suite itself, but of the testjdk ...) I agree but it was just for transition purposes to keep existing

Re: RFR 8156914: jlink API minor cleanups

2016-05-13 Thread Mandy Chung
> On May 13, 2016, at 1:20 AM, Sundararajan Athijegannathan > wrote: > > Please review http://cr.openjdk.java.net/~sundar/8156914/webrev.00/ for > https://bugs.openjdk.java.net/browse/JDK-8156914 > This patch looks okay. The renamed

Re: jtreg 4.2-b02 -agentvm + jdk-9+118 = FAIL

2016-05-13 Thread Martin Buchholz
On Fri, May 13, 2016 at 12:18 PM, Alan Bateman wrote: > On 13/05/2016 20:04, Martin Buchholz wrote: >> >> I tried updating jsr166 to jdk-9+118 today, but there's a snag - jtreg >> won't start. >> A simple repro is: >> >> jtreg -agentvm

Re: jtreg 4.2-b02 -agentvm + jdk-9+118 = FAIL

2016-05-13 Thread Alan Bateman
On 13/05/2016 20:04, Martin Buchholz wrote: I tried updating jsr166 to jdk-9+118 today, but there's a snag - jtreg won't start. A simple repro is: jtreg -agentvm -testjdk:/home/martin/jdk/jdk-9-ea+118 . Agent[0].stdout: Bad value for -Xpatch, no module name specified Agent[0].stderr: Error:

jtreg 4.2-b02 -agentvm + jdk-9+118 = FAIL

2016-05-13 Thread Martin Buchholz
I tried updating jsr166 to jdk-9+118 today, but there's a snag - jtreg won't start. A simple repro is: jtreg -agentvm -testjdk:/home/martin/jdk/jdk-9-ea+118 . Agent[0].stdout: Bad value for -Xpatch, no module name specified Agent[0].stderr: Error: Could not create the Java Virtual Machine.

RFR 8156914: jlink API minor cleanups

2016-05-13 Thread Sundararajan Athijegannathan
Please review http://cr.openjdk.java.net/~sundar/8156914/webrev.00/ for https://bugs.openjdk.java.net/browse/JDK-8156914 Thanks, -Sundar