Re: [9] RFR: 8159781: jlink --include-locales fails with java.util.regex.PatternSyntaxException

2016-06-17 Thread Mandy Chung
> On Jun 17, 2016, at 3:29 PM, Naoto Sato wrote: > > Decided to fix this separately from the other include locales issues. Here is > the bug and the proposed fix: > > https://bugs.openjdk.java.net/browse/JDK-8159781 > http://cr.openjdk.java.net/~naoto/8159781/webrev.00/ The change looks okay.

[9] RFR: 8159781: jlink --include-locales fails with java.util.regex.PatternSyntaxException

2016-06-17 Thread Naoto Sato
Decided to fix this separately from the other include locales issues. Here is the bug and the proposed fix: https://bugs.openjdk.java.net/browse/JDK-8159781 http://cr.openjdk.java.net/~naoto/8159781/webrev.00/ The change is to explicitly specify "regex" path matching along with the pattern mod

Re: RFR: 8158272 & 8158468 (tools/jlink/plugins/IncludeLocalesPluginTest.java bug fixes)

2016-06-17 Thread Naoto Sato
I will take care of that along with other include locales issues. Naoto On 17/06/2016 01:14, Masayoshi Okutsu wrote: I've been waiting for JDK-8159206 to be fixed. But this test still fails after the JDK-8159206 fix. I've filed JDK-8159781 for the failure and pushed this test fix with the follo

Re: RFR of JDK-8159762: Some minor test bugs in java/lang/module/ModuleDescriptorTest.java

2016-06-17 Thread Hamlin Li
On 2016/6/17 21:30, Alan Bateman wrote: On 17/06/2016 04:22, Hamlin Li wrote: Would you please review the following patch for some minor test bug? bug: https://bugs.openjdk.java.net/browse/JDK-8159762 webrev: http://cr.openjdk.java.net/~mli/8159762/webrev.00/ This looks okay. If you then th

Re: JDK-8153362: [jigsaw] Add javac -Xlint warning to list exposed types which are not accessible

2016-06-17 Thread Jan Lahoda
Hi, I've updated the patches, reflecting the feedback so far. The langtools change is now split into two parts, one is only adding the new lint key (but no checks are actually performed): http://cr.openjdk.java.net/~jlahoda/8153362/langtools.01-phase1/ And the second part is adding the checks

Re: RFR of JDK-8159762: Some minor test bugs in java/lang/module/ModuleDescriptorTest.java

2016-06-17 Thread Alan Bateman
On 17/06/2016 04:22, Hamlin Li wrote: Would you please review the following patch for some minor test bug? bug: https://bugs.openjdk.java.net/browse/JDK-8159762 webrev: http://cr.openjdk.java.net/~mli/8159762/webrev.00/ This looks okay. If you then then you could expand coverage with testReq

hg: jigsaw/jake/jdk: 43 new changesets

2016-06-17 Thread alan . bateman
Changeset: 02285945f508 Author:darcy Date: 2016-06-06 16:46 -0700 URL: http://hg.openjdk.java.net/jigsaw/jake/jdk/rev/02285945f508 8158870: Temporarily problem list DGCDeadLock.java on Mac Reviewed-by: smarks ! test/ProblemList.txt Changeset: cb8524f24115 Author:weijun Date:

hg: jigsaw/jake/jaxws: 2 new changesets

2016-06-17 Thread alan . bateman
Changeset: 1600da1665cd Author:lana Date: 2016-06-16 19:07 + URL: http://hg.openjdk.java.net/jigsaw/jake/jaxws/rev/1600da1665cd Added tag jdk-9+123 for changeset c42decd28bbf ! .hgtags Changeset: 34b647f33612 Author:alanb Date: 2016-06-17 11:33 +0100 URL: http:/

hg: jigsaw/jake/langtools: 14 new changesets

2016-06-17 Thread alan . bateman
Changeset: bcebe24cd346 Author:rfield Date: 2016-06-08 00:32 -0700 URL: http://hg.openjdk.java.net/jigsaw/jake/langtools/rev/bcebe24cd346 8139829: JShell API: No use of fields to return information from public types Reviewed-by: vromero ! src/jdk.jshell/share/classes/jdk/internal/j

hg: jigsaw/jake: 8 new changesets

2016-06-17 Thread alan . bateman
Changeset: 89769a2f1511 Author:erikj Date: 2016-06-07 15:42 +0200 URL: http://hg.openjdk.java.net/jigsaw/jake/rev/89769a2f1511 8158535: Configure script uses basic tools directly in many places Reviewed-by: dholmes ! common/autoconf/basics.m4 ! common/autoconf/basics_windows.m4 ! c

hg: jigsaw/jake/hotspot: 2 new changesets

2016-06-17 Thread alan . bateman
Changeset: 60ba5d19f4cb Author:lana Date: 2016-06-16 19:07 + URL: http://hg.openjdk.java.net/jigsaw/jake/hotspot/rev/60ba5d19f4cb Added tag jdk-9+123 for changeset 75f81e1fecfb ! .hgtags Changeset: 2a91e5b983f2 Author:alanb Date: 2016-06-17 11:37 +0100 URL: http

hg: jigsaw/jake/jaxp: 2 new changesets

2016-06-17 Thread alan . bateman
Changeset: f38fe556f1bd Author:lana Date: 2016-06-16 19:07 + URL: http://hg.openjdk.java.net/jigsaw/jake/jaxp/rev/f38fe556f1bd Added tag jdk-9+123 for changeset 3c19ab8742c1 ! .hgtags Changeset: e6b63ce6a286 Author:alanb Date: 2016-06-17 11:32 +0100 URL: http://

hg: jigsaw/jake/corba: 2 new changesets

2016-06-17 Thread alan . bateman
Changeset: 35d52de48e19 Author:lana Date: 2016-06-16 19:07 + URL: http://hg.openjdk.java.net/jigsaw/jake/corba/rev/35d52de48e19 Added tag jdk-9+123 for changeset e33a34cc5519 ! .hgtags Changeset: 523e842079ed Author:alanb Date: 2016-06-17 11:32 +0100 URL: http:/

hg: jigsaw/jake/nashorn: 7 new changesets

2016-06-17 Thread alan . bateman
Changeset: 64f922ff84bb Author:sundar Date: 2016-06-07 19:13 +0530 URL: http://hg.openjdk.java.net/jigsaw/jake/nashorn/rev/64f922ff84bb 8158922: jjs tab completion of Java classes shows package-private, "hidden" classes too Reviewed-by: hannesw, mhaupt ! src/jdk.scripting.nashorn.

Re: RFR: 8154399, 8159096, export packages containing standard javadoc doclet

2016-06-17 Thread Alan Bateman
On 17/06/2016 03:28, Jonathan Gibbons wrote: Please review this simple fix for two related aspects of the same problem: Export the "standard doclet" used by javadoc, such that it is possible to derive alternative doclets, either by delegation or subtyping. In JDK 9, javadoc has a "new" stan

Re: RFR: 8158272 & 8158468 (tools/jlink/plugins/IncludeLocalesPluginTest.java bug fixes)

2016-06-17 Thread Masayoshi Okutsu
I've been waiting for JDK-8159206 to be fixed. But this test still fails after the JDK-8159206 fix. I've filed JDK-8159781 for the failure and pushed this test fix with the following ProblemList.txt change: diff --git a/test/ProblemList.txt b/test/ProblemList.txt --- a/test/ProblemList.txt +++