Re: Oops javac throw a NPE

Hi Remi, Thanks for reporting this bug [1]. It has already been fixed, the fix can be accessed at [2], Thanks, Vicente [1] https://bugs.openjdk.java.net/browse/JDK-8159439 [2] http://hg.openjdk.java.net/jdk9/dev/langtools/rev/d213ecfb98b2 On 06/13/2016 01:03 PM, Remi Forax wrote: Hi Jon, i'

Re: RFR: 8158670: Fix @modules in java/lang/SecurityManager/CheckSecurityProvider.java

I’m including security-dev which would be a better list to review this test fix. Valerie, Does this test have to be order-sensitive? I think this test would be cleaner to make it order-insensitive and simply test the security provider initialization. See my comments below. > On Jun 27, 201

Re: JDK-8153362: [jigsaw] Add javac -Xlint warning to list exposed types which are not accessible

Since you have already admitted to using multiple concatenated lower case words in unexportedinapi, and since "unexported" is not a real word, can I suggest notexportedinapi for the category, and NOT_EXPORTED_IN_API for the Lint category. Or else just simply all the was down to "exports" and

Re: No jrt-fs.jar in JRE?

> On Jun 24, 2016, at 10:07 PM, Jayaprakash Arthanareeswaran > wrote: > > My experiment to use the jrt-fs.jar from the JDK to load the system classes > in JRE failed. May be I am not > doing something right. Is that even supposed to work if I done the right > way? You said JRE. If you mean th

Re: Review request: JDK-8159596 Add java --dry-run

-XshowSettings would probably be a good place to include the VM arguments. $ java -XshowSettings:vm -—dry-run I file a JBS issue: https://bugs.openjdk.java.net/browse/JDK-8160389 Mandy > On Jun 27, 2016, at 9:20 AM, Paul Benedict wrote: > > Mandy, if I may recommend another suggestion, anot

Re: Review request: JDK-8159596 Add java --dry-run

Mandy, if I may recommend another suggestion, another "sanity" check could be dumping the command line arguments. I know quite a few bash programmers who would really love to see they passed their arguments correctly without executing their program. :-) Cheers, Paul On Mon, Jun 27, 2016 at 10:48

Re: RFR 8160346: JLinkTest.java should compute exact number of plugins from jdk.jlink module [ was Re: RFR 8153238: Improve test/tools/jlink/JLinkTest.java not to hard code the number of plugins]

> On Jun 27, 2016, at 4:19 AM, Sundararajan Athijegannathan > wrote: > > Sorry I had that test change already. I've filed another bug to track > your suggestions. > > Please review http://cr.openjdk.java.net/~sundar/8160346/webrev.00/ for > https://bugs.openjdk.java.net/browse/JDK-8160346 +1

Re: Review request: JDK-8159596 Add java --dry-run

Hi Mandy, Does this enhancement need to be doc'd? If so, could you add a subtask (component = docs)? Thanks, --Raymond On 24/06/2016 9:49 AM, Mandy Chung wrote: Webrev: http://cr.openjdk.java.net/~mchung/jdk9/webrevs/8159596/webrev.00/ `java --dry-run` will create the VM, load the main,

RFR: 8158670: Fix @modules in java/lang/SecurityManager/CheckSecurityProvider.java

Hi. Please take a look on a suggested for for the java/lang/SecurityManager/CheckSecurityProvider.java test. The test in question depend on a list of modules, some of them are platform-specific. Listing all the dependencies in one test is causing the test to be skipped on every platform. In a

Re: RFR: JDK-8160348 - jlink should use System.out for usage messages

Thank you > On Jun 27, 2016, at 9:23 AM, Sundararajan Athijegannathan > wrote: > > +1 > > -Sundar > > > On 6/27/2016 5:46 PM, Jim Laskey (Oracle) wrote: >> Trivial patch >> >> http://cr.openjdk.java.net/~jlaskey/8160348/webrev/index.html >>

Re: RFR: JDK-8160348 - jlink should use System.out for usage messages

+1 -Sundar On 6/27/2016 5:46 PM, Jim Laskey (Oracle) wrote: > Trivial patch > > http://cr.openjdk.java.net/~jlaskey/8160348/webrev/index.html > > https://bugs.openjdk.java.net/browse/JDK-8160348 >

RFR: JDK-8160348 - jlink should use System.out for usage messages

Trivial patch http://cr.openjdk.java.net/~jlaskey/8160348/webrev/index.html https://bugs.openjdk.java.net/browse/JDK-8160348

Re: RFR 8157936: Files.size(Path p) returns 0 if path is from JrtFileSystem with exploded build

+1 > On Jun 27, 2016, at 5:16 AM, Sundararajan Athijegannathan > wrote: > > Thanks for the review. I'll include a space in test and push. > > -Sundar > > > On 6/27/2016 1:42 PM, Paul Sandoz wrote: >>> On 27 Jun 2016, at 09:03, Sundararajan Athijegannathan >>> wrote: >>> >>> Please review

Re: RFR 8160346: JLinkTest.java should compute exact number of plugins from jdk.jlink module [ was Re: RFR 8153238: Improve test/tools/jlink/JLinkTest.java not to hard code the number of plugins]

+1 > On Jun 27, 2016, at 8:19 AM, Sundararajan Athijegannathan > wrote: > > Sorry I had that test change already. I've filed another bug to track > your suggestions. > > Please review http://cr.openjdk.java.net/~sundar/8160346/webrev.00/ for > https://bugs.openjdk.java.net/browse/JDK-8160346 >

RFR 8160346: JLinkTest.java should compute exact number of plugins from jdk.jlink module [ was Re: RFR 8153238: Improve test/tools/jlink/JLinkTest.java not to hard code the number of plugins]

Sorry I had that test change already. I've filed another bug to track your suggestions. Please review http://cr.openjdk.java.net/~sundar/8160346/webrev.00/ for https://bugs.openjdk.java.net/browse/JDK-8160346 Thanks, -Sundar On 6/25/2016 4:10 AM, Mandy Chung wrote: >> On Jun 24, 2016, at 9:54 A

Re: RFR 8157936: Files.size(Path p) returns 0 if path is from JrtFileSystem with exploded build

Thanks for the review. I'll include a space in test and push. -Sundar On 6/27/2016 1:42 PM, Paul Sandoz wrote: >> On 27 Jun 2016, at 09:03, Sundararajan Athijegannathan >> wrote: >> >> Please review http://cr.openjdk.java.net/~sundar/8157936/webrev.00/ for >> https://bugs.openjdk.java.net/brow

Re: RFR 8157936: Files.size(Path p) returns 0 if path is from JrtFileSystem with exploded build

> On 27 Jun 2016, at 09:03, Sundararajan Athijegannathan > wrote: > > Please review http://cr.openjdk.java.net/~sundar/8157936/webrev.00/ for > https://bugs.openjdk.java.net/browse/JDK-8157936 > > Note: no regrestion test added as jrt-fs automated testing is not done > in exploded mode JDK. Bu

RFR 8157936: Files.size(Path p) returns 0 if path is from JrtFileSystem with exploded build

Please review http://cr.openjdk.java.net/~sundar/8157936/webrev.00/ for https://bugs.openjdk.java.net/browse/JDK-8157936 Note: no regrestion test added as jrt-fs automated testing is not done in exploded mode JDK. But, I'm adding a simple class file size test to Basic.java so that a manual run of