Re: Strange test failure when referencing a class in a deprivileged module

2016-07-06 Thread Peter Firmstone
Can you change the test to call checkPermission prior to setting SSL as the system security manager? This will just ensure that all necessary classes are loaded prior to SSL becoming the security manager.  Regards, Peter. Sent from my Samsung device.     Include original message Original

Re: Strange test failure when referencing a class in a deprivileged module

2016-07-06 Thread Wang Weijun
I run the program directly (not from jtreg) and the result is different: Exception in thread "main" java.lang.BootstrapMethodError: call site initialization exception at SSL.checkPermission(SSL.java:21) at java.lang.SecurityManager.checkPropertyAccess(java.base@9-ea/SecurityManag

Re: Strange test failure when referencing a class in a deprivileged module

2016-07-06 Thread Peter Firmstone
Have you tried setting the jvm in security debug mode to see else might be occurring?  If so can you send the output? Regards, Peter. Sent from my Samsung device.     Include original message Original message From: Wang Weijun Sent: 07/07/2016 11:08:58 am To: Peter Firmstone Cc: Sea

Re: Strange test failure when referencing a class in a deprivileged module

2016-07-06 Thread Wang Weijun
> On Jul 7, 2016, at 8:19 AM, Peter Firmstone > wrote: > > Perhaps the policy provider hasn't been refreshed when the new security > manager is in force? Try doing a Policy.refresh() in the SecurityManager > constructor. You mean Policy.getPolicy().refresh()? No difference. And I don't thi

Re: Strange test failure when referencing a class in a deprivileged module

2016-07-06 Thread Peter Firmstone
Perhaps the policy provider hasn't been refreshed when the new security manager is in force?  Try doing a Policy.refresh() in the SecurityManager constructor. Regards, Peter. Sent from my Samsung device.     Include original message Original message From: Wang Weijun Sent: 07/07/2016

Re: Strange test failure when referencing a class in a deprivileged module

2016-07-06 Thread Wang Weijun
> On Jul 7, 2016, at 5:04 AM, Sean Mullan wrote: > > Does your SSL code match up with the stack trace? The test only has 27 lines, > but the stack trace says it was called from line 42. My local SSL.java still contains the GPL comments and I didn't paste them here. Line 42 is

Re: New EA builds, contains initial implementation of current proposals

2016-07-06 Thread mark . reinhold
2016/7/6 11:36:41 -0700, alan.bate...@oracle.com: > ... > > One other significant change in this build is that it has the new forms > for the command line options. As has been mentioned in a number of > threads here, we are proposing that the new command line options for > modules use the GNU s

Re: Proposal: #DefaultModule

2016-07-06 Thread Peter Firmstone
Hmm, be useful for debugging. Peter. Sent from my Samsung device.     Include original message Original message From: David M. Lloyd Sent: 07/07/2016 03:40:22 am To: Paul Benedict Cc: jigsaw-dev ; Java Platform Module System (JSR 376) Expert Group Observers Subject: Re: Proposal: #D

Re: Strange test failure when referencing a class in a deprivileged module

2016-07-06 Thread Sean Mullan
On 07/06/2016 04:51 AM, Alan Bateman wrote: On 06/07/2016 05:32, Weijun Wang wrote: On 7/5/2016 23:50, Mandy Chung wrote: Max - are you running the test with exploded image (see JDK-8155858 [1])? No. The test also fails with recent promoted builds (ever since java.sql is de-priveleged). I

Re: JDK9 Modules

2016-07-06 Thread Malachi de Ælfweald
Verified that the following works with 9-ea+ 125-2016-07-06-073258.javare.5251.nc export _JAVA_OPTIONS="--add-modules=ALL-SYSTEM --add-exports=java.base/ sun.nio.ch=ALL-UNNAMED" Malachi de Ælfweald http://www.google.com/profiles/malachid On Wed, Jul 6, 2016 at 8:03 AM, Malachi de Ælfweald wro

New EA builds, contains initial implementation of current proposals

2016-07-06 Thread Alan Bateman
The jigsaw/jake forest has been updated with an initial implementation of the proposals that Mark brought to the jpms-spec-experts mailing list last week. For those that don't build from source then the EA build/downloads [1] has also been refreshed. The changes in this build are initial/ear

Re: RFR: 8158670: Fix @modules in java/lang/SecurityManager/CheckSecurityProvider.java

2016-07-06 Thread Alexandre (Shura) Iline
Valerie, could you sponsor the patch for me? Shura > On Jul 6, 2016, at 10:08 AM, Valerie Peng wrote: > > > Changes look fine to me. > Thanks, > Valerie > > On 7/5/2016 2:31 PM, Mandy Chung wrote: >>> On Jul 5, 2016, at 1:53 PM, Alexandre (Shura) Iline >>> wrote: >>> >>> On Jul 5, 20

Re: JDK9 Modules

2016-07-06 Thread Malachi de Ælfweald
Since the -addmods didn't work from within the options.compilerArgs, I thought I would check if these temporary jdk.launcher ones would work there instead of in _JAVA_OPTIONS. No go with that option. Also, interesting side note - I have the _JAVA_OPTIONS specified in my .bashrc, so it is picking t

Re: Proposal: #DefaultModule

2016-07-06 Thread David M. Lloyd
Unfortunately attributes cannot appear in stack traces, and there is value in returning something meaningful for getName() in that module as well. Consider that OSGi modules (among other things) can never be Jigsaw modules; at least it would be useful to allow them to have a clean appearance

Re: Proposal: #DefaultModule

2016-07-06 Thread Paul Benedict
Okay. Well I still think it's strange for the default module to have a name. I'm pretty sure it's meant to be analogous to the default package which has no name either. It's the lack of a name that keeps it out of resolution. Though to your point, maybe it's not a name you're looking for, per se, a

Re: Proposal: #DefaultModule

2016-07-06 Thread David M. Lloyd
No, the intent is that default modules are still outside of resolution altogether. Being unnamed isn't what puts the module outside the system; it's just that you have to *have* one outside the system in order to ensure that all classes have a Module instance, so I think we ought to be able to

Re: Proposal: #DefaultModule

2016-07-06 Thread Paul Benedict
The only problem, I see, with renaming the "unnamed" to "default" module is that it also changes the semantics. The unnnamed module has no name so it cannot be depended upon by a named module. However, once you begin calling it the "default" module and allow a name to be assigned, it no longer make

Re: RFR: 8158670: Fix @modules in java/lang/SecurityManager/CheckSecurityProvider.java

2016-07-06 Thread Valerie Peng
Changes look fine to me. Thanks, Valerie On 7/5/2016 2:31 PM, Mandy Chung wrote: On Jul 5, 2016, at 1:53 PM, Alexandre (Shura) Iline wrote: On Jul 5, 2016, at 1:36 PM, Mandy Chung wrote: On Jul 5, 2016, at 12:42 PM, Alexandre (Shura) Iline wrote: This made sense, than you, Mandy. P

Re: Proposal: #DefaultModule

2016-07-06 Thread Remi Forax
Hi David, Correct me if i'm wrong, it seems like the proposal to be able to specify how to find the name and the version of an automatic module (i.e. #CustomizableAutomaticModuleNameMapping) but for the default module. The idea is that an existing module systems will be able to provide a name and

Re: JDK9 Modules

2016-07-06 Thread Malachi de Ælfweald
I don't have a problem changing it to the new properties once they work =) Actually, that's probably why they didn't work in the gradle configuration. Malachi de Ælfweald http://www.google.com/profiles/malachid On Wed, Jul 6, 2016 at 7:44 AM, Alan Bateman wrote: > > > On 06/07/2016 15:30, Ma

Re: JDK9 Modules

2016-07-06 Thread Alan Bateman
On 06/07/2016 15:30, Malachi de Ælfweald wrote: I think I must be misunderstanding your suggestion. If I do: export _JAVA_OPTIONS="--add-modules=ALL-SYSTEM --add-exports=java.base/sun.nio.ch =ALL-UNNAMED" then: java -version reports: Unrecognized option: --add-modules=ALL

RE: JDK9 Modules

2016-07-06 Thread Stephen Felts
In the next few weeks, the options will change to the new format and your build will be broken.     From: Malachi de Ælfweald [mailto:malac...@gmail.com] Sent: Wednesday, July 06, 2016 10:30 AM To: Alan Bateman Cc: Stephen Felts; jigsaw-dev@openjdk.java.net Subject: Re: JDK9 Modules   I thin

Re: JDK9 Modules

2016-07-06 Thread Malachi de Ælfweald
I think I must be misunderstanding your suggestion. If I do: export _JAVA_OPTIONS="--add-modules=ALL-SYSTEM --add-exports=java.base/ sun.nio.ch=ALL-UNNAMED" then: java -version reports: Unrecognized option: --add-modules=ALL-SYSTEM Error: Could not create the Java Virtual Machine. Error: A fatal

hg: jigsaw/jake/jdk: 102 new changesets

2016-07-06 Thread alan . bateman
Changeset: efdbe6fe3754 Author:alanb Date: 2016-05-04 16:16 +0100 URL: http://hg.openjdk.java.net/jigsaw/jake/jdk/rev/efdbe6fe3754 requires static / exports dynamic prototype ! src/java.base/share/classes/java/lang/module/Dependence.java ! src/java.base/share/classes/java/lang/modu

hg: jigsaw/jake/langtools: 37 new changesets

2016-07-06 Thread alan . bateman
Changeset: e344c5e58b75 Author:alanb Date: 2016-05-04 16:16 +0100 URL: http://hg.openjdk.java.net/jigsaw/jake/langtools/rev/e344c5e58b75 requires static / exports dynamic prototype Contributed-by: jonathan.gibb...@oracle.com ! src/jdk.compiler/share/classes/com/sun/tools/javac/code

hg: jigsaw/jake/hotspot: 24 new changesets

2016-07-06 Thread alan . bateman
Changeset: 35740549359c Author:alanb Date: 2016-05-14 08:35 +0100 URL: http://hg.openjdk.java.net/jigsaw/jake/hotspot/rev/35740549359c jdk.upgrade.module.path => jdk.module.upgrade.path ! src/share/vm/runtime/arguments.cpp Changeset: 8c55dce40720 Author:hseigel Date: 2016

hg: jigsaw/jake/nashorn: 4 new changesets

2016-07-06 Thread alan . bateman
Changeset: f5fac139b59c Author:mchung Date: 2016-06-29 11:09 -0700 URL: http://hg.openjdk.java.net/jigsaw/jake/nashorn/rev/f5fac139b59c Update nashorn to use new CLI options ! make/BuildNashorn.gmk ! make/build.xml ! make/project.properties ! test/script/currently-failing/JDK-80550

hg: jigsaw/jake/jaxws: 3 new changesets

2016-07-06 Thread alan . bateman
Changeset: ea4a64399d35 Author:mchung Date: 2016-06-24 19:14 -0700 URL: http://hg.openjdk.java.net/jigsaw/jake/jaxws/rev/ea4a64399d35 jaxws tools to use --add-modules ! src/jdk.xml.bind/share/classes/com/sun/tools/internal/jxc/SchemaGenerator.java ! src/jdk.xml.ws/share/classes/co

hg: jigsaw/jake/corba: 6 new changesets

2016-07-06 Thread alan . bateman
Changeset: 37bfe73e7cc3 Author:alanb Date: 2016-06-19 09:37 +0100 URL: http://hg.openjdk.java.net/jigsaw/jake/corba/rev/37bfe73e7cc3 Add @Deprecated to java.corba module ! src/java.corba/share/classes/module-info.java Changeset: 59f8bece8180 Author:alanb Date: 2016-06-19

hg: jigsaw/jake/jaxp: 14 new changesets

2016-07-06 Thread alan . bateman
Changeset: b8ba59faa9ee Author:alanb Date: 2016-05-11 13:32 +0100 URL: http://hg.openjdk.java.net/jigsaw/jake/jaxp/rev/b8ba59faa9ee Change ModuleFinder.compose to varargs, drop ModuleFinder.empty ! src/java.xml/share/classes/com/sun/org/apache/xalan/internal/xsltc/trax/TemplatesIm

hg: jigsaw/jake: 9 new changesets

2016-07-06 Thread alan . bateman
Changeset: a223ba36864a Author:mchung Date: 2016-06-20 15:52 -0700 URL: http://hg.openjdk.java.net/jigsaw/jake/rev/a223ba36864a Lax jcheck ! .jcheck/conf Changeset: 221427a43026 Author:mchung Date: 2016-06-20 15:52 -0700 URL: http://hg.openjdk.java.net/jigsaw/jake/r

Re: JDK9 Modules

2016-07-06 Thread Alan Bateman
On 05/07/2016 22:24, Malachi de Ælfweald wrote: With: export _JAVA_OPTIONS="-Djdk.launcher.addmods=ALL-SYSTEM -Djdk.launcher.addexports.0=java.base/sun.nio.ch=ALL-UNNAMED" no GRADLE_OPTIONS no options.compilerArgs in build.gradle 1. The dagger project compiles and runs 2. The neo4j project com

Re: Strange test failure when referencing a class in a deprivileged module

2016-07-06 Thread Alan Bateman
On 06/07/2016 05:32, Weijun Wang wrote: On 7/5/2016 23:50, Mandy Chung wrote: Max - are you running the test with exploded image (see JDK-8155858 [1])? No. The test also fails with recent promoted builds (ever since java.sql is de-priveleged). I assume this is a general issue with security