> On Aug 17, 2016, at 9:26 AM, Alexandre (Shura) Iline
> wrote:
>
> Before the suggested fix, the test in question would fail on a system with no
> jdk.crypto.pkcs11. That could be emulated by:
> $ jtreg ... -javaoptions:"-limitmods jdk.jartool"
> jdk/security/jarsigner/Spec.java
> ...
> FAIL
Hi, Max.
Excerpt from JTReg documentation:
=
@modules [/]+
Express a dependence on a modules in the system being tested, and optionally,
on selected internal packages in some or all of those mo
Hi Shura
I am looking at test/jdk/security/jarsigner/Spec.java.
IMHO, even on a Solaris, without the SunPKCS11 provider at runtime, this
test should be able to find Signature and MessageDigest implementations
from the SunRsaSign and SUN provider.
Is the new @modules dependency necessary? In
> On 8 Aug 2016, at 12:14, Patrick Reinhart wrote:
>
>
>> Am 08.08.2016 um 18:55 schrieb Alan Bateman :
>>
>> On 08/08/2016 17:29, Patrick Reinhart wrote:
>>
>>> :
>>> I tried to integrate your suggested changes here:
>>> http://cr.openjdk.java.net/~reinhapa/reviews/8161230/ClassLoader_Stream
Hi.
Please review fixes related to module dependencies in a few jdk tests:
http://cr.openjdk.java.net/~shurailine/8163126/webrev.00/index.html
The review contains a few cases where jdk.zipfs is added to the module list.
This is happening because all TestNG tests which use compiler API require
j
