hg: jigsaw/jake/jdk: Remove CORBA tests from exclude list, get more tests running

2016-11-02 Thread alan . bateman
Changeset: d370ea60c627 Author:alanb Date: 2016-11-03 06:57 + URL: http://hg.openjdk.java.net/jigsaw/jake/jdk/rev/d370ea60c627 Remove CORBA tests from exclude list, get more tests running ! test/ProblemList.txt ! test/java/security/testlibrary/Proc.java ! test/sun/security/tool

hg: jigsaw/jake/jdk: use new jtreg :+open for normal and deep reflection access

2016-11-02 Thread mandy . chung
Changeset: 96556085b81d Author:mchung Date: 2016-11-02 22:02 -0700 URL: http://hg.openjdk.java.net/jigsaw/jake/jdk/rev/96556085b81d use new jtreg :+open for normal and deep reflection access ! test/com/sun/corba/serialization/ObjectStreamTest.java ! test/com/sun/crypto/provider/Cip

hg: jigsaw/jake/jdk: fix tests for deep reflection access

2016-11-02 Thread mandy . chung
Changeset: 484681b43b87 Author:mchung Date: 2016-11-02 19:40 -0700 URL: http://hg.openjdk.java.net/jigsaw/jake/jdk/rev/484681b43b87 fix tests for deep reflection access ! test/com/sun/crypto/provider/Cipher/AES/TestGHASH.java ! test/com/sun/crypto/provider/Cipher/PBE/CheckPBEKeySiz

hg: jigsaw/jake: Update build-time generated module-info.java for opens and provides directive

2016-11-02 Thread mandy . chung
Changeset: cffb6ba86fb4 Author:mchung Date: 2016-11-02 17:17 -0700 URL: http://hg.openjdk.java.net/jigsaw/jake/rev/cffb6ba86fb4 Update build-time generated module-info.java for opens and provides directive ! make/GensrcModuleInfo.gmk

hg: jigsaw/jake/jdk: Update build-time generated module-info.java for opens and provides directive

2016-11-02 Thread mandy . chung
Changeset: c32a29f4613f Author:mchung Date: 2016-11-02 17:17 -0700 URL: http://hg.openjdk.java.net/jigsaw/jake/jdk/rev/c32a29f4613f Update build-time generated module-info.java for opens and provides directive ! make/src/classes/build/tools/module/GenModuleInfoSource.java

hg: jigsaw/jake/langtools: Generate one provides clause for each service interface with one or more providers

2016-11-02 Thread mandy . chung
Changeset: a8962f60d7d0 Author:mchung Date: 2016-11-02 17:15 -0700 URL: http://hg.openjdk.java.net/jigsaw/jake/langtools/rev/a8962f60d7d0 Generate one provides clause for each service interface with one or more providers ! src/jdk.jdeps/share/classes/com/sun/tools/jdeps/ModuleInfo

Re: Proposal for JSE API representing java.specification.version

2016-11-02 Thread Alex Buckley
Andy, Java SE 9 has java.lang.Runtime.Version for manipulating the version strings returned as system properties. It was introduced by JEP 223 -- see http://openjdk.java.net/jeps/223. Best to follow up on verona-dev. Alex On 11/2/2016 4:22 PM, Andrew Guibert wrote: Hello all, Many Java fra

Re: Proposal for JSE API representing java.specification.version

2016-11-02 Thread Remi Forax
- Mail original - > De: "Andrew Guibert" > À: "jigsaw-dev" > Envoyé: Jeudi 3 Novembre 2016 00:22:56 > Objet: Proposal for JSE API representing java.specification.version > Hello all, > > Many Java frameworks and applications require knowledge of the Java version > they are running on.

Proposal for JSE API representing java.specification.version

2016-11-02 Thread Andrew Guibert
Hello all, Many Java frameworks and applications require knowledge of the Java version they are running on. Currently the only way to check the Java version is by doing: String javaVersion = System.getProperty("java.specification.version"); This of course returns a String, which is very a

hg: jigsaw/jake/langtools: fix remaining uses of :private

2016-11-02 Thread jonathan . gibbons
Changeset: 8154a3ab3a1f Author:jjg Date: 2016-11-02 14:49 -0700 URL: http://hg.openjdk.java.net/jigsaw/jake/langtools/rev/8154a3ab3a1f fix remaining uses of :private ! test/jdk/jshell/CompletionSuggestionTest.java ! test/jdk/jshell/ComputeFQNsTest.java ! test/jdk/jshell/PipeInputSt

hg: jigsaw/jake/jdk: Fix tests that use normal and deep reflective access

2016-11-02 Thread mandy . chung
Changeset: 9ec1c05aaa68 Author:mchung Date: 2016-11-02 14:44 -0700 URL: http://hg.openjdk.java.net/jigsaw/jake/jdk/rev/9ec1c05aaa68 Fix tests that use normal and deep reflective access ! test/com/sun/corba/serialization/ObjectStreamTest.java ! test/com/sun/crypto/provider/Cipher/PB

hg: jigsaw/jake/langtools: 4 new changesets

2016-11-02 Thread jonathan . gibbons
Changeset: 1bb329a71382 Author:jjg Date: 2016-11-02 13:04 -0700 URL: http://hg.openjdk.java.net/jigsaw/jake/langtools/rev/1bb329a71382 fix tests that use normal and deep reflective access ! test/tools/javac/6304921/TestLog.java ! test/tools/javac/modules/PatchModulesTest.java ! tes

Re: Request Review: JDK-6479237 (cl) Add support for classloader names

2016-11-02 Thread Daniel Fuchs
On 02/11/16 19:11, Mandy Chung wrote: Updated version: http://cr.openjdk.java.net/~mchung/jdk9/webrevs/6479237/webrev.04/ +1. I like that toString() is now consitent with toLoaderModuleClassName() in the way both methods handle module name and version. best regards, -- daniel

Re: Request Review: JDK-6479237 (cl) Add support for classloader names

2016-11-02 Thread Mandy Chung
> On Nov 2, 2016, at 4:29 AM, Daniel Fuchs wrote: > > I'd suggest passing 'name' to 'checkCreateClassLoader()' and do > this check in checkCreateClassLoader instead - in order to do > the checks before 'this' is created. > Fixed. > That's not exactly what I had in mind. I don't have > any par

hg: jigsaw/jake/langtools: add no-op --add-opens option to javac

2016-11-02 Thread jonathan . gibbons
Changeset: 6f99c4e110f1 Author:jjg Date: 2016-11-02 11:20 -0700 URL: http://hg.openjdk.java.net/jigsaw/jake/langtools/rev/6f99c4e110f1 add no-op --add-opens option to javac ! src/jdk.compiler/share/classes/com/sun/tools/javac/main/Arguments.java ! src/jdk.compiler/share/classes/com

hg: jigsaw/jake/jdk: jar --print-module-descriptor missed to close the jar file

2016-11-02 Thread mandy . chung
Changeset: 2d63ca46f6db Author:mchung Date: 2016-11-02 10:40 -0700 URL: http://hg.openjdk.java.net/jigsaw/jake/jdk/rev/2d63ca46f6db jar --print-module-descriptor missed to close the jar file ! src/jdk.jartool/share/classes/sun/tools/jar/Main.java ! test/tools/jar/mmrjar/ConcealedPa

Re: javac --module-source-path and --patch-module do not work together

2016-11-02 Thread Jonathan Gibbons
A variant of this problem is under consideration, which may address your use case. In the meantime, the workaround is to make sure there is no evidence of java.base on the module source path. -- Jon On 11/02/2016 10:11 AM, Remi Forax wrote: I agree with that, but that's not my use case. I w

hg: jigsaw/jake/langtools: jdeps support to generate module-info for open module

2016-11-02 Thread mandy . chung
Changeset: dce235fc8345 Author:mchung Date: 2016-11-02 10:34 -0700 URL: http://hg.openjdk.java.net/jigsaw/jake/langtools/rev/dce235fc8345 jdeps support to generate module-info for open module ! src/jdk.jdeps/share/classes/com/sun/tools/jdeps/JdepsTask.java ! src/jdk.jdeps/share/cla

Re: javac --module-source-path and --patch-module do not work together

2016-11-02 Thread Remi Forax
I agree with that, but that's not my use case. I want to add/override files to java.base (an existing module) with --patch-module when i compile several other modules with --module-source-path, i think this should be allowed, otherwise it will be hard to patch the JDK and see the effect on sever

Re: javac --module-source-path and --patch-module do not work together

2016-11-02 Thread Jonathan Gibbons
On 11/02/2016 09:49 AM, Remi Forax wrote: I agree that if there is a folder java.base in the module-source-path, it should be used but this is not the case. Here, i want to add files to an existing modules (java.base) and those files are in output/classes not in src. You currently can't add

Re: javac --module-source-path and --patch-module do not work together

2016-11-02 Thread Remi Forax
- Mail original - > De: "Jonathan Gibbons" > À: jigsaw-dev@openjdk.java.net > Envoyé: Mercredi 2 Novembre 2016 16:15:38 > Objet: Re: javac --module-source-path and --patch-module do not work together > Remi, > > Your command line is questionable for putting output/modules on both -d > an

Re: javac --module-source-path and --patch-module do not work together

2016-11-02 Thread Jonathan Gibbons
Remi, Your command line is questionable for putting output/modules on both -d and --module-path. You don't need it on --module-path. When compiling modules, javac will automatically look in the output directory for classes for the module(s) being compiled. Does your module source path cont

hg: jigsaw/jake/jdk: 2 new changesets

2016-11-02 Thread alan . bateman
Changeset: b189339d80d9 Author:alanb Date: 2016-11-02 13:31 + URL: http://hg.openjdk.java.net/jigsaw/jake/jdk/rev/b189339d80d9 Experimental support for multi-parent configurations ! src/java.base/share/classes/java/lang/module/Configuration.java ! src/java.base/share/classes/ja

Re: New proposal for #ReflectiveAccessToNonExportedTypes: Open modules & open packages

2016-11-02 Thread Remi Forax
- Mail original - > De: "Andrew Dinn" > À: "John Rose" > Cc: jigsaw-dev@openjdk.java.net > Envoyé: Mercredi 2 Novembre 2016 14:25:01 > Objet: Re: New proposal for #ReflectiveAccessToNonExportedTypes: Open modules > & open packages > On 02/11/16 01:58, John Rose wrote: >> On Nov 1, 2016,

javac --module-source-path and --patch-module do not work together

2016-11-02 Thread Remi Forax
Hi Jon, hi all, When i try to compile a module with --module-source-path that uses a patched class (with --patch-module), it fails. With: javac --module-source-path src \ -d output/modules/ \ --patch-module java.base=output/classes \ --module-path output/modules \ $(find

Re: New proposal for #ReflectiveAccessToNonExportedTypes: Open modules & open packages

2016-11-02 Thread Andrew Dinn
On 02/11/16 01:58, John Rose wrote: > On Nov 1, 2016, at 12:02 PM, Andrew Dinn wrote: >> >> I did actually suggest a way of avoiding the use of Unsafe. You >> give your nominated module full reflective access to >> java.lang.invoke allowing it to create Lookup instances (it can >> actually just c

Re: New proposal for #ReflectiveAccessToNonExportedTypes: Open modules & open packages

2016-11-02 Thread forax
> De: "Peter Levart" > À: "Remi Forax" , "David M. Lloyd" > Cc: jigsaw-dev@openjdk.java.net > Envoyé: Mercredi 2 Novembre 2016 11:31:04 > Objet: Re: New proposal for #ReflectiveAccessToNonExportedTypes: Open modules > & > open packages > Hi Remi, > On 11/01/2016 11:59 PM, Remi Forax wrote: >>

Re: Request Review: JDK-6479237 (cl) Add support for classloader names

2016-11-02 Thread Daniel Fuchs
Hi Mandy, On 01/11/16 23:42, Mandy Chung wrote: Hi Daniel, Here is the updated webrev incorporating your feedback: http://cr.openjdk.java.net/~mchung/jdk9/webrevs/6479237/webrev.03 ClassLoader.java: 345 if (name != null && name.isEmpty()) { 346 throw new IllegalArgume

Re: New proposal for #ReflectiveAccessToNonExportedTypes: Open modules & open packages

2016-11-02 Thread Peter Levart
Hi Remi, On 11/01/2016 11:59 PM, Remi Forax wrote: Iteration 3, https://gist.github.com/forax/c08ce0a8dc88705bce97b17b63e7e2d5 GrantAccess can now be put on a class, on a package or on a module, and give access to several frameworks by their names. Getting access to the lookup of a class is n