Re: RFR 8160359: Improve jlink logging for cases when a plugin throws exception

2016-11-08 Thread Sundararajan Athijegannathan
Mandy, The exceptions caught are propagated to caller - JlinkTask - which does print getMessage from exception and exits. So, if a plugin throws illegal argument exception from "configure", jlink will print message and exit - as expected. Catching PluginException (and IllegalArgumentException in

hg: jigsaw/jake/langtools: Fix test/jdk/jshell/JavadocTest.java failing

2016-11-08 Thread mandy . chung
Changeset: 77b8374f80e8 Author:mchung Date: 2016-11-08 14:18 -0800 URL: http://hg.openjdk.java.net/jigsaw/jake/langtools/rev/77b8374f80e8 Fix test/jdk/jshell/JavadocTest.java failing ! test/jdk/jshell/JavadocTest.java

hg: jigsaw/jake/jdk: test/sun/security/krb5/tools/KtabZero.java failing

2016-11-08 Thread mandy . chung
Changeset: ad992df4769b Author:mchung Date: 2016-11-08 14:14 -0800 URL: http://hg.openjdk.java.net/jigsaw/jake/jdk/rev/ad992df4769b test/sun/security/krb5/tools/KtabZero.java failing ! test/sun/security/krb5/tools/KtabZero.java

Re: RFR 8160359: Improve jlink logging for cases when a plugin throws exception

2016-11-08 Thread Mandy Chung
Sundar, Have you considered for plugins to throw different type of exceptions to differentiate if jlink should gracefully exit with no stack trace. For example if it’s an user-error e.g. invalid option or duplicated entries then jlink can simply print the error message. For unexpected error s

hg: jigsaw/jake/jdk: Update GenModuleInfoSource to filter qualified exports/open for known modules

2016-11-08 Thread mandy . chung
Changeset: 8cb1876c41b8 Author:mchung Date: 2016-11-08 11:58 -0800 URL: http://hg.openjdk.java.net/jigsaw/jake/jdk/rev/8cb1876c41b8 Update GenModuleInfoSource to filter qualified exports/open for known modules ! make/src/classes/build/tools/module/GenModuleInfoSource.java ! src/jd

Compiling Java 9

2016-11-08 Thread Stephan Herrmann
I'm wondering what will be expected from a compiler for Java 9. I hope this is a suitable place to ask this kind of questions. The first thing we know: a compiler has to be able to translate module-info.java (or whatever that file's name may be - btw: in absence of a definite rule, is a compile

hg: jigsaw/jake/langtools: Minor cleanup.

2016-11-08 Thread jan . lahoda
Changeset: 2dcedde260f8 Author:jlahoda Date: 2016-11-08 18:14 +0100 URL: http://hg.openjdk.java.net/jigsaw/jake/langtools/rev/2dcedde260f8 Minor cleanup. ! src/java.compiler/share/classes/javax/lang/model/element/ModuleElement.java ! src/jdk.compiler/share/classes/com/sun/source/tr

hg: jigsaw/jake/jdk: Parse module-info.java.extra in java build tool instead of makefile

2016-11-08 Thread erik . joelsson
Changeset: 65473330550b Author:erikj Date: 2016-11-08 17:01 +0100 URL: http://hg.openjdk.java.net/jigsaw/jake/jdk/rev/65473330550b Parse module-info.java.extra in java build tool instead of makefile ! make/src/classes/build/tools/module/GenModuleInfoSource.java

hg: jigsaw/jake: Parse module-info.java.extra in java build tool instead of makefile

2016-11-08 Thread erik . joelsson
Changeset: 9795bd5076ec Author:erikj Date: 2016-11-08 17:01 +0100 URL: http://hg.openjdk.java.net/jigsaw/jake/rev/9795bd5076ec Parse module-info.java.extra in java build tool instead of makefile ! make/GensrcModuleInfo.gmk

Re: RFR 8160359: Improve jlink logging for cases when a plugin throws exception

2016-11-08 Thread Claes Redestad
Hi, I think this looks good as-is, but: Many times I've had the need to enable this kind of logging when building the JDK (as jlink plugins are now essential to creating the standard images), and having to hack the makefiles to add -J-Djlink.debug=true(?) to the right place seems a bit awkward.

RFR 8160359: Improve jlink logging for cases when a plugin throws exception

2016-11-08 Thread Sundararajan Athijegannathan
Please review for http://cr.openjdk.java.net/~sundar/8160359/webrev.00/ for https://bugs.openjdk.java.net/browse/JDK-8160359 Thanks, -Sundar

Re: [9] RFR: 8167240: Write new tests to cover functionality of existing 'jimage' options

2016-11-08 Thread Andrey Nazarov
Hi, Looks OK to me. I can suggest two more cases. A directory and file symlink can be passed in options where tool requires a file path. —Andrey > On 8 Nov 2016, at 16:17, Denis Kononenko wrote: > > > Hi, > > The new version of changes. > > - Switched back to jdk/test/testlibrary to avoid

hg: jigsaw/jake: When importing modules, look in modules_src_jake for jake specific module-info.java files

2016-11-08 Thread erik . joelsson
Changeset: 07c57a17121e Author:erikj Date: 2016-11-08 14:40 +0100 URL: http://hg.openjdk.java.net/jigsaw/jake/rev/07c57a17121e When importing modules, look in modules_src_jake for jake specific module-info.java files ! common/autoconf/generated-configure.sh ! common/autoconf/sourc

Re: [9] RFR: 8167240: Write new tests to cover functionality of existing 'jimage' options

2016-11-08 Thread Denis Kononenko
Hi, The new version of changes. - Switched back to jdk/test/testlibrary to avoid unwanted dependencies (JImageToolTest.java); - Verified tests on smallest possible JDK build. WEBREV: http://cr.openjdk.java.net/~dkononenko/8167240/webrev.02/ BUGURL: https://bugs.openjdk.java.net/browse/JDK-81