hg: jigsaw/jake/jdk: 5 new changesets

2016-11-21 Thread mandy . chung
Changeset: 375b859caf2e Author:mchung Date: 2016-11-21 11:03 -0800 URL: http://hg.openjdk.java.net/jigsaw/jake/jdk/rev/375b859caf2e Clean up jlink/jmod code ! src/jdk.jlink/share/classes/jdk/tools/jlink/internal/JlinkTask.java ! src/jdk.jlink/share/classes/jdk/tools/jlink/internal/

hg: jigsaw/jake/jaxp: Fix test that uses deep reflection

2016-11-21 Thread mandy . chung
Changeset: 23e94a1d726d Author:mchung Date: 2016-11-21 11:07 -0800 URL: http://hg.openjdk.java.net/jigsaw/jake/jaxp/rev/23e94a1d726d Fix test that uses deep reflection ! test/javax/xml/jaxp/functional/catalog/DeferFeatureTest.java

hg: jigsaw/jake/hotspot: Remove --add-exports-private option

2016-11-21 Thread mandy . chung
Changeset: 8f2d918e0619 Author:mchung Date: 2016-11-21 11:07 -0800 URL: http://hg.openjdk.java.net/jigsaw/jake/hotspot/rev/8f2d918e0619 Remove --add-exports-private option ! src/share/vm/runtime/arguments.cpp

hg: jigsaw/jake/langtools: Rename Hashes attribute to jdk.Hashes as it is JDK-specific

2016-11-21 Thread alan . bateman
Changeset: 52a360826e26 Author:alanb Date: 2016-11-21 14:07 + URL: http://hg.openjdk.java.net/jigsaw/jake/langtools/rev/52a360826e26 Rename Hashes attribute to jdk.Hashes as it is JDK-specific ! src/jdk.jdeps/share/classes/com/sun/tools/classfile/Attribute.java ! src/jdk.jdeps/

hg: jigsaw/jake/nashorn: 8170099: Nashorn test failures with stricter reflection access checks in jake forest

2016-11-21 Thread sundararajan . athijegannathan
Changeset: 3d66147560bb Author:sundar Date: 2016-11-21 20:37 +0530 URL: http://hg.openjdk.java.net/jigsaw/jake/nashorn/rev/3d66147560bb 8170099: Nashorn test failures with stricter reflection access checks in jake forest Reviewed-by: jlaskey, alanb ! make/project.properties ! test

Re: RFR 8170099: Nashorn test failures with stricter reflection access checks in jake forest

2016-11-21 Thread Sundararajan Athijegannathan
Thanks for the review. Fixing Reflection with your suggesting and pushing it. Updated webrev for the record: http://cr.openjdk.java.net/~sundar/8170099/webrev.01/ -Sundar On 21/11/16, 7:43 PM, Alan Bateman wrote: On 21/11/2016 14:14, Sundararajan Athijegannathan wrote: Please review http:

hg: jigsaw/jake/jdk: 2 new changesets

2016-11-21 Thread alan . bateman
Changeset: c67449fbf341 Author:alanb Date: 2016-11-21 14:07 + URL: http://hg.openjdk.java.net/jigsaw/jake/jdk/rev/c67449fbf341 Rename Hashes attribute to jdk.Hashes as it is JDK-specific ! src/java.base/share/classes/com/sun/java/util/jar/pack/intrinsic.properties ! src/java.ba

Re: onejars under Jigsaw

2016-11-21 Thread org . openjdk
On 2016-11-19T22:53:17 +0100 "Robert Scholte" wrote: > Hi, > > The following topics have been created for this issue: > http://openjdk.java.net/projects/jigsaw/spec/issues/#MultiModuleExecutableJARs > http://openjdk.java.net/projects/jigsaw/spec/issues/#MultiModuleJARs > > Once resolved we shou

RFR 8170099: Nashorn test failures with stricter reflection access checks in jake forest

2016-11-21 Thread Sundararajan Athijegannathan
Please review http://cr.openjdk.java.net/~sundar/8170099/webrev.00/ for https://bugs.openjdk.java.net/browse/JDK-8170099 Thanks, -Sundar

Re: RFR 8170099: Nashorn test failures with stricter reflection access checks in jake forest

2016-11-21 Thread Alan Bateman
On 21/11/2016 14:14, Sundararajan Athijegannathan wrote: Please review http://cr.openjdk.java.net/~sundar/8170099/webrev.00/ for https://bugs.openjdk.java.net/browse/JDK-8170099 This looks okay although you could replace the setAccessible methods in Reflector that take Method and Constructor w

Re: RFR 8170099: Nashorn test failures with stricter reflection access checks in jake forest

2016-11-21 Thread Jim Laskey (Oracle)
+1 > On Nov 21, 2016, at 10:14 AM, Sundararajan Athijegannathan > wrote: > > Please review http://cr.openjdk.java.net/~sundar/8170099/webrev.00/ for > https://bugs.openjdk.java.net/browse/JDK-8170099 > > Thanks, > -Sundar

Re: Annotation processors and the --processor-module-path

2016-11-21 Thread Eirik Bjørsnøs
> Currently, AFAIK, the processors on module path need to be registered in > the ServiceLoader. For --processor-module-path, "-processor" can be used to > select processors out of those registered in the ServiceLoader. If > --processor-module-path is used and there is no "-processor", all > process

Re: Annotation processors and the --processor-module-path

2016-11-21 Thread Jan Lahoda
On 21.11.2016 11:03, Alan Bateman wrote: On 21/11/2016 09:46, Eirik Bjørsnøs wrote: Alan, | $ javac --help | -processor [,,...] |Names of the annotation processors to run; bypasses default discovery process Why does the "default discovery process" work with --classpath, but not with

Re: Annotation processors and the --processor-module-path

2016-11-21 Thread Alan Bateman
On 21/11/2016 09:46, Eirik Bjørsnøs wrote: Alan, | $ javac --help | -processor [,,...] |Names of the annotation processors to run; bypasses default discovery process Why does the "default discovery process" work with --classpath, but not with --processor-module-path? Is it simply an

Re: Annotation processors and the --processor-module-path

2016-11-21 Thread Eirik Bjørsnøs
Alan, | $ javac --help | -processor [,,...] |Names of the annotation processors to run; bypasses default discovery process Why does the "default discovery process" work with --classpath, but not with --processor-module-path? Is it simply an omission, or is this by design? With the curr

Re: Annotation processors and the --processor-module-path

2016-11-21 Thread Alan Bateman
On 21/11/2016 00:22, Eirik Bjørsnøs wrote: : $ javac --processor-module-path ~/.m2/repository/com/example/annotation-processor/1.0-SNAPSHOT/annotation-processor-1.0-SNAPSHOT.jar -sourcepath src/main/java src/main/java/module-info.java src/main/java/com/example/module/SomeClass.java -g -nowarn -