Hi David,
On 12/14/2016 07:17 AM, David Holmes wrote:
But let me explain why .setAccessible(true) can't be allowed for
protected members in general.
I'm confused as to what is being argued for/against here.
Rony asked why .setAccessible(true) can't be used for protected members
even if cal
JDK-8171201: Drop java.compact$N aggregator modules
JDK-8171202: Rename jdk.crypto.pkcs11 and jdk.pack200 to end with Java letters
http://cr.openjdk.java.net/~mchung/jdk9/webrevs/8171201%2b8171202/webrev.00/
Compact Profiles were introduced in SE 8. The java.compact$N
aggregator module in SE 9
On 14/12/2016 8:17 AM, Peter Levart wrote:
Hi Jochen,
On 12/13/2016 06:32 PM, Jochen Theodorou wrote:
On 12.12.2016 20:56, Alex Buckley wrote:
[...]
The ability of protected members to be accessed from outside their
package means they are essentially public members for the purposes of
inher
Changeset: 0757b2d2968d
Author:mchung
Date: 2016-12-13 21:10 -0800
URL: http://hg.openjdk.java.net/jigsaw/jake/jdk/rev/0757b2d2968d
System modules jlink plugin support for compiled version
! src/java.base/share/classes/jdk/internal/module/Builder.java
! src/java.base/share/classes/
Changeset: 4a200166396d
Author:jjg
Date: 2016-12-13 19:23 -0800
URL: http://hg.openjdk.java.net/jigsaw/jake/langtools/rev/4a200166396d
enable -Xlint:module by default
! src/jdk.compiler/share/classes/com/sun/tools/javac/code/Lint.java
Changeset: 7863fba025ea
Author:jjg
Date: 2016-12-13 19:05 -0800
URL: http://hg.openjdk.java.net/jigsaw/jake/langtools/rev/7863fba025ea
update module names in tests
! test/jdk/javadoc/doclet/testModules/TestModules.java
- test/jdk/javadoc/doclet/testModules/module1/module-info.java
Changeset: eb2ed1365493
Author:jjg
Date: 2016-12-13 15:14 -0800
URL: http://hg.openjdk.java.net/jigsaw/jake/langtools/rev/eb2ed1365493
disallow -profile with -target 9
! src/jdk.compiler/share/classes/com/sun/tools/javac/main/Arguments.java
! test/tools/javac/diags/examples/NotInPr
Hi Jochen,
On 12/13/2016 06:32 PM, Jochen Theodorou wrote:
On 12.12.2016 20:56, Alex Buckley wrote:
[...]
The ability of protected members to be accessed from outside their
package means they are essentially public members for the purposes of
inheritance and reflection. So, setAccessible sho
Hi Rony,
On 12/13/2016 07:07 PM, Rony G. Flatscher wrote:
To make a long story short: I have always adhered to the Java rules for the
Rexx users, in that they
are only allowed to access public Java classes, public fields and public methods
("there must be a
reason why the Java language has de
I think this is OK.
Just a couple of nits in test:
1. You create a static Path bob = Paths.get("bob") field, but then you
don't use it in:
56 try (FileChannel fc = FileChannel.open(Paths.get("bob"),
CREATE, WRITE)) {
2. badBuffers could include a duplicate and a slice of a direct
Hi,
+1 to this approach.
I can create a PR for Apache Lucene to test this! With our current code it is
very easy to add support for this - which is great (at the end I just need a
MethodHandle with a MethodType "(ByteBuffer)void")!
Unfortunately I am not good in compiling OpenJDK, so if somebo
Changeset: 376da2abfeba
Author:jjg
Date: 2016-12-13 12:59 -0800
URL: http://hg.openjdk.java.net/jigsaw/jake/langtools/rev/376da2abfeba
add filter for opens directives
! src/java.compiler/share/classes/javax/lang/model/util/ElementFilter.java
Taking into account the feedback so far, and changing the method name ( since
it is an attractive nuisance ), here is where I think we ended up.
http://cr.openjdk.java.net/~chegar/Unsafe_invokeCleaner/
If this is agreeable, I’ll file an issue in JIRA to track the code changes, and
update JEP 26
On 13.12.2016 16:56, Alan Bateman wrote:
> On 13/12/2016 15:47, Rony G. Flatscher wrote:
>
>> :
>>
>> So the current code does not take protected members into account. If
>> protected members (cf. Alex'
>> comment) get added, wouldn't e.g. java.lang.reflect.Method.invoke(...) or
>> java.lang.ref
On 12.12.2016 20:56, Alex Buckley wrote:
[...]
The ability of protected members to be accessed from outside their
package means they are essentially public members for the purposes of
inheritance and reflection. So, setAccessible should work for protected
members of exported packages. I know wh
On 13/12/2016 15:47, Rony G. Flatscher wrote:
:
So the current code does not take protected members into account. If protected
members (cf. Alex'
comment) get added, wouldn't e.g. java.lang.reflect.Method.invoke(...) or
java.lang.reflect.Field.get(...) be the place to check in the next step,
On 12.12.2016 22:42, Peter Levart wrote:
>
>
> On 12/12/2016 08:56 PM, Alex Buckley wrote:
>> On 12/11/2016 8:16 AM, Rony G. Flatscher wrote:
>>> On 23.11.2016 12:55, Alan Bateman wrote:
As people on this mailing list know, jake has the changes for
#AwkwardStrongEncapsulation [1]
Changeset: e0bb4f0c5d84
Author:sspitsyn
Date: 2016-12-13 09:54 -0500
URL: http://hg.openjdk.java.net/jigsaw/jake/hotspot/rev/e0bb4f0c5d84
8171106: Hotspot test
serviceability/jvmti/GetModulesInfo/JvmtiGetAllModulesTest.java fails to compile
Summary: Fix the test by extending the ab
Changeset: 55586b951ae1
Author:chegar
Date: 2016-12-13 14:31 +
URL: http://hg.openjdk.java.net/jigsaw/jake/jdk/rev/55586b951ae1
Move tests to jdk/modules
+ test/jdk/modules/incubator/DefaultImage.java
+ test/jdk/modules/incubator/ImageModules.java
+ test/jdk/modules/incubator/s
Changeset: 1be9ce97598d
Author:chegar
Date: 2016-12-13 14:22 +
URL: http://hg.openjdk.java.net/jigsaw/jake/rev/1be9ce97598d
8170859: Run time and tool support for ModuleResolution
! make/CreateJmods.gmk
Changeset: 44aa64ee7393
Author:sadayapalam
Date: 2016-12-13 15:23 +0100
URL: http://hg.openjdk.java.net/jigsaw/jake/langtools/rev/44aa64ee7393
8160181: Add lint warning for digits in module names
! src/jdk.compiler/share/classes/com/sun/tools/javac/code/Lint.java
! src/jdk.compiler
Changeset: ad27fe64f0ea
Author:sadayapalam
Date: 2016-12-13 15:23 +0100
URL: http://hg.openjdk.java.net/jigsaw/jake/jdk/rev/ad27fe64f0ea
8160181: Add lint warning for digits in module names
! src/java.compact1/share/classes/module-info.java
! src/java.compact2/share/classes/module-
Changeset: df531084cd31
Author:alanb
Date: 2016-12-13 14:01 +
URL: http://hg.openjdk.java.net/jigsaw/jake/jdk/rev/df531084cd31
Improve validation and tests for module name
! src/java.base/share/classes/jdk/internal/module/Checks.java
! src/java.base/share/classes/jdk/internal/m
Changeset: 7096176b5e14
Author:chegar
Date: 2016-12-12 14:40 +
URL: http://hg.openjdk.java.net/jigsaw/jake/jdk/rev/7096176b5e14
8170859: Run time and tool support for ModuleResolution
! src/java.base/share/classes/jdk/internal/module/ClassFileAttributes.java
! src/java.base/sha
24 matches
Mail list logo
