Re: Does jlink work on exploded build?

2017-01-10 Thread Mandy Chung
Correct, in your case, it won’t work. Mandy > On Jan 10, 2017, at 4:09 PM, Wang Weijun wrote: > > Ah, when I said exploded build, I meant jdk/modules/java/base/.../*.classes. > There is no native files there so I guess not supported. > > --Max > >> On Jan 11, 2560 BE, at 1:12 AM, Mandy Chung

Re: Does jlink work on exploded build?

2017-01-10 Thread Wang Weijun
Ah, when I said exploded build, I meant jdk/modules/java/base/.../*.classes. There is no native files there so I guess not supported. --Max > On Jan 11, 2560 BE, at 1:12 AM, Mandy Chung wrote: > > >> On Jan 10, 2017, at 6:29 AM, Wang Weijun wrote: >> >> $ jlink --module-path ../build/window

Re: Compiling Java 9 (take 2)

2017-01-10 Thread Alex Buckley
On 1/10/2017 12:20 PM, Stephan Herrmann wrote: On 01/07/2017 01:37 AM, Alex Buckley wrote: On 1/4/2017 12:44 PM, Stephan Herrmann wrote: Given that types are identified by qualified names that do not contain the module name, this distinction doesn't seem to be possible per JLS. Per 7.3, javac

Re: Compiling Java 9 (take 2)

2017-01-10 Thread Stephan Herrmann
On 01/07/2017 01:37 AM, Alex Buckley wrote: On 1/4/2017 12:44 PM, Stephan Herrmann wrote: Given that types are identified by qualified names that do not contain the module name, this distinction doesn't seem to be possible per JLS. Per 7.3, javac is associating a first other.Other type with mo

Re: Suggestion: allow accessible reflection on protected methods of exported types.

2017-01-10 Thread Alan Bateman
On 10/01/2017 17:16, Andrew Dinn wrote: : The version which uses Lookups only needs to tweak the exports for one module i.e. java.base. It modifies java.base to 'export open' package java.lang.invoke to the Byteman module. That then allows Byteman to call the private constructor for MethodHandle

Re: Suggestion: allow accessible reflection on protected methods of exported types.

2017-01-10 Thread Andrew Dinn
On 10/01/17 16:48, Jochen Theodorou wrote: > On 10.01.2017 15:40, Andrew Dinn wrote: > [...] >> That's possible because an agent can use its Instrumentation instance to >> 'export open' the MethodHandles package to a module of its own making >> and then create the Lookup from within that module. >

Re: Does jlink work on exploded build?

2017-01-10 Thread Mandy Chung
> On Jan 10, 2017, at 6:29 AM, Wang Weijun wrote: > > $ jlink --module-path ../build/windows-x64-debug/jdk/modules/ --add-modules > jdk.jartool --output /tmp/jartool > Error: java.lang.RuntimeException: Module jdk.jartool's descriptor returns > inconsistent package set jlink in the exploded b

Re: Suggestion: allow accessible reflection on protected methods of exported types.

2017-01-10 Thread Jochen Theodorou
On 10.01.2017 15:40, Andrew Dinn wrote: [...] That's possible because an agent can use its Instrumentation instance to 'export open' the MethodHandles package to a module of its own making and then create the Lookup from within that module. but that won't work for me in Groovy as a library. T

Re: Valid characters in a module name

2017-01-10 Thread Peter Levart
On 01/10/2017 08:28 AM, Ess Kay wrote: > He would write it in source like: > #"#\"u0022\\\"\"" Of course the above is itself a valid 25 character module, package, class, field or method name. It doesn't matter how deep you nest. It is, but as it is written (starting with characters

Re: Suggestion: allow accessible reflection on protected methods of exported types.

2017-01-10 Thread Andrew Dinn
On 10/01/17 13:51, Jochen Theodorou wrote: . . . > I guess the trick is that I am using reflection to get a Lookup object > that has full priviledges... a trick that does no longer work in current > jigsaw You /can/ use this trick if you have an agent. I do so in my latest Byteman prototype (not

Does jlink work on exploded build?

2017-01-10 Thread Wang Weijun
$ jlink --module-path ../build/windows-x64-debug/jdk/modules/ --add-modules jdk.jartool --output /tmp/jartool Error: java.lang.RuntimeException: Module jdk.jartool's descriptor returns inconsistent package set --Max

Re: Suggestion: allow accessible reflection on protected methods of exported types.

2017-01-10 Thread Jochen Theodorou
On 10.01.2017 12:28, Uwe Schindler wrote: Hi, just coming to the example you brought, because I exercised this a week ago: [...] For example... can you call Object#clone on Object using MethodHandles? I actually did not try this, but since the method is protected and in a module I would assu

RE: Suggestion: allow accessible reflection on protected methods of exported types.

2017-01-10 Thread Uwe Schindler
Hi, just coming to the example you brought, because I exercised this a week ago: > [...] For example... can you > call Object#clone on Object using MethodHandles? I actually did not try > this, but since the method is protected and in a module I would assume > no. You had been able to do so by re

hg: jigsaw/jake/jdk: 2 new changesets

2017-01-10 Thread alan . bateman
Changeset: 991bfbc90719 Author:alanb Date: 2017-01-09 12:33 + URL: http://hg.openjdk.java.net/jigsaw/jake/jdk/rev/991bfbc90719 Improve checking in Builder API ! src/java.base/share/classes/java/lang/module/Configuration.java ! src/java.base/share/classes/java/lang/module/Module