hg: jigsaw/jake/jdk: 4 new changesets

2017-01-22 Thread alan . bateman
Changeset: dc2af8bfd11b Author:alanb Date: 2017-01-22 17:35 + URL: http://hg.openjdk.java.net/jigsaw/jake/jdk/rev/dc2af8bfd11b ServiceLoader spec clarification ! src/java.base/share/classes/java/util/ServiceLoader.java Changeset: 11b3699836fb Author:alanb Date: 2017-0

Re: Reusing module name token `*` in -d

2017-01-22 Thread Jonathan Gibbons
Currently (JDK 8), the JDK tool guides come in two flavors, and should only differ in the content of the examples, and not in any specification-related text. Yes, you found a Windows version for javac.html, but there is also a Unix version, here: http://docs.oracle.com/javase/8/docs/technotes

Re: Reusing module name token `*` in -d

2017-01-22 Thread Stephan Herrmann
Thanks, Jon, FWIW, I did search on http://docs.oracle.com/javase/8/docs/technotes/tools/windows/javac.html This brought no result for the simple reason, that no connection is made from Xlint to @SW. Additionally, it feels a bit odd that such documentation should be platform-dependent (see the

Re: Reusing module name token `*` in -d

2017-01-22 Thread Jonathan Gibbons
Stephan, Rémi, et al, Yes, we need to better document the @SuppressWarnings and lint options accepted by javac. At least part of the problem is that we don't have a good place to write such documentation/specification. We are working on that too. -- Jon On 1/22/17 8:21 AM, Stephan Herrmann

Re: javadoc of modules

2017-01-22 Thread Jonathan Gibbons
Hi Rémi, On 1/21/17 1:22 AM, Remi Forax wrote: For the JDK, there are several kind of modules from a doc perspective, we have root modules that are available by default, like java.base, we have implementation modules, those that starts with jdk like jdk.jshell, and we have modules that are not

Re: Reusing module name token `*` in -d

2017-01-22 Thread Stephan Herrmann
Thanks. Is that the documentation that JLS mentions? I was expecting s.t. that search engines can find. The javac help message doesn't even speak of @SuppressWarnings, so are we sure this is the same list? More specifically: the warning of unresolved "to", is that covered by "module" or "exports"

Re: Reusing module name token `*` in -d

2017-01-22 Thread Remi Forax
$javac -X -Xlint:(,)* Warnings to enable or disable, separated by comma. Precede a key by - to disable the specified warning. Supported keys are: all Enable all warnings auxiliaryclass Warn about an auxiliary class that is hidden i

Re: Reusing module name token `*` in -d

2017-01-22 Thread Stephan Herrmann
On 01/22/2017 02:50 PM, Remi Forax wrote: interesting ! It's now a warning that you can exclude with @SuppressWarnings("module"): src/main/java/foo/module-info.java:2: warning: [module] module not found: baz exports foo to baz; > ^ JLS 9.6.4.5 @SuppressWarnings: "Compiler

Re: Reusing module name token `*` in -d

2017-01-22 Thread Remi Forax
interesting ! It's now a warning that you can exclude with @SuppressWarnings("module"): src/main/java/foo/module-info.java:2: warning: [module] module not found: baz exports foo to baz; ^ Rémi - Mail original - > De: "Robert Scholte" > À: jigsaw-dev@openjdk.java.net

Re: Review Request: JDK-8173096 jmod files are not world-readable

2017-01-22 Thread Peter Levart
Hi Mandy, On 01/21/2017 03:32 AM, Mandy Chung wrote: Updated webrev to put the temporary file in the same containing directory of the target file: http://cr.openjdk.java.net/~mchung/jdk9/webrevs/8173096/webrev.01 That's ok. Maybe also specify ATOMIC_MOVE to CopyOption ... options in Files