Re: "OpenJDK specific" attribute specifications

Thanks Alan. I am not 100% sure what you mean when you say that the ModuleHashes and ModuleResolution attributes are "JDK-specific". Are you saying that they may appear in Java 9 class files but it is assumed that they will only be used only by Java compilers as opposed to the JVM?

Re: jlink RuntimeException: descriptor returns inconsistent package set

On 10/02/2017 01:47, Jim Connors wrote: It's a JAR file. I used an early access build of NetBeans (supporting JDK9) to build the JAR. MANIFEST.MF contents: Manifest-Version: 1.0 Ant-Version: Apache Ant 1.10.0alpha Created-By: 1.8.0_121-b13 (Oracle Corporation) X-COMMENT:

Re: jlink RuntimeException: descriptor returns inconsistent package set

C:\tmp\scratch>jlink --module-path .;\Users\jtconnor\jdk-9\jmods --add-modules S coreboard --output reducedImage --compress=2 --strip-debug Error: java.lang.RuntimeException: Module Scoreboard's descriptor returns incons istent package set Jim - is Scoreboard a package module

Re: Confusing error message for inner non-public service provider

// Rewording and resending to avoid confusion. On 2/9/2017 4:21 PM, Jonathan Gibbons wrote: On 2/9/17 3:07 PM, Alex Buckley wrote: All the JLS wants is for the class to be 'public'. Does that just apply locally to the declaration of the class itself, or does it also indirectly apply to any

Re: Confusing error message for inner non-public service provider

On 2/9/2017 4:21 PM, Jonathan Gibbons wrote: On 2/9/17 3:07 PM, Alex Buckley wrote: All the JLS wants is for the class to be 'public'. Does that just apply locally to the declaration of the class itself, or does it also indirectly apply to any enclosing classes, in the case of a nested class?

Re: Confusing error message for inner non-public service provider

On 2/9/17 3:07 PM, Alex Buckley wrote: All the JLS wants is for the class to be 'public'. Alex: Does that just apply locally to the declaration of the class itself, or does it also indirectly apply to any enclosing classes, in the case of a nested class? -- Jon

Re: Confusing error message for inner non-public service provider

Hi Alex, Thanks for your answer, Vicente On 02/09/2017 06:07 PM, Alex Buckley wrote: On 2/9/2017 2:49 PM, Vicente Romero wrote: Just to double check, the right javac behavior in this case should be to issue similar errors in both cases like: some position here: error: ServiceImpl is not

Re: Confusing error message for inner non-public service provider

On 2/9/2017 2:49 PM, Vicente Romero wrote: Just to double check, the right javac behavior in this case should be to issue similar errors in both cases like: some position here: error: ServiceImpl is not public in com.example.internal; cannot be accessed from outside package It's correct to

Re: Confusing error message for inner non-public service provider

Hi Alex, Just to double check, the right javac behavior in this case should be to issue similar errors in both cases like: some position here: error: ServiceImpl is not public in com.example.internal; cannot be accessed from outside package some other position here: error: Outer.ServiceImpl

Re: jlink RuntimeException: descriptor returns inconsistent package set

On 09/02/2017 18:42, Jim Connors wrote: Trying to create JDK9 runtime image that includes only the necessary modules to run a JavaFX program called Scoreboard. It has been converted to a JDK9 module called Scoreboard and has dependencies on system modules as well as another module called

Re: 8173393: Module system implementation refresh (2/2017)

On 07/02/2017 13:23, Alan Bateman wrote: I will re-generate the webrevs later in the week once jdk-9+156 is promoted before eventually merging with jdk9/dev in advance of the eventual push. I've sync'ed up jake to jdk-9+156 and re-generated the webrevs:

hg: jigsaw/jake/jdk: 54 new changesets

Changeset: 7bd7a7ffa84b Author:mchung Date: 2017-01-31 20:06 -0800 URL: http://hg.openjdk.java.net/jigsaw/jake/jdk/rev/7bd7a7ffa84b 8173608: Separate JDK management agent from java.management module Reviewed-by: dfuchs, dholmes, erikj - make/copy/Copy-java.management.gmk +

hg: jigsaw/jake/hotspot: 94 new changesets

Changeset: c1540251d1b7 Author:mchung Date: 2017-01-31 20:06 -0800 URL: http://hg.openjdk.java.net/jigsaw/jake/hotspot/rev/c1540251d1b7 8173608: Separate JDK management agent from java.management module Reviewed-by: dfuchs, dholmes, erikj ! src/share/vm/classfile/vmSymbols.hpp !

hg: jigsaw/jake/corba: 2 new changesets

Changeset: e81838a0d0ff Author:lana Date: 2017-02-09 17:21 + URL: http://hg.openjdk.java.net/jigsaw/jake/corba/rev/e81838a0d0ff Added tag jdk-9+156 for changeset 907c26240cd4 ! .hgtags Changeset: 4c5b0c240dcf Author:alanb Date: 2017-02-09 20:53 + URL:

hg: jigsaw/jake/langtools: 30 new changesets

Changeset: 1eb97b415d28 Author:rfield Date: 2017-01-31 17:01 -0800 URL: http://hg.openjdk.java.net/jigsaw/jake/langtools/rev/1eb97b415d28 8173652: jshell tool: store history on fatal exit Reviewed-by: jlahoda ! src/jdk.jshell/share/classes/jdk/internal/jshell/tool/JShellTool.java

hg: jigsaw/jake/nashorn: 8 new changesets

Changeset: ea1d4ecf5862 Author:hannesw Date: 2017-02-02 18:23 +0100 URL: http://hg.openjdk.java.net/jigsaw/jake/nashorn/rev/ea1d4ecf5862 8169481: StackOverflowError on start when parsing PAC file to autodetect Proxy settings Reviewed-by: jlaskey, sundar !

hg: jigsaw/jake: 19 new changesets

Changeset: 7254856d7081 Author:mchung Date: 2017-01-31 20:06 -0800 URL: http://hg.openjdk.java.net/jigsaw/jake/rev/7254856d7081 8173608: Separate JDK management agent from java.management module Reviewed-by: dfuchs, dholmes, erikj ! common/bin/unshuffle_list.txt !

hg: jigsaw/jake/jaxws: 3 new changesets

Changeset: 7c829eba7814 Author:lancea Date: 2017-02-04 14:03 -0500 URL: http://hg.openjdk.java.net/jigsaw/jake/jaxws/rev/7c829eba7814 8173604: Rename module 8173604 java.annotations.common to java.xml.ws.annoations Reviewed-by: dfuchs, alanb, psandoz, mchung -

hg: jigsaw/jake/jaxp: 3 new changesets

Changeset: e930c373aaa4 Author:clanger Date: 2017-02-06 11:03 +0100 URL: http://hg.openjdk.java.net/jigsaw/jake/jaxp/rev/e930c373aaa4 8173602: JAXP: TESTBUG: javax/xml/jaxp/unittest/transform/TransformerTest.java needs refactoring Reviewed-by: dfuchs !

Fwd: libjvm.so, jmods and --with-native-debug-symbols=internal

My assumption is that this was intentional. Forwarding to the jigsaw team for clarification. The native libraries associated with java.base are needed in the jmod file in order to allow developers to run jlink to produce custom Java runtimes. So, independent of having debug information,

jlink RuntimeException: descriptor returns inconsistent package set

Trying to create JDK9 runtime image that includes only the necessary modules to run a JavaFX program called Scoreboard. It has been converted to a JDK9 module called Scoreboard and has dependencies on system modules as well as another module called com.jtconnors.socket. More details below,

[9] RFR: 8169715: jimage fails with IAE when attempts to inspect an empty file

Hi, Could please someone review the fix for JDK-8169715. The problem occurs when jimage tool is attempting to read an empty or incomplete image. The current implementation works with ByteBuffer and always relies on that there's enough data to inspect the image. This results in IAE inside

hg: jigsaw/jake/jdk: 3 new changesets

Changeset: 01d8583c6ecd Author:alanb Date: 2017-02-09 11:25 + URL: http://hg.openjdk.java.net/jigsaw/jake/jdk/rev/01d8583c6ecd Add missing @JPMS tags, minor javadoc updates ! src/java.base/share/classes/java/lang/IllegalCallerException.java !

Re: [9] RFR 8170113: jimage extract to readonly directory causes MissingResourceException

On 09/02/2017 10:03, Denis Kononenko wrote: : I think we might have to defer such big change to the next release. If there's no objections I'd propose to deliver this fix AS IS and open a new enhancement request to re-implement 'extract' method. Okay but can you create a bug in JBS so that

Re: [9] RFR 8170113: jimage extract to readonly directory causes MissingResourceException

Hi, looks ok for me. Simple and safe fix. —Andrey > On 9 Feb 2017, at 13:03, Denis Kononenko wrote: > > > Hi, > >> >> On 06/02/2017 10:27, Denis Kononenko wrote: >>> Hi, >>> >>> Could someone please review this very small fix. >>> >>> The class JImageTask >>

Re: [9] RFR 8170113: jimage extract to readonly directory causes MissingResourceException

Hi, > > On 06/02/2017 10:27, Denis Kononenko wrote: > > Hi, > > > > Could someone please review this very small fix. > > > > The class JImageTask > (src/jdk.jlink/share/classes/jdk/tools/jimage/JImageTask.java) has > references to an info message by 'err.cannot.create.dir' key. > Unfortunately

Re: "OpenJDK specific" attribute specifications

On 09/02/2017 08:18, Ess Kay wrote: Remi Forax has explained that the ModuleHashes attribute is "OpenJDK specific" and so is not part of the JMP spec. Is there an up to date specification of OpenJDK specific Java 9 class file changes anywhere? ModuleHashes and ModuleResolution are JDK-specific.

"OpenJDK specific" attribute specifications

Remi Forax has explained that the ModuleHashes attribute is "OpenJDK specific" and so is not part of the JMP spec. Is there an up to date specification of OpenJDK specific Java 9 class file changes anywhere?