Re: jlink - excluding optional dependencies

2017-02-17 Thread Gunnar Morling
> There is another question on whether the > module in the generated image retains the `requires static` or not. What would be the rational for removing it? On first thought I'd say keep the descriptor as it is. One could envision a tool for updating existing images, e.g. adding an optional depen

Re: RFR: 8175026: Capture build-time parameters to --generate-jli-classes

2017-02-17 Thread Mandy Chung
> On Feb 17, 2017, at 6:08 AM, Claes Redestad wrote: > > > http://cr.openjdk.java.net/~redestad/8175026/jdk.03/ > Looks good. 82 pre-generate, otherwise the list used to build the host JDK image wil\n\ typo: s/wil/will Minor suggestion to the wording to "generate-jli-classes.description

Re: RFR: 8175026: Capture build-time parameters to --generate-jli-classes

2017-02-17 Thread Claes Redestad
On 02/16/2017 10:24 PM, Mandy Chung wrote: One more thing: the warning message should be in plugin.properties to be localized. Done: http://cr.openjdk.java.net/~redestad/8175026/jdk.03/ /Claes Mandy On Feb 16, 2017, at 12:04 PM, Mandy Chung wrote: On Feb 16, 2017, at 5:20 AM, Claes

Re: How to name modules, automatic and otherwise

2017-02-17 Thread Brian Fox
This seems sensible and not unfamiliar with how import statements already work in Java to determine the fqn to search for a given class. On Fri, Feb 17, 2017 at 4:07 AM, Michael Rasmussen < michael.rasmus...@zeroturnaround.com> wrote: > On 17 February 2017 at 01:19, Stephen Colebourne > wrote: >

AW: How to name modules, automatic and otherwise

2017-02-17 Thread Reto Merz
I like the approach with "from" syntax. It would also great to support from-grouping like this: module mainlib from com.mycompany { requires base; requires willow; from org.joda { requires willow; requires willow-one-more; } } The project I'm working on consists of 187 Maven mod

Re: How to name modules, automatic and otherwise

2017-02-17 Thread Alan Bateman
On 17/02/2017 09:58, Remi Forax wrote: No, both are two unrelated projects, https://spark.apache.org/ http://sparkjava.com/ Right, I can write code that make use of types in org.apache.spark.** or spark.** without any issue as there are no overlapping packages. If both projects releas

Re: How to name modules, automatic and otherwise

2017-02-17 Thread Remi Forax
No, both are two unrelated projects, https://spark.apache.org/ http://sparkjava.com/ Rémi - Mail original - > De: "Alan Bateman" > À: "Michael Rasmussen" > Cc: "jigsaw-dev" > Envoyé: Vendredi 17 Février 2017 10:49:13 > Objet: Re: How to name modules, automatic and otherwise > On 1

Re: How to name modules, automatic and otherwise

2017-02-17 Thread Alan Bateman
On 17/02/2017 09:07, Michael Rasmussen wrote: : I can only agree with this. s/willow/spark/ and we have an example of such a situation in maven already today, of two different libraries with the same name. With the options to specify group, no problem, then I could just write: requires spark-cor

Re: jlink - excluding optional dependencies

2017-02-17 Thread Alan Bateman
On 17/02/2017 08:45, Gunnar Morling wrote: Hi, How can I exclude optional dependencies when creating a runtime image using jlink? In more detail, I have a module A which declares an optional dependency to another module B via "requires static". I'd like to create a runtime image which only con

Re: How to name modules, automatic and otherwise

2017-02-17 Thread Michael Rasmussen
On 17 February 2017 at 01:19, Stephen Colebourne wrote: > > However, I remain of the opinion that they are highly dangerous for > the wider ecosystem without some additional ability to qualify them. > The are many more private jars than public jars, and the clashes seen > today on Maven Central ar

jlink - excluding optional dependencies

2017-02-17 Thread Gunnar Morling
Hi, How can I exclude optional dependencies when creating a runtime image using jlink? In more detail, I have a module A which declares an optional dependency to another module B via "requires static". I'd like to create a runtime image which only contains A. When running jlink with "--add-modul

Re: How to name modules, automatic and otherwise

2017-02-17 Thread Stephen Colebourne
On 17 February 2017 at 00:15, Stephan Herrmann wrote: >> module mainlib from com.mycompany { >> requires base; // implicit, favours group 'com.mycompany' if there is a >> clash >> requires willow; // uses 'com.mycompany' because there is a clash >> requires willow from org.joda; // explic