Referring to a different --system

2017-03-09 Thread Jayaprakash Artanareeswaran
Hello, I remember there was an open issue about not being able to use a different JDK 9 (different than the current one) for class lookup. I raised this question some time back and the following solution was suggested: http://permal

Referring to a different --system

2017-03-09 Thread Jayaprakash Arthanareeswaran

Re: RFR(L) : 8176176 : fix @modules in jdk_svc tests

2017-03-09 Thread Alexandre (Shura) Iline
Igor, I have reviewed some number tests which change the @modules - they are fine. You, however, fix more things with this than missing module dependency declaration. There is a redesign of line-number-sensitive tests [1] and other multiple improvements such as in [2]. Would it be more conveni

hg: jigsaw/jake/jdk: 2 new changesets

2017-03-09 Thread alan . bateman
Changeset: c0dde5abe5ba Author:alanb Date: 2017-03-09 18:44 + URL: http://hg.openjdk.java.net/jigsaw/jake/jdk/rev/c0dde5abe5ba Layer::modules is slow ! src/java.base/share/classes/java/lang/reflect/Layer.java Changeset: 2295afd5985c Author:alanb Date: 2017-03-09 21:00

Re: javac unzips class files from jars on class path into output directory

2017-03-09 Thread Doug Simon
Thanks for the detailed info! Given that I have control over all options, I've opted to separate Java sources out into a separate zip file. -Doug > On 9 Mar 2017, at 19:46, Jonathan Gibbons wrote: > > -implicit:none is also a good solution, but which solution is best depends on > your specifi

Re: javac unzips class files from jars on class path into output directory

2017-03-09 Thread Jonathan Gibbons
-implicit:none is also a good solution, but which solution is best depends on your specific situation (i.e. there is no one "best" for everyone.) With -implicit:none, you are allowing javac to determine which kind of file to read (source or class) when more than one kind is available for any

Re: Controller ensureInLayer is slow when using addReads/addOpens for Layers with large numbers of modules

2017-03-09 Thread Alan Bateman
On 09/03/2017 16:09, Thomas Watson wrote: : Sorry, my mail system adds stuff that the mailing list doesn't like, let me try this again: The Controller ensureInLayer method has this. private void ensureInLayer(Module source) { if (!layer.modules().contains(source)) thro

Re: Controller ensureInLayer is slow when using addReads/addOpens for Layers with large numbers of modules

2017-03-09 Thread Thomas Watson
> From: Alan Bateman > To: Thomas Watson/Austin/IBM@IBMUS, jigsaw-dev@openjdk.java.net > Date: 03/09/2017 10:07 AM > Subject: Re: Controller ensureInLayer is slow when using addReads/ > addOpens for Layers with large numbers of modules > > There wasn't any text in your mail (don't know if this wa

Re: Controller ensureInLayer is slow when using addReads/addOpens for Layers with large numbers of modules

2017-03-09 Thread Alan Bateman
There wasn't any text in your mail (don't know if this was intentional or not). In any case, this is trivially improved, it just hasn't come up before, probably because the Controller API is somewhat niche. -Alan

Controller ensureInLayer is slow when using addReads/addOpens for Layers with large numbers of modules

2017-03-09 Thread Thomas Watson

hg: jigsaw/jake/jdk: 2 new changesets

2017-03-09 Thread alan . bateman
Changeset: a582318020f4 Author:alanb Date: 2017-03-09 15:14 + URL: http://hg.openjdk.java.net/jigsaw/jake/jdk/rev/a582318020f4 Further improvements to illegal access logging ! src/java.base/share/classes/java/lang/invoke/MethodHandles.java ! src/java.base/share/classes/java/lan

hg: jigsaw/jake/jdk: 2 new changesets

2017-03-09 Thread alan . bateman
Changeset: 76dd36f621f4 Author:alanb Date: 2017-03-09 09:31 + URL: http://hg.openjdk.java.net/jigsaw/jake/jdk/rev/76dd36f621f4 Further cleanup of --permit-illegal-access ! src/java.base/share/classes/jdk/internal/module/IllegalAccessLogger.java ! src/java.base/share/classes/sun

Re: javac unzips class files from jars on class path into output directory

2017-03-09 Thread Doug Simon
Jon, Thanks for the insight. I was not aware (or had forgotten) that the classpath is also searched for source files. Reading the javac man page, it seems like I could also use -implicit:none (I confirmed this works). Is that somehow better/cleaner than an empty source path? Of course, since I