Re: Review Request JDK-8175819: OS name and arch in JMOD files should match the values as in the bundle name

2017-04-11 Thread Mandy Chung
> On Apr 11, 2017, at 6:45 AM, Peter Levart wrote: > > Hi Mandy, > > On 04/03/2017 11:50 PM, Mandy Chung wrote: >>JDK 8 JDK 9 >>- - >> OS_NAMELinux linux >>SunOS solaris >>Darwin

Re: RFR 8178323: Add negative tests for bind services Jlink feature

2017-04-11 Thread Andrey Nazarov
Hi Mandy, Here is updated patch http://cr.openjdk.java.net/~anazarov/8178323/webrev.02/webrev/ — Thanks, Andrey > On 10 Apr 2017, at 23:50, Mandy Chung wrote: > > >> On Apr 10, 2017, at 12:30 PM, Andrey Nazarov >

Re: RFR 8178323: Add negative tests for bind services Jlink feature

2017-04-11 Thread Andrey Nazarov
Hi Mandy, Here is updated patch http://cr.openjdk.java.net/~anazarov/8178323/webrev.02/webrev/ — Thanks, Andrey > On 10 Apr 2017, at 23:50, Mandy Chung > wrote: > > >> On Apr 10, 2017, at 12:30 PM

hg: jigsaw/jake/hotspot: compiler/profiling/spectrapredefineclass tests failing

2017-04-11 Thread alan . bateman
Changeset: dfc17fec1a0d Author:alanb Date: 2017-04-11 17:38 +0100 URL: http://hg.openjdk.java.net/jigsaw/jake/hotspot/rev/dfc17fec1a0d compiler/profiling/spectrapredefineclass tests failing ! test/compiler/profiling/spectrapredefineclass/Launcher.java ! test/compiler/profiling/spec

hg: jigsaw/jake/jdk: Reinstate java -d as short form of --describe-module

2017-04-11 Thread alan . bateman
Changeset: 0a2030572aa9 Author:alanb Date: 2017-04-11 17:37 +0100 URL: http://hg.openjdk.java.net/jigsaw/jake/jdk/rev/0a2030572aa9 Reinstate java -d as short form of --describe-module ! src/java.base/share/native/libjli/java.c + test/tools/launcher/modules/describe/DescribeModuleTe

Re: Intended usage of `java --dry-run`?

2017-04-11 Thread Andrew Guibert
> From: Alan Bateman > To: Andrew Guibert/Rochester/IBM@IBMUS, jigsaw-dev d...@openjdk.java.net> > Date: 04/11/2017 10:00 AM > Subject: Re: Intended usage of `java --dry-run`? > > On 11/04/2017 15:36, Andrew Guibert wrote: > > > : > > > > Based on these three use cases, either I'm using --dry-run

Re: jlink output re-create parameter

2017-04-11 Thread Chris Bensen
Early on jlink when provided a non empty directory jlink would fail. That has since been fixed, at least for hidden files such as .DS_Store files. Chris > On Apr 10, 2017, at 1:35 PM, Rahman USTA wrote: > > I got it, thank you for the explanation. > > 2017-04-10 23:31 GMT+03:00 Alan Bateman

Re: Intended usage of `java --dry-run`?

2017-04-11 Thread Alan Bateman
On 11/04/2017 15:36, Andrew Guibert wrote: : Based on these three use cases, either I'm using --dry-run incorrectly (which isn't obvious if I am) or --dry-run is simply a placebo option. My main point of confusion comes from (what I believe to be) correct usage of --dry-run printing out usage

Intended usage of `java --dry-run`?

2017-04-11 Thread Andrew Guibert
I'm working with JDK build b162 and I see that the following option is listed: --dry-run create VM but do not execute main method. This --dry-run option may be useful for validating the command-line options such as the module system configuration. Thi

Re: Review Request JDK-8175819: OS name and arch in JMOD files should match the values as in the bundle name

2017-04-11 Thread Peter Levart
Hi Mandy, On 04/03/2017 11:50 PM, Mandy Chung wrote: JDK 8 JDK 9 - - OS_NAMELinux linux SunOS solaris Darwin macos Windows windows OS_ARCH

hg: jigsaw/jake/jdk: Add EnableDynamicAgentLoading option

2017-04-11 Thread alan . bateman
Changeset: 305afff7c279 Author:alanb Date: 2017-04-11 12:35 +0100 URL: http://hg.openjdk.java.net/jigsaw/jake/jdk/rev/305afff7c279 Add EnableDynamicAgentLoading option Contributed-by: serguei.spit...@oracle.com, alan.bate...@oracle.com ! src/jdk.attach/aix/classes/sun/tools/attach/

hg: jigsaw/jake/hotspot: 2 new changesets

2017-04-11 Thread alan . bateman
Changeset: 842097f877f2 Author:alanb Date: 2017-04-11 12:31 +0100 URL: http://hg.openjdk.java.net/jigsaw/jake/hotspot/rev/842097f877f2 Add EnableDynamicAgentLoading option Contributed-by: serguei.spit...@oracle.com ! src/share/vm/runtime/globals.hpp ! src/share/vm/services/attachLi

Re: Review Request JDK-8175819: OS name and arch in JMOD files should match the values as in the bundle name

2017-04-11 Thread Erik Joelsson
On 2017-04-11 09:40, Magnus Ihse Bursie wrote: On 2017-04-07 22:04, Mandy Chung wrote: On Apr 6, 2017, at 1:09 AM, Magnus Ihse Bursie > wrote: Having though this over real hard, I'd realized I need to make a plea for sanity and consistency. I thoug

Re: Issue with JavaFX and Jigsaw

2017-04-11 Thread Trisha Gee
>From a user/developer point of view, a more descriptive error message would be a big help. I was completely at a loss to understand why I needed to unconditionally export my packages, I figured there was a requirement from the JavaFX-side of things but it wasn't clear what it was or why. A helpfu

Re: Review Request JDK-8175819: OS name and arch in JMOD files should match the values as in the bundle name

2017-04-11 Thread Magnus Ihse Bursie
On 2017-04-07 22:04, Mandy Chung wrote: On Apr 6, 2017, at 1:09 AM, Magnus Ihse Bursie > wrote: Having though this over real hard, I'd realized I need to make a plea for sanity and consistency. I thought I should lay low in this discussion, but I can

Re: Disallowing the dynamic loading of agents by default (revised)

2017-04-11 Thread Alan Bateman
On 11/04/2017 05:31, Stephen Felts wrote: The description below leaves out the " ancestor of the current process". Which way is it - do we need to start two processes or one to work around this? The thread moved one from the original proposal. The only requirement now is that the tool and targ

Re: jna-platform, xalan, batik-script InvalidModuleDescriptorException

2017-04-11 Thread Alan Bateman
On 10/04/2017 22:49, Rahman USTA wrote: : 1) Error occurred during initialization of boot layer java.lang.module.FindException: Unable to derive module descriptor for \.m2\repository\net\java\dev\jna\jna-platform\4.4.0\jna-platform-4.4.0.jar Caused by: java.lang.module.InvalidModuleDescriptorEx