Re: 8178380: Module system implementation refresh (5/2017 update)

> On May 1, 2017, at 1:28 PM, Alan Bateman wrote: > >http://cr.openjdk.java.net/~alanb/8178380/2/ I reviewed all repos in the new version. src/java.base/share/classes/jdk/internal/module/ModuleBootstrap.java 148 if

hg: jigsaw/jake/jdk: 2 new changesets

Changeset: f1ee71109b07 Author:mchung Date: 2017-05-03 19:01 -0700 URL: http://hg.openjdk.java.net/jigsaw/jake/jdk/rev/f1ee71109b07 Fix IntegrationTest.java test to check JAVA_FULL_VERSION ! test/tools/jlink/IntegrationTest.java Changeset: 00902040a130 Author:mchung Date:

Re: 8178380: Module system implementation refresh (5/2017 update)

Hi Alan, I reviewed the Hotspot changes and the Jdk changes related to java.instrument and jdk.attch (including a fragment in the LauncherHelper.java). The fixes look good to me. Thanks, Serguei On 5/1/17 13:28, Alan Bateman wrote: As I mentioned in another thread, we need to get the

Re: [9] Review request: 8177566: FX user module gets IllegalAccessException from sun.reflect.misc.Trampoline

Mandy Chung wrote: Looks good. Thank you for your help on this and for your review. "Deploying an Application as a Module” section is duplicated in several JavaBean*Property classes. One alternative is to move it to the package summary. I have no objection to leave it as is. I

Re: [9] Review request: 8177566: FX user module gets IllegalAccessException from sun.reflect.misc.Trampoline

Looks good. "Deploying an Application as a Module” section is duplicated in several JavaBean*Property classes. One alternative is to move it to the package summary. I have no objection to leave it as is. Mandy > On May 3, 2017, at 4:30 PM, Kevin Rushforth >

Re: [9] Review request: 8177566: FX user module gets IllegalAccessException from sun.reflect.misc.Trampoline

JBS: https://bugs.openjdk.java.net/browse/JDK-8177566 Here is the updated webrev with (I hope) all comments addressed: http://cr.openjdk.java.net/~kcr/8177566/webrev.01/complete-webrev/ For those who reviewed the earlier webrev, I have prepared delta webrevs. * Delta webrev for the fix itself

Re: Java Platform Module System

Rémi, of course there are hacks & tricks to parse such a language. My main point is: it's outside any established concepts and technology. And: if you happen to maintain a tool where recovery after syntax errors and code completion and tons of other features are based on a given parser

Re: Java Platform Module System

- Mail original - > De: "Stephan Herrmann" > À: jigsaw-dev@openjdk.java.net, "Remi Forax" , "Alex > Buckley" > Cc: "Brian Goetz" , "Dan Smith" > > Envoyé: Mercredi

Re: Java Platform Module System

On 03.05.2017 20:55, Remi Forax wrote: > It's context-free because a context free grammar defined its input in term of > terminals and the theory do not say how to map a token to a terminal. > > Jay is right that it requires to use either some specific parser generator > like Tatoo [1] the one

Re: Java Platform Module System

It's context-free because a context free grammar defined its input in term of terminals and the theory do not say how to map a token to a terminal. Jay is right that it requires to use either some specific parser generator like Tatoo [1] the one i've written 10 years ago (because i wanted the

Re: Java Platform Module System

On 5/2/2017 3:39 PM, Alex Buckley wrote: On 5/2/2017 7:07 AM, Jayaprakash Arthanareeswaran wrote: Chapter 2 in [1] describes context-free grammars. The addition to "3.9 Keywords" defines "restricted keywords", which prevent the grammar for ModuleDeclaration from being context-free. This

hg: jigsaw/jake/jdk: Minor tweak to the api note

Changeset: 654588131ea2 Author:mchung Date: 2017-05-03 08:59 -0700 URL: http://hg.openjdk.java.net/jigsaw/jake/jdk/rev/654588131ea2 Minor tweak to the api note ! src/java.base/share/classes/java/lang/ClassLoader.java

Re: [9] Review request: 8177566: FX user module gets IllegalAccessException from sun.reflect.misc.Trampoline

Forgot to respond to this: Also in MethodUtil::invoke 61if (!module.isExported(packageName)) { You can do this check only if module.isNamed. No, this check will work fine on an unnamed module. Module::isExported and Module::isOpen always return true for Module::unnamed. --

Re: [9] Review request: 8177566: FX user module gets IllegalAccessException from sun.reflect.misc.Trampoline

OK, I'll create a more informative message. I think it will be more clear in the message to just say that it needs to "open" the package to javafx.base, since that would be the recommendation for a package that isn't already exported unconditionally. I'll send out a new webrev this morning

Re: 8178380: Module system implementation refresh (5/2017 update)

Hi Alan, The hotspot changes look good. Thanks, Harold On 5/1/2017 4:28 PM, Alan Bateman wrote: As I mentioned in another thread, we need to get the changes accumulated in jake to jdk9/dev. JDK-8178380 [1] has the summary of the changes that have accumulated since the last refresh. One