Re: Revised proposal for #AutomaticModuleNames

2017-05-04 Thread mark . reinhold
2017/5/4 17:58:31 -0700, bri...@infinity.nu: > On Thu, May 4, 2017 at 1:39 PM, wrote: >> Thanks to everyone, and especially Stephen Colebourne, Brian Fox, and >> Robert Scholte, for the extensive feedback. >> >> http://mail.openjdk.java.net/pipermail/jpms-spec-experts/ >> 2017-May/000687.html >>

Re: Revised proposal for #AutomaticModuleNames

2017-05-04 Thread Brian Fox
On Thu, May 4, 2017 at 1:39 PM, wrote: > Thanks to everyone, and especially Stephen Colebourne, Brian Fox, and > Robert Scholte, for the extensive feedback. > > http://mail.openjdk.java.net/pipermail/jpms-spec-experts/ > 2017-May/000687.html > > TL;DR: Keep automatic modules, bring back the mod

Re: Revised proposal for #AutomaticModuleNames

2017-05-04 Thread mark . reinhold
2017/5/4 14:21:38 -0700, Stephen Colebourne : > On 4 May 2017 at 18:38, mark.reinh...@oracle.com wrote: >> ... >> >> - Define a JAR-file manifest attribute, `Automatic-Module-Name`, whose >>value is used as the name of the automatic module defined by that JAR >>file when it is placed on t

Re: Revised proposal for #AutomaticModuleNames

2017-05-04 Thread Remi Forax
On May 4, 2017 11:21:38 PM GMT+02:00, Stephen Colebourne wrote: >On 4 May 2017 at 18:38, wrote: ... >> - To increase awareness of when automatic modules are used, and of >the >> consequences of their use, suggest that Java language compilers >issue >> two new types of warnings, an

Re: Revised proposal for #AutomaticModuleNames

2017-05-04 Thread Stephen Colebourne
On 4 May 2017 at 18:38, wrote: > - Define a JAR-file manifest attribute, `Automatic-Module-Name`, whose > value is used as the name of the automatic module defined by that JAR > file when it is placed on the module path, as previously suggested This is a step forward wrt automatic modu

Views on JSR 376 from the Eclipse JDT team

2017-05-04 Thread Markus Keller
Views on JSR 376 from the Eclipse JDT team == Here's a high-level feedback on things the Eclipse JDT team is missing in the Java Platform Module System spec (JSR 376). (This message is based on an internal note from Markus Keller but basically reflects the pos

hg: jigsaw/jake/nashorn: 2 new changesets

2017-05-04 Thread alan . bateman
Changeset: c78163ad1a4e Author:lana Date: 2017-05-04 16:38 + URL: http://hg.openjdk.java.net/jigsaw/jake/nashorn/rev/c78163ad1a4e Added tag jdk-9+168 for changeset 0f81cde5a1f7 ! .hgtags Changeset: 61cbf87f8b49 Author:alanb Date: 2017-05-04 19:06 +0100 URL: http

hg: jigsaw/jake/corba: 2 new changesets

2017-05-04 Thread alan . bateman
Changeset: b2218d41edef Author:lana Date: 2017-05-04 16:38 + URL: http://hg.openjdk.java.net/jigsaw/jake/corba/rev/b2218d41edef Added tag jdk-9+168 for changeset 03a2cc9c8a1e ! .hgtags Changeset: c8f59dfe1269 Author:alanb Date: 2017-05-04 19:02 +0100 URL: http:/

hg: jigsaw/jake/jdk: 2 new changesets

2017-05-04 Thread alan . bateman
Changeset: 8bfab0e73164 Author:lana Date: 2017-05-04 16:38 + URL: http://hg.openjdk.java.net/jigsaw/jake/jdk/rev/8bfab0e73164 Added tag jdk-9+168 for changeset e78da9db6299 ! .hgtags Changeset: 052d759c36a8 Author:alanb Date: 2017-05-04 19:02 +0100 URL: http://h

hg: jigsaw/jake/hotspot: 2 new changesets

2017-05-04 Thread alan . bateman
Changeset: f36e864e66a7 Author:lana Date: 2017-05-04 16:38 + URL: http://hg.openjdk.java.net/jigsaw/jake/hotspot/rev/f36e864e66a7 Added tag jdk-9+168 for changeset fbb9c8026495 ! .hgtags Changeset: 1d55ec6b9bc7 Author:alanb Date: 2017-05-04 19:06 +0100 URL: http

hg: jigsaw/jake/jaxp: 2 new changesets

2017-05-04 Thread alan . bateman
Changeset: df63b2d22ac6 Author:lana Date: 2017-05-04 16:38 + URL: http://hg.openjdk.java.net/jigsaw/jake/jaxp/rev/df63b2d22ac6 Added tag jdk-9+168 for changeset 23a87f409371 ! .hgtags Changeset: a89495528083 Author:alanb Date: 2017-05-04 19:02 +0100 URL: http://

hg: jigsaw/jake/jaxws: 2 new changesets

2017-05-04 Thread alan . bateman
Changeset: e66ea56c8751 Author:lana Date: 2017-05-04 16:38 + URL: http://hg.openjdk.java.net/jigsaw/jake/jaxws/rev/e66ea56c8751 Added tag jdk-9+168 for changeset 2746716dcc5a ! .hgtags Changeset: 5a7209da3317 Author:alanb Date: 2017-05-04 19:02 +0100 URL: http:/

hg: jigsaw/jake/langtools: 2 new changesets

2017-05-04 Thread alan . bateman
Changeset: c61dc27c48d1 Author:lana Date: 2017-05-04 16:38 + URL: http://hg.openjdk.java.net/jigsaw/jake/langtools/rev/c61dc27c48d1 Added tag jdk-9+168 for changeset bc21e5ba6bf1 ! .hgtags Changeset: 3ed3d69a8cc5 Author:alanb Date: 2017-05-04 19:02 +0100 URL: ht

hg: jigsaw/jake: 2 new changesets

2017-05-04 Thread alan . bateman
Changeset: 8e1d0bed44e5 Author:lana Date: 2017-05-04 16:38 + URL: http://hg.openjdk.java.net/jigsaw/jake/rev/8e1d0bed44e5 Added tag jdk-9+168 for changeset 143d4c87bc1e ! .hgtags Changeset: c6f2f8eaafb2 Author:alanb Date: 2017-05-04 19:01 +0100 URL: http://hg.op

Revised proposal for #AutomaticModuleNames

2017-05-04 Thread mark . reinhold
Thanks to everyone, and especially Stephen Colebourne, Brian Fox, and Robert Scholte, for the extensive feedback. http://mail.openjdk.java.net/pipermail/jpms-spec-experts/2017-May/000687.html TL;DR: Keep automatic modules, bring back the module-name JAR-file manifest attribute, and strongly rec

Re: [9] Review request: 8177566: FX user module gets IllegalAccessException from sun.reflect.misc.Trampoline

2017-05-04 Thread Kevin Rushforth
This seems like something that could be useful, although at this point in the release we would more likely do it for JDK 10. I do note that including the class that made the illegal access is generally a good idea when that class is attempting the access on its own behalf. For frameworks such a

Re: [9] Review request: 8177566: FX user module gets IllegalAccessException from sun.reflect.misc.Trampoline

2017-05-04 Thread Gregg Wonderly
If there is not already such an exception, it would seem like a good idea to have an exception that formats such a message from constructor parameters providing the details so that it’s the same everywhere, and so that it can be changed in once place if needed. Gregg > On May 3, 2017, at 9:48

hg: jigsaw/jake: 11 new changesets

2017-05-04 Thread alan . bateman
Changeset: e1cd0e7075ae Author:ksrini Date: 2017-04-25 07:54 -0700 URL: http://hg.openjdk.java.net/jigsaw/jake/rev/e1cd0e7075ae 8178725: provide way to link to external documentation Reviewed-by: dholmes, erikj, ihse, jjg ! make/Javadoc.gmk Changeset: 4a25d35d9159 Author:ihse

hg: jigsaw/jake/hotspot: 6 new changesets

2017-05-04 Thread alan . bateman
Changeset: f1cca489e9c6 Author:kbarrett Date: 2017-04-26 22:34 -0400 URL: http://hg.openjdk.java.net/jigsaw/jake/hotspot/rev/f1cca489e9c6 8179084: HotSpot VM fails to start when AggressiveHeap is set Summary: Don't set default ParallelGCThreads when processing AggressiveHeap Reviewe

hg: jigsaw/jake/jdk: 34 new changesets

2017-05-04 Thread alan . bateman
Changeset: fa4bdd8f0eed Author:chegar Date: 2017-04-25 14:46 +0100 URL: http://hg.openjdk.java.net/jigsaw/jake/jdk/rev/fa4bdd8f0eed 8158270: MulticastSendReceiveTests.java failed with "Expected message not received" Reviewed-by: alanb ! test/java/nio/channels/DatagramChannel/Netwo

hg: jigsaw/jake/langtools: 9 new changesets

2017-05-04 Thread alan . bateman
Changeset: 13f457e05af0 Author:smarks Date: 2017-04-25 16:14 -0700 URL: http://hg.openjdk.java.net/jigsaw/jake/langtools/rev/13f457e05af0 8168444: (jdeprscan) improper handling of primitives and primitive array types Reviewed-by: psandoz, jjg ! src/jdk.jdeps/share/classes/com/sun/t

hg: jigsaw/jake/nashorn: 3 new changesets

2017-05-04 Thread alan . bateman
Changeset: a3022cc65b17 Author:jjg Date: 2017-04-26 10:56 -0700 URL: http://hg.openjdk.java.net/jigsaw/jake/nashorn/rev/a3022cc65b17 8179304: Fix HTML 5 errors in jdk.scripting.nashorn and jdk.dynalink module Reviewed-by: sundar, jlaskey, hannesw ! src/jdk.dynalink/share/classes/jd