Re: Need help implementing Java modules

2017-05-09 Thread Remi Forax
On May 10, 2017 2:20:31 AM GMT+02:00, Ralph Goers wrote: > >> On May 9, 2017, at 3:39 PM, Alex Buckley >wrote: >> >> On 5/9/2017 3:04 PM, Ralph Goers wrote: >>> Pardon me for being dense, but my reading said that Java modules >>> disallowed runtime cycles as well as compile time. Once LoggerFi

Re: [9] Review request: 8177566: FX user module gets IllegalAccessException from sun.reflect.misc.Trampoline

2017-05-09 Thread Kevin Rushforth
inline Peter Levart wrote: Hi Kevin, On 05/02/2017 02:21 AM, Kevin Rushforth wrote: This review is being cross-posted to both openjfx-dev and jigsaw-dev. Please review the proposed fix for: https://bugs.openjdk.java.net/browse/JDK-8177566 http://cr.openjdk.java.net/~kcr/8177566/webrev.00/com

Re: Need help implementing Java modules

2017-05-09 Thread Ralph Goers
> On May 9, 2017, at 3:39 PM, Alex Buckley wrote: > > On 5/9/2017 3:04 PM, Ralph Goers wrote: >> Pardon me for being dense, but my reading said that Java modules >> disallowed runtime cycles as well as compile time. Once LoggerFinder >> binds with the module that provides that service does that

Re: Need help implementing Java modules

2017-05-09 Thread Alex Buckley
On 5/9/2017 3:04 PM, Ralph Goers wrote: Pardon me for being dense, but my reading said that Java modules disallowed runtime cycles as well as compile time. Once LoggerFinder binds with the module that provides that service does that not create a runtime dependency? I don’t recall seeing anything

Re: Problems with non-exported split packages (for resources/files)

2017-05-09 Thread Mandy Chung
On May 9, 2017, at 1:33 PM, Sven Strohschein wrote: > > There is a very practical example which isn't a bad practice: Resources. > Imagine that every Java module has its own ResourceBundle properties for > multi-language support (or imagine any other file which is not a Java class). > These fi

Re: Need help implementing Java modules

2017-05-09 Thread Ralph Goers
> On May 9, 2017, at 12:50 PM, Jochen Theodorou wrote: > > On 09.05.2017 20:51, Ralph Goers wrote: > >> We also noticed that System.LoggerFinder [1] now provides a new way >> to integrate an external logging framework with Java. If Log4j >> creates the service provider for that how will that no

Problems with non-exported split packages (for resources/files)

2017-05-09 Thread Sven Strohschein
Hi, I'm trying to switch a project from OSGi to Jigsaw with the latest JDK 9 ea build (168). The most is working fine and I like that it is much easier and much more practical than OSGi. But there is one strong limitation within Jigsaw which I don't understand, which is much more restrictive

Re: Need help implementing Java modules

2017-05-09 Thread Alex Buckley
On 5/9/2017 11:51 AM, Ralph Goers wrote: I am attempting to modularize Log4j and am running into some trouble understanding how this can work. Log4j supports many Appenders, such as the FlumeAppender, KafkaAppender, CassandraAppender, and JPAAppender. I don't know how Log4j is currently discov

Re: Need help implementing Java modules

2017-05-09 Thread Jochen Theodorou
On 09.05.2017 20:51, Ralph Goers wrote: I am attempting to modularize Log4j and am running into some trouble understanding how this can work. Log4j supports many Appenders, such as the FlumeAppender, KafkaAppender, CassandraAppender, and JPAAppender. Each of these use their respective libraries

Need help implementing Java modules

2017-05-09 Thread Ralph Goers
I am attempting to modularize Log4j and am running into some trouble understanding how this can work. Log4j supports many Appenders, such as the FlumeAppender, KafkaAppender, CassandraAppender, and JPAAppender. Each of these use their respective libraries to cause the log events to be delivered

bidirectional dependencies in AOP-like languages?

2017-05-09 Thread Stephan Herrmann
Over in jpms-spec-experts I still see discussion about #CyclicDependences, which made me wonder (admittedly late), what will be the solution for AOP-like languages which inherently need bidirectional dependencies? Is it correct that at runtime cycles pose no problems? Let's assume a language usi

An alternative to "restricted keywords"

2017-05-09 Thread Stephan Herrmann
(1) I understand the need for avoiding that new module-related keywords conflict with existing code, where these words may be used as identifiers. Moreover, it must be possible for a module declaration to refer to packages or types thusly named. However, (2) The currently proposed "restricted ke

Re: Revised proposal for #AutomaticModuleNames

2017-05-09 Thread Alan Bateman
Just a quick note to say that the initial support for the Automatic-Module-Name JAR file attribute is in the Jigsaw EA builds [1] for those that want to try it out. -Alan [1] http://jdk.java.net/jigsaw/

Re: Accessing module internals from bytecode rewriting agent

2017-05-09 Thread Andrew Dinn
On 09/05/17 11:56, Alan Bateman wrote: > On 09/05/2017 01:45, Martin Buchholz wrote: > >> On Tue, May 2, 2017 at 2:40 AM, Andrew Dinn wrote: >> >>> Just wanted to post a heads-up that this fall-back behaviour has now >>> been implemented in Byteman release 4.0.0-BETA5. >> >> Thanks - I can confir

Re: Accessing module internals from bytecode rewriting agent

2017-05-09 Thread Alan Bateman
On 09/05/2017 01:45, Martin Buchholz wrote: On Tue, May 2, 2017 at 2:40 AM, Andrew Dinn wrote: Just wanted to post a heads-up that this fall-back behaviour has now been implemented in Byteman release 4.0.0-BETA5. Thanks - I can confirm 4.0.0-BETA5 works for me. Also Mandy has pushed the fix