Re: Review Request JDK-8182416: Clean up module-info.java like move requires transitive adjacent to exports

2017-06-17 Thread Lance Andersen
The changes looked fine Mandy. Nice that everything is consistent best lance > On Jun 17, 2017, at 2:27 AM, Mandy Chung wrote: > > http://cr.openjdk.java.net/~mchung/jdk9/webrevs/8182416/webrev.00/ > > This patch cleans up module-info.java mainly moving requires transitive > before exports, g

Re: Review Request JDK-8182416: Clean up module-info.java like move requires transitive adjacent to exports

2017-06-17 Thread Alan Bateman
On 17/06/2017 07:27, Mandy Chung wrote: http://cr.openjdk.java.net/~mchung/jdk9/webrevs/8182416/webrev.00/ This patch cleans up module-info.java mainly moving requires transitive before exports, group exports/opens (packages) together and uses/provides (services) next. Document if a module is u

hg: jigsaw/jake/jaxws: 2 new changesets

2017-06-17 Thread alan . bateman
Changeset: c9b85ef1567e Author:lancea Date: 2017-06-16 19:12 -0400 URL: http://hg.openjdk.java.net/jigsaw/jake/jaxws/rev/c9b85ef1567e 8182405: add legal file for freebxml Reviewed-by: mchung + src/jdk.xml.bind/share/legal/freebxml.md Changeset: e8582f469c79 Author:alanb Date:

hg: jigsaw/jake: 7 new changesets

2017-06-17 Thread alan . bateman
Changeset: 35f50e9952e4 Author:mchung Date: 2017-06-13 10:44 -0700 URL: http://hg.openjdk.java.net/jigsaw/jake/rev/35f50e9952e4 8182029: Make the top-level docs index.html to a HTML-level redirect to the API overview page Reviewed-by: alanb, erikj, ihse ! make/Docs.gmk Changeset:

hg: jigsaw/jake/jdk: 20 new changesets

2017-06-17 Thread alan . bateman
Changeset: e8f3a872e69a Author:psandoz Date: 2017-06-12 14:30 -0700 URL: http://hg.openjdk.java.net/jigsaw/jake/jdk/rev/e8f3a872e69a 8181442: Deprecate sun.misc.Unsafe.defineClass Reviewed-by: shade, mchung ! src/jdk.unsupported/share/classes/sun/misc/Unsafe.java Changeset: 573efb

hg: jigsaw/jake/corba: 2 new changesets

2017-06-17 Thread alan . bateman
Changeset: e68b042f7130 Author:msheppar Date: 2017-06-16 20:37 +0100 URL: http://hg.openjdk.java.net/jigsaw/jake/corba/rev/e68b042f7130 8181836: BadKindHelper.html and BoundsHelper.html contains broken link in the javadoc Reviewed-by: chegar ! src/java.corba/share/classes/org/omg/

hg: jigsaw/jake/langtools: 5 new changesets

2017-06-17 Thread alan . bateman
Changeset: bbb3a10fce39 Author:jjg Date: 2017-06-15 14:45 -0700 URL: http://hg.openjdk.java.net/jigsaw/jake/langtools/rev/bbb3a10fce39 8181825: Add tool and services information to module summary Reviewed-by: mchung, rfield ! src/jdk.compiler/share/classes/com/sun/tools/javac/Main.

hg: jigsaw/jake/hotspot: 11 new changesets

2017-06-17 Thread alan . bateman
Changeset: 79b6a9bd5c3b Author:fyang Date: 2017-06-10 16:01 +0800 URL: http://hg.openjdk.java.net/jigsaw/jake/hotspot/rev/79b6a9bd5c3b 8181906: AArch64: port bugfix for 7009641 to AArch64 Summary: Allocation in the code cache returns NULL instead of failing the entire VM Reviewed-b

hg: jigsaw/jake/jaxp: 2 new changesets

2017-06-17 Thread alan . bateman
Changeset: f0eb5431121e Author:joehw Date: 2017-06-15 12:40 -0700 URL: http://hg.openjdk.java.net/jigsaw/jake/jaxp/rev/f0eb5431121e 8182111: Package summary is missing in jdk.xml.dom module Reviewed-by: mchung + src/jdk.xml.dom/share/classes/org/w3c/dom/css/package-info.java + src/

Re: Review Request JDK-8182416: Clean up module-info.java like move requires transitive adjacent to exports

2017-06-17 Thread Mandy Chung
> On Jun 17, 2017, at 7:26 AM, Alan Bateman wrote: > > On 17/06/2017 07:27, Mandy Chung wrote: >> http://cr.openjdk.java.net/~mchung/jdk9/webrevs/8182416/webrev.00/ >> >> This patch cleans up module-info.java mainly moving requires transitive >> before exports, group exports/opens (packages) to

Re: Review Request JDK-8182416: Clean up module-info.java like move requires transitive adjacent to exports

2017-06-17 Thread Alan Bateman
On 17/06/2017 16:19, Mandy Chung wrote: On Jun 17, 2017, at 7:26 AM, Alan Bateman wrote: On 17/06/2017 07:27, Mandy Chung wrote: http://cr.openjdk.java.net/~mchung/jdk9/webrevs/8182416/webrev.00/ This patch cleans up module-info.java mainly moving requires transitive before exports, group e