Re: RFR 8189777: jlink --module-path default value and automatic addition of $JAVA_HOME/jmods if java.base is missing

2017-10-25 Thread Alan Bateman
On 25/10/2017 14:43, Sundararajan Athijegannathan wrote: Second constructor is used by packager (internal) api. I could move getDefaultModulePath to JlinkTask.. Ugh, we need to get packager moved away from using this. -Alan.

Re: RFR 8189777: jlink --module-path default value and automatic addition of $JAVA_HOME/jmods if java.base is missing

2017-10-25 Thread Sundararajan Athijegannathan
Second constructor is used by packager (internal) api. I could move getDefaultModulePath to JlinkTask.. -Sundar On 25/10/17, 6:25 PM, Alan Bateman wrote: On 25/10/2017 11:23, Sundararajan Athijegannathan wrote: Updated: http://cr.openjdk.java.net/~sundar/8189777/webrev.03/ This looks better.

Re: RFR 8189777: jlink --module-path default value and automatic addition of $JAVA_HOME/jmods if java.base is missing

2017-10-25 Thread Alan Bateman
On 25/10/2017 11:23, Sundararajan Athijegannathan wrote: Updated: http://cr.openjdk.java.net/~sundar/8189777/webrev.03/ This looks better. A few comments/questions: Does the JlinkConfiguration constructor that takes the ModuleFinder still need the module path? I assume it shouldn't be needed n

Re: RFR 8189777: jlink --module-path default value and automatic addition of $JAVA_HOME/jmods if java.base is missing

2017-10-25 Thread Sundararajan Athijegannathan
Updated: http://cr.openjdk.java.net/~sundar/8189777/webrev.03/ Thanks -Sundar On 24/10/17, 10:40 PM, mandy chung wrote: On 10/23/17 9:05 PM, Sundararajan Athijegannathan wrote: Hi, * ALL-MODULE-PATH case seems to be handled fine (in private JlinkConfiguration initJlinkConfig() throws BadA