Re: RFR 8177471: jlink should use the version from java.base.jmod to find modules

2017-11-13 Thread mandy chung
Looks good.  Thanks for fixing this. Mandy On 11/13/17 2:02 AM, Sundararajan Athijegannathan wrote: Please review. Bug: https://bugs.openjdk.java.net/browse/JDK-8177471 Webrev: http://cr.openjdk.java.net/~sundar/8177471/webrev.00/index.html Thanks to Mandy for initial (internal) round of rev

Re: Patterns for libraries to access private state of user modules

2017-11-13 Thread Alan Bateman
On 13/11/2017 16:54, David Lloyd wrote: : My understanding is that you should be using MethodHandlers.privateLookupIn(userClazz, lookup()); and that the user module should be "open" to you (i.e. they have to opt in to granting reflection access). Part of this was tied up in the discussion around

Re: RFR 8177471: jlink should use the version from java.base.jmod to find modules

2017-11-13 Thread Alan Bateman
On 13/11/2017 16:36, Sundararajan Athijegannathan wrote: Thanks for the review. Updated as per suggestions: http://cr.openjdk.java.net/~sundar/8177471/webrev.01/index.html I think this looks fine. -Alan

Re: Patterns for libraries to access private state of user modules

2017-11-13 Thread David Lloyd
On Mon, Nov 13, 2017 at 10:03 AM, Gunnar Morling wrote: > Hi, > > Libraries such as Hibernate often need to access private state of classes > from other modules (e.g. when using field access for JPA entities). > > [...] I can't see how a utility > method in my library could obtain the Lookup, as M

Re: RFR 8177471: jlink should use the version from java.base.jmod to find modules

2017-11-13 Thread Sundararajan Athijegannathan
Thanks for the review. Updated as per suggestions: http://cr.openjdk.java.net/~sundar/8177471/webrev.01/index.html -Sundar On 13/11/17, 8:39 PM, Alan Bateman wrote: On 13/11/2017 08:02, Sundararajan Athijegannathan wrote: Please review. Bug: https://bugs.openjdk.java.net/browse/JDK-8177471

Patterns for libraries to access private state of user modules

2017-11-13 Thread Gunnar Morling
Hi, Libraries such as Hibernate often need to access private state of classes from other modules (e.g. when using field access for JPA entities). Assuming that such library and the user's JAR are both provided as JPMS (named) modules, it had been my understanding so far [1], that the library shou

Re: RFR 8177471: jlink should use the version from java.base.jmod to find modules

2017-11-13 Thread Alan Bateman
On 13/11/2017 08:02, Sundararajan Athijegannathan wrote: Please review. Bug: https://bugs.openjdk.java.net/browse/JDK-8177471 Webrev: http://cr.openjdk.java.net/~sundar/8177471/webrev.00/index.html Thanks to Mandy for initial (internal) round of review and suggesting me simplifications on my