Re: RFR JDK-8170114 jimage extract to not an empty directory overwrites content of the directory

2018-02-09 Thread mandy chung
On 2/9/18 7:23 AM, Michal Vala wrote: Patch validates output directory before any jimage extracting happen. I've moved validation to extra private method as it is few lines of code. I've also added proper error message for case when output path is not a directory (JImageTask.java#449). Th

Fwd: RFR JDK-8170114 jimage extract to not an empty directory overwrites content of the directory

2018-02-09 Thread Michal Vala
ah, accidentally replied just to Alan :/ Here it is -- Forwarded message -- From: Michal Vala Date: Fri, Feb 9, 2018 at 6:21 PM Subject: Re: RFR JDK-8170114 jimage extract to not an empty directory overwrites content of the directory To: Alan Bateman sure, here it is http://cr

Re: RFR JDK-8170114 jimage extract to not an empty directory overwrites content of the directory

2018-02-09 Thread Andrew Hughes
On 9 February 2018 at 15:38, Alan Bateman wrote: > On 09/02/2018 15:23, Michal Vala wrote: >> >> Hi, >> >> sending fix for jimage bug JDK-8170114[1]. I'm not sure whether this is >> correct list. If it is not, please direct me somewhere else. >> >> I don't have an openjdk account, so webrev is on

Re: RFR JDK-8170114 jimage extract to not an empty directory overwrites content of the directory

2018-02-09 Thread Alan Bateman
On 09/02/2018 15:23, Michal Vala wrote: Hi, sending fix for jimage bug JDK-8170114[1]. I'm not sure whether this is correct list. If it is not, please direct me somewhere else. I don't have an openjdk account, so webrev is on my fedora public space. I will need a sponsor for this. webrev:

RFR JDK-8170114 jimage extract to not an empty directory overwrites content of the directory

2018-02-09 Thread Michal Vala
Hi, sending fix for jimage bug JDK-8170114[1]. I'm not sure whether this is correct list. If it is not, please direct me somewhere else. I don't have an openjdk account, so webrev is on my fedora public space. I will need a sponsor for this. webrev: https://michalvala.fedorapeople.org/webr