Looks good. I agree that this should be an error when excluding module
declaration. Mandy
On 2/20/18 1:50 AM, Sundararajan Athijegannathan wrote:
Throwing exception now ->
http://cr.openjdk.java.net/~sundar/8194922/webrev.02/
Thanks
-Sundar
On 20/02/18, 2:54 PM, Alan Bateman wrote:
On 20/
On 02/20/2018 10:47 AM, Alan Bateman wrote:
On 19/02/2018 14:51, Michal Vala wrote:
Hi,
sending patch fixing JImageListTest failing tests. It was in ProblemList and
this fix greens the test case, so the patch also removes it from the list.
These tests are failing on Windows now. Nothing to
On 20/02/2018 09:50, Sundararajan Athijegannathan wrote:
Throwing exception now ->
http://cr.openjdk.java.net/~sundar/8194922/webrev.02/
This looks good to me.
-Alan
Throwing exception now ->
http://cr.openjdk.java.net/~sundar/8194922/webrev.02/
Thanks
-Sundar
On 20/02/18, 2:54 PM, Alan Bateman wrote:
On 20/02/2018 08:08, Sundararajan Athijegannathan wrote:
Updated: http://cr.openjdk.java.net/~sundar/8194922/webrev.01/
* replaced endsWith with equals on
On 19/02/2018 14:51, Michal Vala wrote:
Hi,
sending patch fixing JImageListTest failing tests. It was in
ProblemList and this fix greens the test case, so the patch also
removes it from the list.
These tests are failing on Windows now. Nothing to do with your changes,
it seems the original
On 20/02/2018 08:08, Sundararajan Athijegannathan wrote:
Updated: http://cr.openjdk.java.net/~sundar/8194922/webrev.01/
* replaced endsWith with equals on $MODULE/module-info.class
* jlink shows warning when module-info.class is not included (but
implied to be excluded by --exclude-resources p
Updated: http://cr.openjdk.java.net/~sundar/8194922/webrev.01/
* replaced endsWith with equals on $MODULE/module-info.class
* jlink shows warning when module-info.class is not included (but
implied to be excluded by --exclude-resources pattern)
* Renamed the test.
Thanks,
-Sundar
On 19/02/18