Re: module readability and exceptions in api

2018-10-12 Thread Michał Zegan
W dniu 10.10.2018 o 22:09, Michał Zegan pisze: > > > W dniu 10.10.2018 o 20:36, Alan Bateman pisze: >> On 10/10/2018 17:43, Michał Zegan wrote: >>> 2. What is the use for Module.addReads and >>> ModuleLayer.Controller.addReads methods? >> Module addReads is important when generating bytecode i

Re[2]: Patch-module with dynamic layer creating.

2018-10-12 Thread Alex Sviridov
Hi Alan, Thank you for detailed explanation. It is great that we have API that allows to implement such features. However, what I suggest is a little different. I am speaking about using existing code for such features. I think this way - firstly, we can do write the same code many times. We

Re: Patch-module with dynamic layer creating.

2018-10-12 Thread Alan Bateman
On 12/10/2018 16:00, Alex Sviridov wrote: I am speaking not only about patch-module but about all possible options: --add-exports, --add-opens, --patch-module, --add-modules, --add-reads etc. ModuleLayer defines static variants of the defineModuleXXX methods that return a Controller object that

Re[2]: Patch-module with dynamic layer creating.

2018-10-12 Thread Alex Sviridov
I am speaking not only about patch-module but about all possible options: --add-exports, --add-opens, --patch-module, --add-modules, --add-reads etc. Agree that "custom" support for them is not a good way. Alex >Пятница, 12 октября 2018, 17:50 +03:00 от Alan Bateman >: > >On 12/10/2018 13:16

Re: Patch-module with dynamic layer creating.

2018-10-12 Thread Alan Bateman
On 12/10/2018 13:16, Alex Sviridov wrote: Hi Alan Maybe it is necessary to add possibility to have equal control for boot layer and other layers. Because layers are graph but at this moment we can do for boot layer more then for others -> if we work with non boot layers we must use another sol

Re[2]: Patch-module with dynamic layer creating.

2018-10-12 Thread Alex Sviridov
Hi Alan Maybe it is necessary to add possibility to have equal control for boot layer and other layers. Because layers are graph but at this moment we can do for boot layer more then for others -> if we work with non boot layers we must use another solutions -> different solutions within one te