Re: RFR: 8214230: Classes generated by SystemModulesPlugin.java are not reproducable

2018-11-29 Thread Alan Bateman
On 29/11/2018 08:47, Erik Helin wrote: I agree as well, nice suggestion Claes! Please see updated patches below: - incremental: http://cr.openjdk.java.net/~ehelin/8214230/00-01/ - full: http://cr.openjdk.java.net/~ehelin/8214230/01/ Re-tested that this works as expected on Linux x86-64 by runn

Re: RFR: 8214230: Classes generated by SystemModulesPlugin.java are not reproducable

2018-11-29 Thread Mandy Chung
On 11/29/18 12:47 AM, Erik Helin wrote: I agree as well, nice suggestion Claes! Please see updated patches below: - incremental: http://cr.openjdk.java.net/~ehelin/8214230/00-01/ - full: http://cr.openjdk.java.net/~ehelin/8214230/01/ +1 Mandy

Re: RFR: 8214230: Classes generated by SystemModulesPlugin.java are not reproducable

2018-11-29 Thread Erik Helin
Alan, Claes, Mandy, thank you all for your quick reviews, appreciate it. On 11/28/2018 04:01 PM, Alan Bateman wrote: On 28/11/2018 13:49, Claes Redestad wrote: (Nit) You could consider the old TreeMap trick to ensure key-sorted map iteration order: // convert to a TreeMap to ensure sorted it