Re: RFR: 8214796: Create a jlink plugin for stripping debug info symbols from native libraries

2019-02-26 Thread Mandy Chung
Hi Severin, This is my initial set of comments. On 2/26/19 3:01 AM, Severin Gehwolf wrote: --list-plugins output for --strip-native-debug-symbols: Plugin Name: strip-native-debug-symbols Option: --strip-native-debug-symbols= Description: Strip debug symbols from native libraries (if any). T

Re: ModuleLayer.defineModules function clf must be stateful?

2019-02-26 Thread Alan Bateman
On 26/02/2019 19:38, Thomas Watson wrote: I noticed that the clf function passed to ModuleLayer.defineModules(Configuration, List, Function) is called at least twice for every module name contained in the new ModuleLayer. Once for the call to java.lang.ModuleLayer.checkForDuplicatePkgs(Configura

ModuleLayer.defineModules function clf must be stateful?

2019-02-26 Thread Thomas Watson
I noticed that the clf function passed to ModuleLayer.defineModules(Configuration, List, Function) is called at least twice for every module name contained in the new ModuleLayer. Once for the call to java.lang.ModuleLayer.checkForDuplicatePkgs(Configuration, Function) and once for the call to jav

Re: RFR: 8214796: Create a jlink plugin for stripping debug info symbols from native libraries

2019-02-26 Thread Alan Bateman
On 26/02/2019 11:01, Severin Gehwolf wrote: : --list-plugins output for --strip-native-debug-symbols: Plugin Name: strip-native-debug-symbols Option: --strip-native-debug-symbols= Description: Strip debug symbols from native libraries (if any). This plugin requires at least one option: ob

Re: RFR: 8214796: Create a jlink plugin for stripping debug info symbols from native libraries

2019-02-26 Thread Severin Gehwolf
On Tue, 2019-02-26 at 09:46 +, Alan Bateman wrote: > On 25/02/2019 22:26, Mandy Chung wrote: > > Adding the "-files" suffix sounds good to me. I'm okay > > with omit-debuginfo-files or exclude-debuginfo-files. > > > > One comment though this is a plugin option name rather than > > a plugin na

Re: RFR: 8214796: Create a jlink plugin for stripping debug info symbols from native libraries

2019-02-26 Thread Alan Bateman
On 25/02/2019 22:26, Mandy Chung wrote: Adding the "-files" suffix sounds good to me.  I'm okay with omit-debuginfo-files or exclude-debuginfo-files. One comment though this is a plugin option name rather than a plugin name (so not necessarily to consider consistency with plugin names). True a