Re: RFR: JDK-8220702: compiling in the context of an automatic module disallows --add-modules ALL-MODULE-PATH

2019-04-11 Thread Alex Buckley
On 4/11/2019 12:00 PM, Christian Stein wrote: I'm not sure if this helps in any regards -- here [1] is a draft PR that adds explicit module descriptors to all JUnit 5 modules. This PR uses javac in multi-module mode and --patch-module to access the already (with --release 8) compiled classes of

Re: RFR: JDK-8220702: compiling in the context of an automatic module disallows --add-modules ALL-MODULE-PATH

2019-04-11 Thread Christian Stein
On Thu, Apr 11, 2019 at 8:30 PM Alex Buckley wrote: > [...] In advance > of that, can you share some detailed invocations of javac using > --patch-module in single-module and multi-module mode? > I'm not sure if this helps in any regards -- here [1] is a draft PR that adds explicit module descri

Re: RFR: JDK-8220702: compiling in the context of an automatic module disallows --add-modules ALL-MODULE-PATH

2019-04-11 Thread Alex Buckley
On 4/11/2019 1:19 AM, Jan Lahoda wrote: Yes, I think JEP 261 may need updates. I'd say this is somewhat unforeseen interaction between automatic modules and --patch-module. When patching a (named) module (or a set of named modules), that module (or modules) become the root module for javac, and

Re: RFR: JDK-8220702: compiling in the context of an automatic module disallows --add-modules ALL-MODULE-PATH

2019-04-11 Thread Jan Lahoda
On 11. 04. 19 0:19, Jonathan Gibbons wrote: On 4/10/19 3:07 PM, Alex Buckley wrote: On 4/10/2019 2:51 PM, Jonathan Gibbons wrote: On 4/10/19 11:51 AM, Alex Buckley wrote: There is a question to be answered: When the compiler compiles code in an automatic module (due to the code being observed