Re: RFR: JDK-8220702: compiling in the context of an automatic module disallows --add-modules ALL-MODULE-PATH

2019-04-12 Thread Alex Buckley
On 4/12/2019 5:34 AM, Jan Lahoda wrote: I've started with the CSR here: https://bugs.openjdk.java.net/browse/JDK-8222396 Looks pretty good. I made some edits to record both of your single-module and multi-module invocations of javac. The use case of injecting test code is clear, but the exac

Re: RFR: JDK-8220702: compiling in the context of an automatic module disallows --add-modules ALL-MODULE-PATH

2019-04-12 Thread Alan Bateman
On 12/04/2019 13:34, Jan Lahoda wrote: : Consider a directory "path" that contains "automatic.jar", which does not have a module-info.class, and "explicit.jar" which has module-info.class. The a compilation in multi-module mode might look like this: $ javac -d out --patch-module automatic=tes

Re: RFR: JDK-8220702: compiling in the context of an automatic module disallows --add-modules ALL-MODULE-PATH

2019-04-12 Thread Jan Lahoda
On 11. 04. 19 20:28, Alex Buckley wrote: On 4/11/2019 1:19 AM, Jan Lahoda wrote: Yes, I think JEP 261 may need updates. I'd say this is somewhat unforeseen interaction between automatic modules and --patch-module. When patching a (named) module (or a set of named modules), that module (or modul