Re: RFR: JDK-8220702: compiling in the context of an automatic module disallows --add-modules ALL-MODULE-PATH

2019-05-13 Thread Alex Buckley
On 5/13/2019 6:02 AM, Jan Lahoda wrote: Could I please get a review on the CSR? https://bugs.openjdk.java.net/browse/JDK-8222396 Added myself as a reviewer. Alex And also on the patch: http://cr.openjdk.java.net/~jlahoda/8220702/webrev.01/ Thanks! Jan On 06. 05. 19 21:06, Alex Buckley wr

Re: RFR: JDK-8220702: compiling in the context of an automatic module disallows --add-modules ALL-MODULE-PATH

2019-05-13 Thread Jan Lahoda
Thanks Alex! Could I please get a review on the CSR? https://bugs.openjdk.java.net/browse/JDK-8222396 And also on the patch: http://cr.openjdk.java.net/~jlahoda/8220702/webrev.01/ Thanks! Jan On 06. 05. 19 21:06, Alex Buckley wrote: On 4/12/2019 12:03 PM, Alex Buckley wrote: On 4/12/2019 5

Re: RFR: 8214796: Create a jlink plugin for stripping debug info symbols from native libraries

2019-05-13 Thread Severin Gehwolf
On Sun, 2019-05-12 at 09:35 +0100, Alan Bateman wrote: > On 08/05/2019 15:37, sgehw...@redhat.com wrote: > > : > > > stripBinary uses ProcessBuilder to launch objdump but it doesn't > > > redirect or read from the process streams. This could make diagnosing > > > problems difficult so I think it sh