Re: Nashorn on the module-path

Hi Hannes, what you see is the expected output. Those assumptions are meant to fail ... perhaps a not so intuitive form of printing the test module name to console. The interesting lines are printed prior to the test run tree: Running the tests on the `--module-path` yields: >> org.junit.jupite

Re: Nashorn on the module-path

Hi Christian, I cloned and tried your example project. When I run the project, I get one successful and one aborted tests in both cases: Module path output: └─ JUnit Jupiter ✔ └─ CheckTests ✔ ├─ test() ✔ └─ emitStringRepresentationOfTestModule() ■ Assumption failed: module check

Re: RFR 8216553: JrtFIleSystemProvider getPath(URI) omits /modules element from file path

On 27/05/2019 10:18, Sundararajan Athijegannathan wrote: Please review. Bug: https://bugs.openjdk.java.net/browse/JDK-8216553 Webrev: https://cr.openjdk.java.net/~sundar/8216553/webrev.00/ This addresses the points we discussed in the JIRA issue so I think it looks good. -Alan

Re: RFR 8216553: JrtFIleSystemProvider getPath(URI) omits /modules element from file path

+1 > On May 27, 2019, at 6:18 AM, Sundararajan Athijegannathan > wrote: > > Please review. > > Bug: https://bugs.openjdk.java.net/browse/JDK-8216553 > Webrev: https://cr.openjdk.java.net/~sundar/8216553/webrev.00/ > > Thanks, > -Sundar > >

Re: Nashorn on the module-path

Thanks. I'll check it out. -Sundar On 27/05/19, 3:10 PM, Christian Stein wrote: On Mon, May 27, 2019 at 11:37 AM Sundararajan Athijegannathan > wrote: How can this be reproduced at out end? I compiled a small example project at [1] that de

Re: Nashorn on the module-path

On Mon, May 27, 2019 at 11:37 AM Sundararajan Athijegannathan < sundararajan.athijegannat...@oracle.com> wrote: > How can this be reproduced at out end? I compiled a small example project at [1] that describes and demonstrates the issue. Please view the README.md file for details. You may repro

Re: Nashorn on the module-path

How can this be reproduced at out end? Thanks -Sundar On 26/05/19, 2:47 PM, Christian Stein wrote: Have you brought this up on nashorn-dev... No, but cc-ed that list now. ...as this might require digging into the dynalink linker and how method handles are used. Do you think it's still worth

RFR 8216553: JrtFIleSystemProvider getPath(URI) omits /modules element from file path

Please review. Bug: https://bugs.openjdk.java.net/browse/JDK-8216553 Webrev: https://cr.openjdk.java.net/~sundar/8216553/webrev.00/ Thanks, -Sundar