Re: RFR 8220700: jlink generated launcher script needs quoting to avoid parameter expansion

2019-08-20 Thread sundararajan . athijegannathan
Updated to add a test: http://cr.openjdk.java.net/~sundar/8220700/webrev.01 PS. There are launcher tests in BasicTest.java and arguments are passed even - but args are only printed. The new test passes args and checks the return value that is computed using the args. Thanks, -Sundar On 20/

Re: RFR 8220700: jlink generated launcher script needs quoting to avoid parameter expansion

2019-08-20 Thread Alan Bateman
On 20/08/2019 17:25, Mandy Chung wrote: +1 What we really want is to replace this stop-gap shell script some day with jlink to generate the native launcher [1]. I agree. One other thing for stop-gap is a test as we could easily regress without any of the existing tests catching it. -Alan

Re: RFR 8220700: jlink generated launcher script needs quoting to avoid parameter expansion

2019-08-20 Thread Mandy Chung
+1 What we really want is to replace this stop-gap shell script some day with jlink to generate the native launcher [1]. Mandy [1] JDK-8182555 On 8/20/19 4:52 AM, sundararajan.athijegannat...@oracle.com wrote: Oops. Wrong bug link. Correct one: https://bugs.openjdk.java.net/browse/JDK-82207

Re: RFR 8220700: jlink generated launcher script needs quoting to avoid parameter expansion

2019-08-20 Thread sundararajan . athijegannathan
Oops. Wrong bug link. Correct one: https://bugs.openjdk.java.net/browse/JDK-8220700 -Sundar On 20/08/19 5:17 pm, sundararajan.athijegannat...@oracle.com wrote: Please review. Bug: https://bugs.openjdk.java.net/browse/JDK-8182555 Webrev: http://cr.openjdk.java.net/~sundar/8220700/webrev.00/

RFR 8220700: jlink generated launcher script needs quoting to avoid parameter expansion

2019-08-20 Thread sundararajan . athijegannathan
Please review. Bug: https://bugs.openjdk.java.net/browse/JDK-8182555 Webrev: http://cr.openjdk.java.net/~sundar/8220700/webrev.00/ Thanks, -Sundar