Classloading with multiple parent layers JDK11 vs JDK14

2020-04-17 Thread Alex Sviridov
Hi all,   I have the following layers:   LayerA (moduleA)                   LayerB (moduleB)              |_|                                  |                    LayerC(moduleC)   LayerC has two parent layers layerA and LayerB and moduleC requires moduleA and moduleB. When I

Re: RFR: 8242452: During module definition, move conversion of packages from native to VM

2020-04-17 Thread Claes Redestad
Hi Harold, On 2020-04-17 15:32, Harold Seigel wrote: Hi Claes, The change looks good.  Just a couple of minor things. thank you for reviewing! In JavaClasses.cpp, line 652, does length need to be initialized to zero? Good point, most of the length variables passed by reference to

Re: RFR 8242859: test/jdk/tools/jlink/JLinkTest.java uses nashorn module

2020-04-17 Thread Jim Laskey
+1 > On Apr 17, 2020, at 7:06 AM, sundararajan.athijegannat...@oracle.com wrote: > > Please review. > > Bug: https://bugs.openjdk.java.net/browse/JDK-8242859 > > Webrev: http://cr.openjdk.java.net/~sundar/8242859/webrev.00/ > > Relevant JLinkTest.java section deleted as part of nashorn

Re: RFR (T): 8242846: removed an empty file test/jdk/tools/jlink/plugins/OrderResourcesPluginTest.java

2020-04-17 Thread Ao Qi
Hi, The original email is waiting for moderator approval. Subscribed to jigsaw-dev and resent the RFR (cc'ed core-libs-dev). Thanks, Ao Qi On Wed, Apr 15, 2020 at 10:11 PM Ao Qi wrote: > > Hi all, > > test/jdk/tools/jlink/plugins/OrderResourcesPluginTest.java was changed > to an empty file by

RFR 8242859: test/jdk/tools/jlink/JLinkTest.java uses nashorn module

2020-04-17 Thread sundararajan . athijegannathan
Please review. Bug: https://bugs.openjdk.java.net/browse/JDK-8242859 Webrev: http://cr.openjdk.java.net/~sundar/8242859/webrev.00/ Relevant JLinkTest.java section deleted as part of nashorn removal is as follows:

Re: RFR 8242860: test/jdk/tools/jlink/ModuleNamesOrderTest.java uses nashorn module

2020-04-17 Thread Alan Bateman
On 17/04/2020 07:21, sundararajan.athijegannat...@oracle.com wrote: Hi, nashorn modules were used only as an example in this test. Using jdk.jshell module instead to test known module dependencies in jlink produced images. Please review. Bug: https://bugs.openjdk.java.net/browse/JDK-8242860

RFR 8242860: test/jdk/tools/jlink/ModuleNamesOrderTest.java uses nashorn module

2020-04-17 Thread sundararajan . athijegannathan
Hi, nashorn modules were used only as an example in this test. Using jdk.jshell module instead to test known module dependencies in jlink produced images. Please review. Bug: https://bugs.openjdk.java.net/browse/JDK-8242860 Webrev: http://cr.openjdk.java.net/~sundar/8242860/webrev.00/