Re: [JDK 11] Problem list tools/jimage/JImageExtractTest.java for macosx-all

On 28/02/2018 6:23 PM, Alan Bateman wrote: On 28/02/2018 08:53, Amy Lu wrote: Please review the patch to problem list tools/jimage/JImageExtractTest.java for macosx-all. This test fails frequently (observed at Mac) and should be problem listed before JDK-8198819 fixed. bug: https

[JDK 11] Problem list tools/jimage/JImageExtractTest.java for macosx-all

Please review the patch to problem list tools/jimage/JImageExtractTest.java for macosx-all. This test fails frequently (observed at Mac) and should be problem listed before JDK-8198819 fixed. bug: https://bugs.openjdk.java.net/browse/JDK-8198820 webrev: http://cr.openjdk.java.net/~amlu/819882

Re: 8177530: Module system implementation refresh (4/2017)

://bugs.openjdk.java.net/browse/JDK-8177751 On Apr 5, 2017, at 7:35 PM, Amy Lu wrote: Hi, Alan I noticed test tools/launcher/FXLauncherTest.java fails with jigsaw-nightly-h6277-20170404 (on Windows platform). Is that because related OpenJFX changes are not yet in the mentioned build? Thanks, Amy

Re: 8177530: Module system implementation refresh (4/2017)

Hi, Alan I noticed test tools/launcher/FXLauncherTest.java fails with jigsaw-nightly-h6277-20170404 (on Windows platform). Is that because related OpenJFX changes are not yet in the mentioned build? Thanks, Amy On 4/5/17 12:28 AM, Alan Bateman wrote: As I mentioned on jigsaw-dev yesterday, w

JDK 9 RFR of JDK-8167525: update jdk tests to remove @compile --add-modules workaround

Please review the patch to remove the @compile --add-modules workaround. In the past, tests added --add-modules to @compile (JDK-8169231) or to @run (JDK-8156579) to workaround jtreg issue CODETOOLS-7901761. CODETOOLS-7901761 has been fixed in 4.2/b05, workaround in tests should be reverted.

Re: RFR 8158855: Fix remaining module dependences in java/lang

I'm not an official reviewer but just a minor comment ... I noticed that "executeTestJava" changed to "executeProcess" in ProxyTest.java, ProxyClassAccessTest.java and ModuleAccessControlTest.java, are these changes expected in this patch? If yes, should test/java/lang/reflect/Module/access/Ac

JDK 9 RFR of JDK-8157663: Remove tools/jimage/JImageTest.java from ProblemList.txt

tools/jimage/JImageTest.java This test is in ProblemList.txt with related bugid JDK-8150975. JDK-8150975 has been closed since previously reported image recreate issue now is not an issue anymore because the support for jimage recreate has been removed in JDK-8154090, in which test also update

Re: RFR JDK-8151913: Fix module dependencies in java/net tests

On 4/28/16 12:50 PM, John Jiang wrote: Hi, Please review another webrev: http://cr.openjdk.java.net/~jjiang/8151913/webrev.02 The java.httpclient module declaration is removed from all of java/net/httpclient tests, even though some ones have to declare other modules. + * @modules jdk.httpser

Re: RFR 8154733, Fix module dependencies missed in java.rmi tests

On 4/27/16 1:00 AM, Alan Bateman wrote: On 26/04/2016 13:50, Felix Yang wrote: Hi Amy, thanks for pointing this out. Updated webrev: http://cr.openjdk.java.net/~xiaofeya/8154733/webrev.01/ This looks okay to me. -Alan Thank you Alan! Felix, I'll sponsor this change for you. Thanks,

Re: RFR 8154733, Fix module dependencies missed in java.rmi tests

er, please wait for reviewer's feedback. Thanks, Amy Felix On 2016/4/26 17:21, Amy Lu wrote: Hi, Felix With modules declares in TEST.propertiesshould avoid have to modify test file one by one... Maybe I missed things please correct me. Example: $ cat jdk/test/java/rmi/TEST.properties mod

Re: RFR 8154733, Fix module dependencies missed in java.rmi tests

Hi, Felix With modules declares in TEST.propertiesshould avoid have to modify test file one by one... Maybe I missed things please correct me. Example: $ cat jdk/test/java/rmi/TEST.properties modules = java.rmi Thanks, Amy On 4/26/16 4:53 PM, Felix Yang wrote: Hi all, please review the

Re: RFR 8153928, test/lib/share/classes/jdk/test/lib/Utils.java introduced dependency to java.base/jdk.internal.misc

On 4/11/16 3:01 PM, Alan Bateman wrote: On 11/04/2016 07:57, Felix Yang wrote: Hi Alan and Amy, thanks for figuring this out. Updated to suggested practice. New webrev: http://cr.openjdk.java.net/~xiaofeya/8153928/webrev.01/ This looks okay. -Alan Felix, I'll sponsor this for you. Th

Re: RFR 8153928, test/lib/share/classes/jdk/test/lib/Utils.java introduced dependency to java.base/jdk.internal.misc

On 4/11/16 11:47 AM, Felix Yang wrote: Hi there, please review the following bug fix. Bug: https://bugs.openjdk.java.net/browse/JDK-8153928 Webrev: http://cr.openjdk.java.net/~xiaofeya/8153928/webrev.00/ You might want to do some cleanup to avoid using two @modules tags? BTW. I'm not openj

[jake] RFR JDK-8132672: DGCDeadLock test needs to be updated to wok with update setAccessible

java/rmi/transport/dgcDeadLock/DGCDeadLock.java is a white-box test that needs to access internal objects by purpose. This patch is to add "-XaddExports" to the test. Please review. bug: https://bugs.openjdk.java.net/browse/JDK-8132672 webrev: http://cr.openjdk.java.net/~amlu/8132672/webrev.00