Hi,
Optimized buffer's capacity checks.
WEBREV: http://cr.openjdk.java.net/~dkononenko/8169715/webrev.02
>
> Could please someone review the fix for JDK-8169715.
>
> The problem occurs when jimage tool is attempting to read an empty or
> incomplete image. The current implementation
Hi,
Could please someone review the fix for JDK-8169715.
The problem occurs when jimage tool is attempting to read an empty or
incomplete image. The current implementation works with ByteBuffer and always
relies on that there's enough data to inspect the image. This results in IAE
inside
Hi,
>
> On 06/02/2017 10:27, Denis Kononenko wrote:
> > Hi,
> >
> > Could someone please review this very small fix.
> >
> > The class JImageTask
> (src/jdk.jlink/share/classes/jdk/tools/jimage/JImageTask.java) has
> references to an info message by &#
Hi,
Could someone please review this small fix.
Recently several failing test cases were delivered into jdk9-dev by my mistake
(https://bugs.openjdk.java.net/browse/JDK-8167240). I've just renamed these
test cases to temporarily avoid their execution. They should be renamed back
when approp
mitted a new CR:
> https://bugs.openjdk.java.net/browse/JDK-8167384.
>
> Thank you,
> Denis.
>
> > Hi,
> >
> > Looks OK. Is it 100% pass rate?
> >
> > —Andrey
> > > On 9 Nov 2016, at 20:36, Denis Kononenko
> > wrote:
> > >
> > >
Hi Andrey,
No, it isn't. I submitted a new CR:
https://bugs.openjdk.java.net/browse/JDK-8167384.
Thank you,
Denis.
> Hi,
>
> Looks OK. Is it 100% pass rate?
>
> —Andrey
> > On 9 Nov 2016, at 20:36, Denis Kononenko
> wrote:
> >
> >
> >
&
Looks OK to me.
> I can suggest two more cases. A directory and file symlink can be
> passed in options where tool requires a file path.
>
> —Andrey
>
> > On 8 Nov 2016, at 16:17, Denis Kononenko
> wrote:
> >
> >
> > Hi,
> >
> > T
ry. Then, of course, unneeded module
> dependencies are questionable.
>
> Shura
>
>
> > On Nov 3, 2016, at 6:29 AM, Denis Kononenko
> wrote:
> >
> > Hi,
> >
> > I've done some rework accordingly to Alan's and Shura's c
java.net/~dkononenko/8167240/webrev.01/
Thank you,
Denis.
On 06.10.2016 19:37, Denis Kononenko wrote:
Hi,
Could someone please review these new tests for jimage utility.
There're 5 new files containing tests to cover use cases for 'info',
'list', 'extract' and ot
> >
> Duplicate and overlapping tests are a pain when things are changing
> that
> require updates to the tests. So in this case then I think it would be
>
> very useful to go over the pre-existing tests to weed out some of the
>
> original tests that are obsoleted by the new tests.
Ok, I'll
> >
> > Could someone please review these new tests for jimage utility.
> >
> > There're 5 new files containing tests to cover use cases for 'info',
>
> > 'list', 'extract' and other options. No new tests for 'verify'.
> >
> > BUGURL: https://bugs.openjdk.java.net/browse/JDK-8167240
> > WEBREV: h
Hi,
Could someone please review these new tests for jimage utility.
There're 5 new files containing tests to cover use cases for 'info',
'list', 'extract' and other options. No new tests for 'verify'.
BUGURL: https://bugs.openjdk.java.net/browse/JDK-8167240
WEBREV: http://cr.openjdk.java.net/
12 matches
Mail list logo
