Looks good. Nice to see that code removed.
Hannes
Am 2016-06-06 um 11:38 schrieb Sundararajan Athijegannathan:
Please review: http://cr.openjdk.java.net/~sundar/8158736/webrev.00/ for
https://bugs.openjdk.java.net/browse/JDK-8158736
Nashorn creates named, dynamic modules for java adapter class
+1 for the incremental changes in the last iteration.
Hannes
Am 2016-05-31 um 09:17 schrieb Sundararajan Athijegannathan:
Sorry, I have updated nashorn webrev again:
http://cr.openjdk.java.net/~sundar/8158131/nashorn/webrev.02/
Incremental changes:
* Missed "nashornModule" name in JavaAdapte
Sorry for the slow review, I needed some explanation from Sundar about
the difficulties of dynamic module creation, cross-layer read edges etc.
With that knowledge +1 for this change.
Hannes
Am 2016-05-30 um 19:55 schrieb Alan Bateman:
On 30/05/2016 11:43, Sundararajan Athijegannathan wrote:
+1 for the Nashorn/Dynalink changes.
The top level changes look good to me but I'd prefer to leave reviews to
those who are more familiar with the build/modules infrastructure.
Hannes
Am 2015-11-20 um 00:15 schrieb Attila Szegedi:
Please review JDK-8141338 "Move jdk.internal.dynalink package
