Re: Review Request JDK-8136930 Examine implications for custom launchers, equivalent of java -X options in particular

Hi Mandy, Yes, I can make that change. Thanks for pointing it out. Harold On 6/8/2016 12:35 PM, Mandy Chung wrote: Updated webrev with Harold’s latest VM change incorporating the review comments: http://cr.openjdk.java.net/~mchung/jdk9/webrevs/8136930/webrev.01/index.html Harold - the rev

RFR(L) 8136930: Simplify use of module-system options by custom launchers

Hi, Please review these Hotspot VM only changes to process the seven module-specific options that have been renamed to have gnu-like names. JDK changes for this bug will be reviewed separately. Descriptions of these options are here . For these six options

Re: RFR(L) 8136930: Simplify use of module-system options by custom launchers

lan Bateman wrote: On 18/07/2016 00:05, harold seigel wrote: Hi, Please review these Hotspot VM only changes to process the seven module-specific options that have been renamed to have gnu-like names. JDK changes for this bug will be reviewed separately. Descriptions of these options are he

Re: RFR(L) 8136930: Simplify use of module-system options by custom launchers

. Daugherty wrote: On 7/17/16 5:05 PM, harold seigel wrote: Hi, Please review these Hotspot VM only changes to process the seven module-specific options that have been renamed to have gnu-like names. JDK changes for this bug will be reviewed separately. Descriptions of these options are here

hg: jigsaw/jake/jdk: 8159144: Remove JNI functions AddModuleReads/CanReadModule

Changeset: ba1572662972 Author:hseigel Date: 2016-07-21 13:46 -0400 URL: http://hg.openjdk.java.net/jigsaw/jake/jdk/rev/ba1572662972 8159144: Remove JNI functions AddModuleReads/CanReadModule Summary: Delete the functions from the docs and code and update tests that used them Revie

hg: jigsaw/jake/hotspot: 8159144: Remove JNI functions AddModuleReads/CanReadModule

Changeset: c34e09c3e5a5 Author:hseigel Date: 2016-07-21 13:49 -0400 URL: http://hg.openjdk.java.net/jigsaw/jake/hotspot/rev/c34e09c3e5a5 8159144: Remove JNI functions AddModuleReads/CanReadModule Summary: Delete the functions from the docs and code and update tests that used them R

Re: RFR(L) 8136930: Simplify use of module-system options by custom launchers

Hi Lois, Thanks for the review. Please see comments in-line. Harold On 8/1/2016 8:40 PM, Lois Foltan wrote: On 7/17/2016 7:05 PM, harold seigel wrote: Hi, Please review these Hotspot VM only changes to process the seven module-specific options that have been renamed to have gnu-like

Re: RFR(L) 8136930: Simplify use of module-system options by custom launchers

tests 4. Incorporates review comments from Alan, Coleen, Dan, and Lois 5. Fixes JTReg tests that failed due to the new option syntax. Revised webrev: http://cr.openjdk.java.net/~hseigel/bug_8136930.hs2/ Thanks, Harold On 8/2/2016 9:25 AM, harold seigel wrote: Hi Lois, Thanks for the review.

Re: RFR(L) 8136930: Simplify use of module-system options by custom launchers

Hi, Please review the latest version of this change. It is similar to the below change except it changes uses of -mp to -p. http://cr.openjdk.java.net/~hseigel/bug_8136930.hs3/ Thanks! Harold On 8/4/2016 8:46 AM, harold seigel wrote: Hi, Please review this update for this fix. This

hg: jigsaw/jake/hotspot: 8136930: Simplify use of module-system options by custom launchers

Changeset: 9be91950b6af Author:hseigel Date: 2016-08-10 12:50 -0400 URL: http://hg.openjdk.java.net/jigsaw/jake/hotspot/rev/9be91950b6af 8136930: Simplify use of module-system options by custom launchers Summary: Change to use gnu style options and ignore certain properties Reviewed

Re: Module name check is too restrictive

Hi Remi, Thanks for pointing this out. We have entered bug https://bugs.openjdk.java.net/browse/JDK-8164969 for this issue. Harold On 8/28/2016 3:31 PM, Remi Forax wrote: While testing ASM, i've found that you can not currently load a module that has a '+' in its name. /usr/jdk/jdk-9-jigs

hg: jigsaw/jake/hotspot: 8167487: Remove unused module related JVM API's

Changeset: 3b0fd4bfd0a4 Author:hseigel Date: 2016-10-13 13:03 -0400 URL: http://hg.openjdk.java.net/jigsaw/jake/hotspot/rev/3b0fd4bfd0a4 8167487: Remove unused module related JVM API's Summary: Remove JVM_CanReadModule() and JVM_IsExportedToModule()and the functions that only they

hg: jigsaw/jake: 8167487: Remove unused module related JVM API's

Changeset: 77577e358ec2 Author:hseigel Date: 2016-10-13 13:02 -0400 URL: http://hg.openjdk.java.net/jigsaw/jake/rev/77577e358ec2 8167487: Remove unused module related JVM API's Summary: Remove JVM_CanReadModule() and JVM_IsExportedToModule()and the functions that only they call. Re

hg: jigsaw/jake/jdk: 8167487: Remove unused module related JVM API's

Changeset: 488a5864fa1d Author:hseigel Date: 2016-10-13 13:02 -0400 URL: http://hg.openjdk.java.net/jigsaw/jake/jdk/rev/488a5864fa1d 8167487: Remove unused module related JVM API's Summary: Remove JVM_CanReadModule() and JVM_IsExportedToModule()and the functions that only they call

hg: jigsaw/jake/hotspot: 8168090: Many JTreg hotspot tests fail in Jake

Changeset: a18c27ca7812 Author:gtriantafill Date: 2016-10-19 15:33 -0400 URL: http://hg.openjdk.java.net/jigsaw/jake/hotspot/rev/a18c27ca7812 8168090: Many JTreg hotspot tests fail in Jake Summary: add needed @modules ...:private Reviewed-by: hseigel ! test/compiler/c2/Test7190310_

hg: jigsaw/jake/hotspot: 8168090: Many JTreg hotspot tests fail in Jake

Changeset: 6514277096ac Author:gtriantafill Date: 2016-10-19 17:29 -0400 URL: http://hg.openjdk.java.net/jigsaw/jake/hotspot/rev/6514277096ac 8168090: Many JTreg hotspot tests fail in Jake Summary: add needed @modules ...:private and other changes to get tests to pass Reviewed-by: h

hg: jigsaw/jake/hotspot: 8168090: Many JTreg hotspot tests fail in Jake

Changeset: d9798a94d37a Author:gtriantafill Date: 2016-10-20 10:12 -0400 URL: http://hg.openjdk.java.net/jigsaw/jake/hotspot/rev/d9798a94d37a 8168090: Many JTreg hotspot tests fail in Jake Summary: add needed @modules ...:private and --add-exports-private to get tests to pass Revie

hg: jigsaw/jake/hotspot: 8168090: Many JTreg hotspot tests fail in Jake

Changeset: 4b9423f5466c Author:hseigel Date: 2016-10-20 12:51 -0400 URL: http://hg.openjdk.java.net/jigsaw/jake/hotspot/rev/4b9423f5466c 8168090: Many JTreg hotspot tests fail in Jake Summary: add needed --add-exports-private options to get tests to pass Reviewed-by: gtriantafill !

hg: jigsaw/jake/hotspot: 2 new changesets

Changeset: cb0712bd2538 Author:gtriantafill Date: 2016-11-16 08:04 -0500 URL: http://hg.openjdk.java.net/jigsaw/jake/hotspot/rev/cb0712bd2538 8169328: Change hotspot tests to use new --add-opens options Summary: Replace --add-exports-private with --add-opens, replace :private in @m

hg: jigsaw/jake/hotspot: 8169328: Change hotspot tests to use new --add-opens options

Changeset: 60ab9a59cfb9 Author:hseigel Date: 2016-11-16 13:05 -0500 URL: http://hg.openjdk.java.net/jigsaw/jake/hotspot/rev/60ab9a59cfb9 8169328: Change hotspot tests to use new --add-opens options Summary: Restore previous change that removed --add-exports-private support Reviewed-

hg: jigsaw/jake/nashorn: 8169920: Fix Nashorn JTReg Jake test failures

Changeset: 51851824d373 Author:hseigel Date: 2016-11-17 16:12 -0500 URL: http://hg.openjdk.java.net/jigsaw/jake/nashorn/rev/51851824d373 8169920: Fix Nashorn JTReg Jake test failures Summary: add needed :open to @modules Reviewed-by: alanb ! test/src/jdk/nashorn/internal/runtime/do

hg: jigsaw/jake/hotspot: 8170397: hotspot gc/stress/gcbasher tests fail in Jake

Changeset: 756aeaa66545 Author:hseigel Date: 2016-11-28 09:30 -0500 URL: http://hg.openjdk.java.net/jigsaw/jake/hotspot/rev/756aeaa66545 8170397: hotspot gc/stress/gcbasher tests fail in Jake Summary: Don't parse "module-info.class" files Reviewed-by: alanb ! test/gc/stress/gcbashe

hg: jigsaw/jake/hotspot: 8170542: Quarantine serviceability/jdwp/AllModulesCommandTest.java test

Changeset: a96915b95040 Author:gtriantafill Date: 2016-11-30 15:17 -0500 URL: http://hg.openjdk.java.net/jigsaw/jake/hotspot/rev/a96915b95040 8170542: Quarantine serviceability/jdwp/AllModulesCommandTest.java test Summary: Add @ignore Reviewed-by: hseigel ! test/serviceability/jdwp

hg: jigsaw/jake/hotspot: 8171001: Remove existing JVM checks on module names because they are no longer valid

Changeset: 2ef3dabfa9e1 Author:hseigel Date: 2016-12-12 08:39 -0500 URL: http://hg.openjdk.java.net/jigsaw/jake/hotspot/rev/2ef3dabfa9e1 8171001: Remove existing JVM checks on module names because they are no longer valid Summary: Remove the checks on module names Reviewed-by: lfol

hg: jigsaw/jake/hotspot: 8171117: Fix test /runtime/modules/JVMDefineModule.java

Changeset: b15027fb1dc2 Author:hseigel Date: 2016-12-12 15:21 -0500 URL: http://hg.openjdk.java.net/jigsaw/jake/hotspot/rev/b15027fb1dc2 8171117: Fix test /runtime/modules/JVMDefineModule.java Summary: Fix the checks on module names Reviewed-by: lfoltan ! test/runtime/modules/JVMDe

hg: jigsaw/jake/hotspot: 8171106: Hotspot test serviceability/jvmti/GetModulesInfo/JvmtiGetAllModulesTest.java fails to compile

Changeset: e0bb4f0c5d84 Author:sspitsyn Date: 2016-12-13 09:54 -0500 URL: http://hg.openjdk.java.net/jigsaw/jake/hotspot/rev/e0bb4f0c5d84 8171106: Hotspot test serviceability/jvmti/GetModulesInfo/JvmtiGetAllModulesTest.java fails to compile Summary: Fix the test by extending the ab

Re: RFR: 8171855: Move package name transformations during module bootstrap into native code

Hi Claes, One small nit. In these lines in modules.cpp, the length of package_name at line 305 could be saved in a local and then strncpy() could be used at line 306. Also, the saved length could be used in line 310 instead of strlen(pkg_name). A similar change would also apply around line

Re: RFR: 8171855: Move package name transformations during module bootstrap into native code

a new set of tests. /Claes On 2017-01-06 14:23, harold seigel wrote: Hi Claes, One small nit. In these lines in modules.cpp, the length of package_name at line 305 could be saved in a local and then strncpy() could be used at line 306. Also, the saved length could be used in line 310 instead of s

hg: jigsaw/jake/hotspot: 8171115: Tests containing module names ending in digits need to change

Changeset: e3212cca805b Author:gtriantafill Date: 2017-01-27 10:18 -0500 URL: http://hg.openjdk.java.net/jigsaw/jake/hotspot/rev/e3212cca805b 8171115: Tests containing module names ending in digits need to change Reviewed-by: alanb, hseigel ! test/runtime/modules/AccessCheck/CheckR

hg: jigsaw/jake/hotspot: 8177827: Hotspot changes to move java.lang.reflect.{Module, Layer, ...} to java.lang

Changeset: 6f3a68d98adb Author:hseigel Date: 2017-03-30 09:16 -0400 URL: http://hg.openjdk.java.net/jigsaw/jake/hotspot/rev/6f3a68d98adb 8177827: Hotspot changes to move java.lang.reflect.{Module,Layer,...} to java.lang Summary: Make the needed changes to hotspot source and all hot

Re: CFV: New Committer: Christian Tornqvist

Vote: yes Harold On 9/16/2015 2:42 PM, Karen Kinnear wrote: I hereby nominate Christian Tornqvist to Jigsaw Committer. Christian is the hotspot runtime SQE lead and a Reviewer on the jdk9 project. Christian has contributed new tests and made extensive changes to the hotspot tests for jigsaw i

Re: CFV: New Jigsaw Committer: Lois Foltan

Vote: Yes Harold On 9/16/2015 2:43 PM, Karen Kinnear wrote: I hereby nominate Lois Foltan to Jigsaw Committer. Lois is a member of the hotspot runtime team and a committer on the jdk9 project. Lois has been contributing to Project Jigsaw for more than a year, including jvm support for module

hg: jigsaw/jake/hotspot: Fix up handling of -Xpatch/-Xoverride dirs when appending 'java.base'. Also, remove unneeded @modules for Xpatch tests.

Changeset: 02f1e0d0cc52 Author:hseigel Date: 2015-09-24 14:25 -0400 URL: http://hg.openjdk.java.net/jigsaw/jake/hotspot/rev/02f1e0d0cc52 Fix up handling of -Xpatch/-Xoverride dirs when appending 'java.base'. Also, remove unneeded @modules for Xpatch tests. ! src/share/vm/runtime/

hg: jigsaw/jake/hotspot: Remove old -Xoverride code

Changeset: 00ba345866f4 Author:hseigel Date: 2015-09-29 16:06 -0400 URL: http://hg.openjdk.java.net/jigsaw/jake/hotspot/rev/00ba345866f4 Remove old -Xoverride code ! src/share/vm/runtime/arguments.cpp

hg: jigsaw/jake/hotspot: Follow-up fix for 8134705

Changeset: f7f642ee9420 Author:ccheung Date: 2015-09-30 11:55 -0700 URL: http://hg.openjdk.java.net/jigsaw/jake/hotspot/rev/f7f642ee9420 Follow-up fix for 8134705 Comment: bring back the check for bootclasspath mismatch Reviewed-by: iklam, jiangli ! src/share/vm/classfile/sharedPat

hg: jigsaw/jake/hotspot: Replace ":" with File.patchSeparator

Changeset: a60073ae6bbe Author:hseigel Date: 2015-10-01 08:58 -0400 URL: http://hg.openjdk.java.net/jigsaw/jake/hotspot/rev/a60073ae6bbe Replace ":" with File.patchSeparator ! test/runtime/modules/Xpatch/Xpatch2Dirs.java

hg: jigsaw/jake/hotspot: ProtectionDomain support for shared module classes from bootmodules.jimage.

Changeset: c6d743401cc0 Author:jiangli Date: 2015-10-02 16:24 -0400 URL: http://hg.openjdk.java.net/jigsaw/jake/hotspot/rev/c6d743401cc0 ProtectionDomain support for shared module classes from bootmodules.jimage. ! src/share/vm/classfile/classLoader.cpp ! src/share/vm/classfile/cla

hg: jigsaw/jake/hotspot: Fix app class dump failure with -Xbootclasspath/a.

Changeset: 3c022633643d Author:jiangli Date: 2015-10-13 16:39 -0400 URL: http://hg.openjdk.java.net/jigsaw/jake/hotspot/rev/3c022633643d Fix app class dump failure with -Xbootclasspath/a. ! src/share/vm/classfile/classLoader.cpp ! src/share/vm/classfile/classLoader.hpp

hg: jigsaw/jake/hotspot: Fix for 8081403. Problem caused by JVM not properly handling module jdk.proxy1's version string of length zero.

Changeset: 9d03e40fb80d Author:hseigel Date: 2015-10-19 14:22 -0400 URL: http://hg.openjdk.java.net/jigsaw/jake/hotspot/rev/9d03e40fb80d Fix for 8081403. Problem caused by JVM not properly handling module jdk.proxy1's version string of length zero. ! src/share/vm/classfile/module

hg: jigsaw/jake/hotspot: Allow modules to have versions of "".

Changeset: d3eb015445d3 Author:hseigel Date: 2015-10-20 17:04 -0400 URL: http://hg.openjdk.java.net/jigsaw/jake/hotspot/rev/d3eb015445d3 Allow modules to have versions of "". ! src/share/vm/classfile/modules.cpp

hg: jigsaw/jake/hotspot: Add support for NULL module versions.

Changeset: 662926b165dc Author:hseigel Date: 2015-10-23 12:24 -0400 URL: http://hg.openjdk.java.net/jigsaw/jake/hotspot/rev/662926b165dc Add support for NULL module versions. ! src/share/vm/classfile/javaClasses.cpp ! src/share/vm/classfile/modules.cpp

hg: jigsaw/jake/jdk: Change default module version from "" to null.

Changeset: 7919272336c9 Author:hseigel Date: 2015-10-23 12:27 -0400 URL: http://hg.openjdk.java.net/jigsaw/jake/jdk/rev/7919272336c9 Change default module version from "" to null. ! src/java.base/share/classes/java/lang/reflect/Module.java

hg: jigsaw/jake/hotspot: Fix Observability tests

Changeset: 7e972ba1fe32 Author:gtriantafill Date: 2015-11-03 11:14 -0500 URL: http://hg.openjdk.java.net/jigsaw/jake/hotspot/rev/7e972ba1fe32 Fix Observability tests Reviewed-by: lfoltan, hseigel + test/runtime/modules/Visibility/XbootcpNoVisibility.java - test/runtime/modules/obse

hg: jigsaw/jake/hotspot: Make ModuleEntry hashtable lookup more efficient.

Changeset: e2f40992e003 Author:hseigel Date: 2015-11-05 16:58 -0500 URL: http://hg.openjdk.java.net/jigsaw/jake/hotspot/rev/e2f40992e003 Make ModuleEntry hashtable lookup more efficient. ! src/share/vm/classfile/moduleEntry.cpp

hg: jigsaw/jake/hotspot: 8139095: AppCDS will load application archive classes that conflict with modules in the jimage

Changeset: 87a0cdda6d9e Author:jiangli Date: 2015-11-06 19:47 -0500 URL: http://hg.openjdk.java.net/jigsaw/jake/hotspot/rev/87a0cdda6d9e 8139095: AppCDS will load application archive classes that conflict with modules in the jimage Summary: More fine-grained shared class runtime vi

Re: RFR 9: 8141571 : jdk/internal/jimage/JImageReadTest.java crashing in msvcr120.dll

Hi Roger, The changes look good. Eventually, will the out-of-memory asserts be replaced with an error in order to handle OOM's that occur in production code? Thanks, Harold On 11/12/2015 10:20 AM, Roger Riggs wrote: Please review additions to jimageFile to diagnose an intermittent failure.

hg: jigsaw/jake/hotspot: Set property sun.boot.class.path to NULL, and include Jiangli's build fix and other build fix.

Changeset: d83120ae736e Author:hseigel Date: 2015-11-16 15:35 -0500 URL: http://hg.openjdk.java.net/jigsaw/jake/hotspot/rev/d83120ae736e Set property sun.boot.class.path to NULL, and include Jiangli's build fix and other build fix. ! src/share/vm/classfile/systemDictionaryShared.h

hg: jigsaw/jake/hotspot: Add call to forName() so a class in package sun/invoke/util/ is referenced before requesting its location.

Changeset: 3f1ab53fc90d Author:hseigel Date: 2015-11-18 09:38 -0500 URL: http://hg.openjdk.java.net/jigsaw/jake/hotspot/rev/3f1ab53fc90d Add call to forName() so a class in package sun/invoke/util/ is referenced before requesting its location. ! test/runtime/getSysPackage/GetSysPk

hg: jigsaw/jake/hotspot: Fix issue with two modules having the same package by adding -Xmodule: option for javac.

Changeset: 465142d1190a Author:jlahoda Date: 2015-11-30 10:41 -0500 URL: http://hg.openjdk.java.net/jigsaw/jake/hotspot/rev/465142d1190a Fix issue with two modules having the same package by adding -Xmodule: option for javac. ! test/runtime/modules/Xpatch/Xpatch2Dirs.java ! test/r

hg: jigsaw/jake/hotspot: Improve module related IAE error messages, add unnamed module identity hash to messages.

Changeset: ec9ad3190695 Author:hseigel Date: 2015-12-02 10:23 -0500 URL: http://hg.openjdk.java.net/jigsaw/jake/hotspot/rev/ec9ad3190695 Improve module related IAE error messages, add unnamed module identity hash to messages. ! src/share/vm/classfile/modules.cpp ! src/share/vm/run

Re: CFV: New Jigsaw Committer: Jan Lahoda

Vote: yes Harold On 12/2/2015 2:43 PM, Jonathan Gibbons wrote: |I hereby nominate Jan Lahoda to Jigsaw Committer. Jan is already a Reviewer for the JDK 9 project, and has made the following contributions to the jigsaw/jake forest: | http://hg.openjdk.java.net/jigsaw/jake/langtools/rev/ad256

hg: jigsaw/jake/hotspot: Remove PackageInfo table, instead, use PackageEntry table for getSystemPackage(s)

Changeset: 868ecee09500 Author:hseigel Date: 2015-12-09 07:55 -0500 URL: http://hg.openjdk.java.net/jigsaw/jake/hotspot/rev/868ecee09500 Remove PackageInfo table, instead, use PackageEntry table for getSystemPackage(s) ! src/share/vm/classfile/classLoader.cpp ! src/share/vm/classf

hg: jigsaw/jake/jdk: Remove PackageInfo table, instead, use PackageEntry table for getSystemPackage(s)

Changeset: c1d583efa466 Author:hseigel Date: 2015-12-09 07:56 -0500 URL: http://hg.openjdk.java.net/jigsaw/jake/jdk/rev/c1d583efa466 Remove PackageInfo table, instead, use PackageEntry table for getSystemPackage(s) ! src/java.base/share/classes/jdk/internal/misc/BootLoader.java

Re: preliminary RFR: 8049365 - Update JDI and JDWP for modules

Hi Serguei, Looks good. Just a few comments. 1. Should jni_GetAllModules() contain the DTrace macros that other JNI entries have? 2. Can you add a similar GetAllModules() function to jniCheck.cpp ? Thanks, Harold On 12/10/2015 7:04 AM, Alan Bateman wrote: On 10/12/2015 08:03, serguei.spi

hg: jigsaw/jake/hotspot: Support AppCDS with -Xbootclasspath/a

Changeset: 16427b29fdb7 Author:jiangli Date: 2015-12-15 15:24 -0500 URL: http://hg.openjdk.java.net/jigsaw/jake/hotspot/rev/16427b29fdb7 Support AppCDS with -Xbootclasspath/a ! src/share/vm/classfile/classLoader.cpp ! src/share/vm/classfile/classLoader.hpp ! src/share/vm/classfile/

hg: jigsaw/jake/hotspot: Fixed test/runtime/SharedArchiveFile/LimitSharedSizes.java - missing @module jdk.attach/sun.tools.attach

Changeset: 16c6e9f6a869 Author:iklam Date: 2015-12-15 15:45 -0800 URL: http://hg.openjdk.java.net/jigsaw/jake/hotspot/rev/16c6e9f6a869 Fixed test/runtime/SharedArchiveFile/LimitSharedSizes.java - missing @module jdk.attach/sun.tools.attach ! test/runtime/SharedArchiveFile/LimitSha

hg: jigsaw/jake/hotspot: Uniform refcounting for Symbols associated with a ModuleEntry

Changeset: bfa5e6b04b81 Author:mgronlun Date: 2016-01-07 22:40 +0100 URL: http://hg.openjdk.java.net/jigsaw/jake/hotspot/rev/bfa5e6b04b81 Uniform refcounting for Symbols associated with a ModuleEntry ! src/share/vm/classfile/moduleEntry.cpp ! src/share/vm/classfile/moduleEntry.hpp

hg: jigsaw/jake/hotspot: 89 new changesets

Changeset: 13f324f322b4 Author:hshi Date: 2015-11-26 15:37 + URL: http://hg.openjdk.java.net/jigsaw/jake/hotspot/rev/13f324f322b4 8143584: Load constant pool tag and class status with load acquire Reviewed-by: roland, aph ! src/cpu/aarch64/vm/templateTable_aarch64.cpp Changese

hg: jigsaw/jake/hotspot: Reenable test because it now passes because of app class loader change described in 8072481.

Changeset: a9ae43ce3241 Author:hseigel Date: 2016-01-21 11:16 -0500 URL: http://hg.openjdk.java.net/jigsaw/jake/hotspot/rev/a9ae43ce3241 Reenable test because it now passes because of app class loader change described in 8072481. ! test/runtime/StackGuardPages/testme.sh

hg: jigsaw/jake/hotspot: Fix -XX:+TraceClassPaths output for Boot loader class path/

Changeset: ea7b1ad5d733 Author:hseigel Date: 2016-01-22 15:27 -0500 URL: http://hg.openjdk.java.net/jigsaw/jake/hotspot/rev/ea7b1ad5d733 Fix -XX:+TraceClassPaths output for Boot loader class path/ ! src/share/vm/classfile/classLoader.cpp

hg: jigsaw/jake/hotspot: Remove /../../ from @library

Changeset: 6ad504333110 Author:hseigel Date: 2016-01-22 16:23 -0500 URL: http://hg.openjdk.java.net/jigsaw/jake/hotspot/rev/6ad504333110 Remove /../../ from @library ! test/runtime/modules/AccessCheck/ExportAllUnnamed.java ! test/runtime/modules/AccessCheck/NmodNpkgDiffCL_CheckRead

hg: jigsaw/jake/hotspot: Store classpath_index value so that the classpath entry can be found for classes loaded by the boot loader from -Xbootclasspath/a in unnamed module

Changeset: 3f7f51b3d2f4 Author:hseigel Date: 2016-01-27 07:50 -0500 URL: http://hg.openjdk.java.net/jigsaw/jake/hotspot/rev/3f7f51b3d2f4 Store classpath_index value so that the classpath entry can be found for classes loaded by the boot loader from -Xbootclasspath/a in unnamed modu

hg: jigsaw/jake/jdk: Fix GetSystemPackage() problem with packages in unnamed modules loaded by the boot loader from -Xbootclasspath/a

Changeset: dbec732adeee Author:mchung Date: 2016-01-27 08:15 -0500 URL: http://hg.openjdk.java.net/jigsaw/jake/jdk/rev/dbec732adeee Fix GetSystemPackage() problem with packages in unnamed modules loaded by the boot loader from -Xbootclasspath/a ! src/java.base/share/classes/jdk/in

hg: jigsaw/jake/hotspot: Add test cases for CDS -Xbootclasspath/a support.

Changeset: 13ab99258d5c Author:jiangli Date: 2016-01-28 14:47 -0500 URL: http://hg.openjdk.java.net/jigsaw/jake/hotspot/rev/13ab99258d5c Add test cases for CDS -Xbootclasspath/a support. ! test/runtime/SharedArchiveFile/BasicJarBuilder.java + test/runtime/SharedArchiveFile/BootAppe

hg: jigsaw/jake/hotspot: Minor cleanup including fix for 8140607

Changeset: 61344cafbc2c Author:hseigel Date: 2016-01-28 16:07 -0500 URL: http://hg.openjdk.java.net/jigsaw/jake/hotspot/rev/61344cafbc2c Minor cleanup including fix for 8140607 ! src/share/vm/classfile/jimage.hpp

Re: CFV: New Jigsaw Committer: Igor Ignatyev

Vote: yes Harold On 2/3/2016 3:03 PM, Christian Tornqvist wrote: I hereby nominate Igor Ignatyev to Jigsaw Committer. Igor is already a Reviewer for the JDK 9 project, and has made the following contributions to the jigsaw/jake forest: http://hg.openjdk.java.net/jigsaw/jake/hotspot/

hg: jigsaw/jake/hotspot: Changes from code review comments.

Changeset: 86ba68caae6c Author:hseigel Date: 2016-02-09 15:46 -0500 URL: http://hg.openjdk.java.net/jigsaw/jake/hotspot/rev/86ba68caae6c Changes from code review comments. ! src/share/vm/classfile/classLoader.cpp ! src/share/vm/classfile/classLoader.hpp ! src/share/vm/classfile/mod

hg: jigsaw/jake/hotspot: Call add_package() for classes loaded from the CDS archive so that GetSysPkg() can find them.

Changeset: 6908003e49f2 Author:hseigel Date: 2016-02-11 14:56 -0500 URL: http://hg.openjdk.java.net/jigsaw/jake/hotspot/rev/6908003e49f2 Call add_package() for classes loaded from the CDS archive so that GetSysPkg() can find them. ! src/share/vm/classfile/classLoader.hpp ! src/sha

hg: jigsaw/jake/hotspot: Fix for 8134950 jvmti HookTest segv

Changeset: 93e7eea3ca0f Author:sspitsyn Date: 2016-02-18 08:36 -0500 URL: http://hg.openjdk.java.net/jigsaw/jake/hotspot/rev/93e7eea3ca0f Fix for 8134950 jvmti HookTest segv ! src/share/vm/classfile/classFileParser.cpp ! src/share/vm/classfile/moduleEntry.hpp ! src/share/vm/prims/j

hg: jigsaw/jake/hotspot: 8150114: SystemDictionary::load_shared_class() uses '0' as the class path index when adding system package

Changeset: 8c4603cf805f Author:jiangli Date: 2016-02-17 21:08 -0500 URL: http://hg.openjdk.java.net/jigsaw/jake/hotspot/rev/8c4603cf805f 8150114: SystemDictionary::load_shared_class() uses '0' as the class path index when adding system package Summary: Need to use the classpath ind

hg: jigsaw/jake/hotspot: Add JNI_AddModuleReads() and JNICanReadModule() entry points

Changeset: 9e6121540f5a Author:hseigel Date: 2016-02-22 11:31 -0500 URL: http://hg.openjdk.java.net/jigsaw/jake/hotspot/rev/9e6121540f5a Add JNI_AddModuleReads() and JNICanReadModule() entry points ! src/share/vm/classfile/vmSymbols.hpp ! src/share/vm/prims/jni.cpp ! src/share/vm/p

hg: jigsaw/jake/jdk: Add JNI_AddModuleReads() and JNICanReadModule() entry points

Changeset: 85dcecc06a9c Author:hseigel Date: 2016-02-22 11:33 -0500 URL: http://hg.openjdk.java.net/jigsaw/jake/jdk/rev/85dcecc06a9c Add JNI_AddModuleReads() and JNICanReadModule() entry points ! src/java.base/share/native/include/jni.h

hg: jigsaw/jake/hotspot: Add JVM_GetModuleByPackageName() API

Changeset: ae94709b181e Author:hseigel Date: 2016-02-24 11:15 -0500 URL: http://hg.openjdk.java.net/jigsaw/jake/hotspot/rev/ae94709b181e Add JVM_GetModuleByPackageName() API ! make/share/makefiles/mapfile-vers ! src/share/vm/classfile/modules.cpp ! src/share/vm/classfile/modules.hp

hg: jigsaw/jake: Add new JVM_GetModuleByPackageName() API

Changeset: 8aac12b3b181 Author:hseigel Date: 2016-02-24 11:21 -0500 URL: http://hg.openjdk.java.net/jigsaw/jake/rev/8aac12b3b181 Add new JVM_GetModuleByPackageName() API ! test/lib/sun/hotspot/WhiteBox.java

hg: jigsaw/jake/jdk: Ann JVM_GetModuleByPackageName() API

Changeset: 5dcb0955ed4d Author:hseigel Date: 2016-02-24 11:29 -0500 URL: http://hg.openjdk.java.net/jigsaw/jake/jdk/rev/5dcb0955ed4d Ann JVM_GetModuleByPackageName() API ! src/java.base/share/native/include/jvm.h

hg: jigsaw/jake/hotspot: Change test because class BootLoader was moved to package jdk.internal.loader

Changeset: 870fb65a6dd1 Author:hseigel Date: 2016-03-03 11:43 -0500 URL: http://hg.openjdk.java.net/jigsaw/jake/hotspot/rev/870fb65a6dd1 Change test because class BootLoader was moved to package jdk.internal.loader ! test/runtime/getSysPackage/GetSysPkgTest.java

hg: jigsaw/jake/hotspot: Fix use of unified loggin that was commented out in the merge (JDK-8150999)

Changeset: b8822efbe831 Author:hseigel Date: 2016-03-04 07:50 -0500 URL: http://hg.openjdk.java.net/jigsaw/jake/hotspot/rev/b8822efbe831 Fix use of unified loggin that was commented out in the merge (JDK-8150999) ! src/share/vm/classfile/classFileParser.cpp ! src/share/vm/classfile

hg: jigsaw/jake/hotspot: Remove unused _module_offset

Changeset: fc6d7220f074 Author:hseigel Date: 2016-03-08 12:52 -0500 URL: http://hg.openjdk.java.net/jigsaw/jake/hotspot/rev/fc6d7220f074 Remove unused _module_offset ! src/share/vm/runtime/vmStructs.cpp

hg: jigsaw/jake/hotspot: Add #include from JDK-9 to fix open build

Changeset: 1ae14b475915 Author:hseigel Date: 2016-03-08 15:34 -0500 URL: http://hg.openjdk.java.net/jigsaw/jake/hotspot/rev/1ae14b475915 Add #include from JDK-9 to fix open build ! src/share/vm/trace/traceTypes.xsl

hg: jigsaw/jake/hotspot: Added missing ResourceMark in MetaspaceShared::check_shared_class_loader_type.

Changeset: 1e4ed69f0803 Author:ccheung Date: 2016-03-09 11:00 -0800 URL: http://hg.openjdk.java.net/jigsaw/jake/hotspot/rev/1e4ed69f0803 Added missing ResourceMark in MetaspaceShared::check_shared_class_loader_type. Reviewed-by: coleenp ! src/share/vm/memory/metaspaceShared.cpp

hg: jigsaw/jake/jdk: Check for package names of "" to prevent anonymous class names that start with '/'.

Changeset: d7102ae141b1 Author:hseigel Date: 2016-03-09 15:55 -0500 URL: http://hg.openjdk.java.net/jigsaw/jake/jdk/rev/d7102ae141b1 Check for package names of "" to prevent anonymous class names that start with '/'. Reviewed by: alanb, shade ! src/java.base/share/classes/java/lan

hg: jigsaw/jake/jdk: Use String.isEmpty() instead of checking for "".

Changeset: 0a46b03f327c Author:hseigel Date: 2016-03-10 08:19 -0500 URL: http://hg.openjdk.java.net/jigsaw/jake/jdk/rev/0a46b03f327c Use String.isEmpty() instead of checking for "". ! src/java.base/share/classes/java/lang/invoke/StringConcatFactory.java

hg: jigsaw/jake/hotspot: Remove JNIEnv arg from JVM internal methods

Changeset: 16505d7780b0 Author:hseigel Date: 2016-03-11 11:33 -0500 URL: http://hg.openjdk.java.net/jigsaw/jake/hotspot/rev/16505d7780b0 Remove JNIEnv arg from JVM internal methods ! src/share/vm/classfile/modules.cpp ! src/share/vm/classfile/modules.hpp ! src/share/vm/prims/jni.cp

hg: jigsaw/jake/hotspot: Fix JDK-8151532 JVM Phase issue

Changeset: f6165d13ad82 Author:sspitsyn Date: 2016-03-14 11:08 -0400 URL: http://hg.openjdk.java.net/jigsaw/jake/hotspot/rev/f6165d13ad82 Fix JDK-8151532 JVM Phase issue ! src/share/vm/prims/jvmtiExport.cpp

hg: jigsaw/jake/hotspot: Update JNI AddModuleReads() and CanReadModule() to disallow NULL (JDK-8151816) and fix test failures (JDK-8151817)

Changeset: 07df4997bf44 Author:hseigel Date: 2016-03-15 08:41 -0400 URL: http://hg.openjdk.java.net/jigsaw/jake/hotspot/rev/07df4997bf44 Update JNI AddModuleReads() and CanReadModule() to disallow NULL (JDK-8151816) and fix test failures (JDK-8151817) ! src/share/vm/prims/jni.cpp

hg: jigsaw/jake/jdk: Rename args to match names in JVM. Part of fix for JDK-8151816.

Changeset: 1e6e0c32f51e Author:hseigel Date: 2016-03-15 08:45 -0400 URL: http://hg.openjdk.java.net/jigsaw/jake/jdk/rev/1e6e0c32f51e Rename args to match names in JVM. Part of fix for JDK-8151816. ! src/java.base/share/native/include/jni.h

hg: jigsaw/jake/hotspot: Partial fix for open build issue.

Changeset: 13a7333a92ab Author:hseigel Date: 2016-03-15 10:03 -0400 URL: http://hg.openjdk.java.net/jigsaw/jake/hotspot/rev/13a7333a92ab Partial fix for open build issue. ! src/share/vm/trace/traceTypes.xsl

hg: jigsaw/jake/hotspot: Fix open build problem.

Changeset: 23944543f258 Author:hseigel Date: 2016-03-15 11:37 -0400 URL: http://hg.openjdk.java.net/jigsaw/jake/hotspot/rev/23944543f258 Fix open build problem. ! src/share/vm/trace/traceBackend.cpp

hg: jigsaw/jake/hotspot: Remove DTRACE from JNI_GetModule().

Changeset: 80cf85f54a3c Author:hseigel Date: 2016-03-15 13:03 -0400 URL: http://hg.openjdk.java.net/jigsaw/jake/hotspot/rev/80cf85f54a3c Remove DTRACE from JNI_GetModule(). ! src/share/vm/prims/jni.cpp

hg: jigsaw/jake/hotspot: Fix failing jvmci/compilerToVM tests.

Changeset: 474012546f4d Author:hseigel Date: 2016-03-15 15:15 -0400 URL: http://hg.openjdk.java.net/jigsaw/jake/hotspot/rev/474012546f4d Fix failing jvmci/compilerToVM tests. ! test/compiler/jvmci/compilerToVM/LookupKlassInPoolTest.java ! test/compiler/jvmci/compilerToVM/LookupKlas

hg: jigsaw/jake/hotspot: Fix slowdebug build issues

Changeset: 25a32e104032 Author:iklam Date: 2016-03-16 07:41 -0400 URL: http://hg.openjdk.java.net/jigsaw/jake/hotspot/rev/25a32e104032 Fix slowdebug build issues ! src/share/vm/prims/jvm.cpp ! src/share/vm/prims/whitebox.cpp

hg: jigsaw/jake/hotspot: Fix JVMTI Jake test failures

Changeset: ed6046fc103f Author:sspitsyn Date: 2016-03-16 16:41 -0400 URL: http://hg.openjdk.java.net/jigsaw/jake/hotspot/rev/ed6046fc103f Fix JVMTI Jake test failures ! src/share/vm/prims/jvmtiEnvBase.hpp ! src/share/vm/prims/jvmtiEventController.cpp

hg: jigsaw/jake/hotspot: Look for class jdk.nio.zipfs.ZipPath" because class "javax.activation.DataHandler" is no longer observable.

Changeset: 46491264f585 Author:hseigel Date: 2016-04-08 15:37 -0400 URL: http://hg.openjdk.java.net/jigsaw/jake/hotspot/rev/46491264f585 Look for class jdk.nio.zipfs.ZipPath" because class "javax.activation.DataHandler" is no longer observable. ! test/runtime/getSysPackage/GetSysP

hg: jigsaw/jake/hotspot: Don't assert when -Xpatch contains a jar file by fixing DumpSharedSpaces check

Changeset: 0d66108dfc2a Author:hseigel Date: 2016-04-28 18:31 -0400 URL: http://hg.openjdk.java.net/jigsaw/jake/hotspot/rev/0d66108dfc2a Don't assert when -Xpatch contains a jar file by fixing DumpSharedSpaces check ! src/share/vm/classfile/classLoader.cpp

hg: jigsaw/jake/hotspot: Fix compiler test failures by adding /othervm and fix expected output for test XpatchTraceCL.java

Changeset: a83304df7b56 Author:hseigel Date: 2016-04-29 10:56 -0400 URL: http://hg.openjdk.java.net/jigsaw/jake/hotspot/rev/a83304df7b56 Fix compiler test failures by adding /othervm and fix expected output for test XpatchTraceCL.java ! test/compiler/intrinsics/bmi/verifycode/Andn

Re: 8178380: Module system implementation refresh (5/2017 update)

Hi Alan, The hotspot changes look good. Thanks, Harold On 5/1/2017 4:28 PM, Alan Bateman wrote: As I mentioned in another thread, we need to get the changes accumulated in jake to jdk9/dev. JDK-8178380 [1] has the summary of the changes that have accumulated since the last refresh. One n