Re: RFR: JDK-8220702: compiling in the context of an automatic module disallows --add-modules ALL-MODULE-PATH

2019-05-13 Thread Jan Lahoda
5:34 AM, Jan Lahoda wrote: I've started with the CSR here: https://bugs.openjdk.java.net/browse/JDK-8222396 Looks pretty good. I made some edits to record both of your single-module and multi-module invocations of javac. The use case of injecting test code is clear, but the exact conne

Re: RFR: JDK-8220702: compiling in the context of an automatic module disallows --add-modules ALL-MODULE-PATH

2019-04-12 Thread Jan Lahoda
On 11. 04. 19 20:28, Alex Buckley wrote: On 4/11/2019 1:19 AM, Jan Lahoda wrote: Yes, I think JEP 261 may need updates. I'd say this is somewhat unforeseen interaction between automatic modules and --patch-module. When patching a (named) module (or a set of named modules), that modul

Re: RFR: JDK-8220702: compiling in the context of an automatic module disallows --add-modules ALL-MODULE-PATH

2019-04-11 Thread Jan Lahoda
On 11. 04. 19 0:19, Jonathan Gibbons wrote: On 4/10/19 3:07 PM, Alex Buckley wrote: On 4/10/2019 2:51 PM, Jonathan Gibbons wrote: On 4/10/19 11:51 AM, Alex Buckley wrote: There is a question to be answered: When the compiler compiles code in an automatic module (due to the code being observed

Re: 8197532: Re-examine policy for the default set of modules when compiling or running code on the class path

2018-06-20 Thread Jan Lahoda
Hi, javac changes look good to me. Jan On 19.6.2018 10:31, Alan Bateman wrote: JEP 261 details how the default set of root modules is computed when compiling code in the unnamed module or when running code and the main class is loaded from the class path. I'd like to re-visit this policy for

Re: JDK-8191112: javac OutOfMemoryError caused by "-Xlint:exports" option

2017-11-14 Thread Jan Lahoda
Hi Alex, On 14.11.2017 20:03, Alex Buckley wrote: On 11/14/2017 5:17 AM, Jan Lahoda wrote: --- module mod { requires transitive ext1; exports api; } --- "dep.Dep" is accessible using requires transitive edges of the automatic modules, hence the warning/lint is not printed. That doe

JDK-8191112: javac OutOfMemoryError caused by "-Xlint:exports" option

2017-11-14 Thread Jan Lahoda
Hi, Consider an automatic module "dep" with class "dep.Dep", and additional automatic modules ext1 and ext2. When javac has these on the modulepath, and compiles a module like this: --- module mod { requires dep; exports api; } package api; public class Api extends dep.Dep {} --- -X

hg: jigsaw/jake/langtools: 8181925: Confusing error when unnamed module reads multiple modules exporting the same package.

2017-06-12 Thread jan . lahoda
Changeset: 31edb164e288 Author:jlahoda Date: 2017-06-12 22:30 +0200 URL: http://hg.openjdk.java.net/jigsaw/jake/langtools/rev/31edb164e288 8181925: Confusing error when unnamed module reads multiple modules exporting the same package. Summary: Adding special wording for package cla

hg: jigsaw/jake/langtools: Adding tests for Automatic-Module-Name, checking the name validity.

2017-06-02 Thread jan . lahoda
Changeset: 09276c87a4be Author:jlahoda Date: 2017-06-02 17:02 +0200 URL: http://hg.openjdk.java.net/jigsaw/jake/langtools/rev/09276c87a4be Adding tests for Automatic-Module-Name, checking the name validity. ! src/jdk.compiler/share/classes/com/sun/tools/javac/file/Locations.java !

hg: jigsaw/jake/langtools: 2 new changesets

2017-04-04 Thread jan . lahoda
Changeset: b9942e7d5689 Author:jlahoda Date: 2017-04-04 15:08 +0200 URL: http://hg.openjdk.java.net/jigsaw/jake/langtools/rev/b9942e7d5689 Resolving one automatic module should resolve all automatic modules. ! src/jdk.compiler/share/classes/com/sun/tools/javac/comp/Modules.java ! t

Re: ALL-UNNAMED module does not export all packages from classpath

2017-03-21 Thread Jan Lahoda
Libor, Pavel, Thanks for the report! I've filled: https://bugs.openjdk.java.net/browse/JDK-8177311 And sent a request for review: http://mail.openjdk.java.net/pipermail/compiler-dev/2017-March/010873.html Thanks! Jan On 20.3.2017 23:44, Pavel Bucek wrote: Hi Jon, thanks. The credit goes to

hg: jigsaw/jake/langtools: Missing target modules of qualified exports should produce a warning rather than an error.

2016-12-14 Thread jan . lahoda
Changeset: 5c6049f251e7 Author:jlahoda Date: 2016-12-14 12:51 +0100 URL: http://hg.openjdk.java.net/jigsaw/jake/langtools/rev/5c6049f251e7 Missing target modules of qualified exports should produce a warning rather than an error. ! src/jdk.compiler/share/classes/com/sun/tools/java

hg: jigsaw/jake/langtools: 8160181: Add lint warning for digits in module names

2016-12-13 Thread jan . lahoda
Changeset: 44aa64ee7393 Author:sadayapalam Date: 2016-12-13 15:23 +0100 URL: http://hg.openjdk.java.net/jigsaw/jake/langtools/rev/44aa64ee7393 8160181: Add lint warning for digits in module names ! src/jdk.compiler/share/classes/com/sun/tools/javac/code/Lint.java ! src/jdk.compiler

hg: jigsaw/jake/jdk: 8160181: Add lint warning for digits in module names

2016-12-13 Thread jan . lahoda
Changeset: ad27fe64f0ea Author:sadayapalam Date: 2016-12-13 15:23 +0100 URL: http://hg.openjdk.java.net/jigsaw/jake/jdk/rev/ad27fe64f0ea 8160181: Add lint warning for digits in module names ! src/java.compact1/share/classes/module-info.java ! src/java.compact2/share/classes/module-

hg: jigsaw/jake/langtools: Reject module-info classfiles for open modules that have non-zero number of opens directives.

2016-11-28 Thread jan . lahoda
Changeset: 425abd8ac1eb Author:jlahoda Date: 2016-11-28 21:08 +0100 URL: http://hg.openjdk.java.net/jigsaw/jake/langtools/rev/425abd8ac1eb Reject module-info classfiles for open modules that have non-zero number of opens directives. ! src/jdk.compiler/share/classes/com/sun/tools/j

Re: Code review for jigsaw/jake -> jdk9/dev sync up

2016-11-28 Thread Jan Lahoda
Thanks for the comments Maurizio. On 28.11.2016 12:28, Maurizio Cimadamore wrote: Hi, the langtools code looks generally ok. Few questions: * Why doesn't 'open' get its own directive in Directive.java - instead of relying on a 'mode' set on an export directive? It seemed to me that having two

hg: jigsaw/jake/langtools: Removing 'dynamic' name, which is not needed anymore

2016-11-28 Thread jan . lahoda
Changeset: 8156e205fcb4 Author:jlahoda Date: 2016-11-28 13:02 +0100 URL: http://hg.openjdk.java.net/jigsaw/jake/langtools/rev/8156e205fcb4 Removing 'dynamic' name, which is not needed anymore ! src/jdk.compiler/share/classes/com/sun/tools/javac/util/Names.java

hg: jigsaw/jake/langtools: Adjusting attribute name.

2016-11-23 Thread jan . lahoda
Changeset: 12008d1dd118 Author:jlahoda Date: 2016-11-23 16:45 +0100 URL: http://hg.openjdk.java.net/jigsaw/jake/langtools/rev/12008d1dd118 Adjusting attribute name. ! src/jdk.compiler/share/classes/com/sun/tools/javac/jvm/ClassReader.java ! src/jdk.compiler/share/classes/com/sun/to

hg: jigsaw/jake/langtools: --add-exports-private changed to --add-opens.

2016-11-22 Thread jan . lahoda
Changeset: 117386f5ab3e Author:jlahoda Date: 2016-11-22 15:35 +0100 URL: http://hg.openjdk.java.net/jigsaw/jake/langtools/rev/117386f5ab3e --add-exports-private changed to --add-opens. ! test/tools/javac/platform/PlatformProviderTest.java

Re: Annotation processors and the --processor-module-path

2016-11-21 Thread Jan Lahoda
On 21.11.2016 11:03, Alan Bateman wrote: On 21/11/2016 09:46, Eirik Bjørsnøs wrote: Alan, | $ javac --help | -processor [,,...] |Names of the annotation processors to run; bypasses default discovery process Why does the "default discovery process" work with --classpath, but not with

hg: jigsaw/jake/langtools: Improving handling of resources in ClassFinder.

2016-11-14 Thread jan . lahoda
Changeset: 6096c96e249a Author:jlahoda Date: 2016-11-14 17:03 +0100 URL: http://hg.openjdk.java.net/jigsaw/jake/langtools/rev/6096c96e249a Improving handling of resources in ClassFinder. ! src/jdk.compiler/share/classes/com/sun/tools/javac/code/ClassFinder.java

hg: jigsaw/jake/langtools: Correcting reading of module-info.class with annotation with non-primitive attributes.

2016-11-09 Thread jan . lahoda
Changeset: b3e533ec494a Author:jlahoda Date: 2016-11-09 21:20 +0100 URL: http://hg.openjdk.java.net/jigsaw/jake/langtools/rev/b3e533ec494a Correcting reading of module-info.class with annotation with non-primitive attributes. ! src/jdk.compiler/share/classes/com/sun/tools/javac/jv

hg: jigsaw/jake/jdk: Cleanup of deprecation warnings on modules in qualified exports, adjusting j.l.Deprecated javadoc.

2016-11-09 Thread jan . lahoda
Changeset: a413852e34a8 Author:jlahoda Date: 2016-11-09 15:12 +0100 URL: http://hg.openjdk.java.net/jigsaw/jake/jdk/rev/a413852e34a8 Cleanup of deprecation warnings on modules in qualified exports, adjusting j.l.Deprecated javadoc. ! src/java.base/share/classes/java/lang/Deprecate

hg: jigsaw/jake/langtools: Cleanup of deprecation warnings on modules in qualified exports.

2016-11-09 Thread jan . lahoda
Changeset: 1b2b41b41d73 Author:jlahoda Date: 2016-11-09 15:10 +0100 URL: http://hg.openjdk.java.net/jigsaw/jake/langtools/rev/1b2b41b41d73 Cleanup of deprecation warnings on modules in qualified exports. ! src/jdk.compiler/share/classes/com/sun/tools/javac/comp/Attr.java ! src/jdk.

hg: jigsaw/jake/langtools: Minor cleanup.

2016-11-08 Thread jan . lahoda
Changeset: 2dcedde260f8 Author:jlahoda Date: 2016-11-08 18:14 +0100 URL: http://hg.openjdk.java.net/jigsaw/jake/langtools/rev/2dcedde260f8 Minor cleanup. ! src/java.compiler/share/classes/javax/lang/model/element/ModuleElement.java ! src/jdk.compiler/share/classes/com/sun/source/tr

hg: jigsaw/jake/langtools: 8162669: javac crashes (NPE) on invalid module declaration

2016-10-25 Thread jan . lahoda
Changeset: 318ca6c7bc6d Author:jlahoda Date: 2016-10-25 21:37 +0200 URL: http://hg.openjdk.java.net/jigsaw/jake/langtools/rev/318ca6c7bc6d 8162669: javac crashes (NPE) on invalid module declaration ! src/jdk.compiler/share/classes/com/sun/tools/javac/comp/Enter.java ! src/jdk.compi

Re: JDK-8153362: [jigsaw] Add javac -Xlint warning to list exposed types which are not accessible

2016-09-27 Thread Jan Lahoda
On 27.9.2016 14:49, Alan Bateman wrote: On 27/09/2016 13:42, Jan Lahoda wrote: Hi, Any feedback on the top-level repository changes? http://cr.openjdk.java.net/~jlahoda/8153362/top-level.03/ This looks okay to me. Some of these should be looked at and I wonder if you have created any bugs

Re: JDK-8153362: [jigsaw] Add javac -Xlint warning to list exposed types which are not accessible

2016-09-27 Thread Jan Lahoda
Hi, Any feedback on the top-level repository changes? http://cr.openjdk.java.net/~jlahoda/8153362/top-level.03/ Thanks! Jan On 13.9.2016 16:28, Jan Lahoda wrote: Hello, I've updated the patch to the current situation. The top-level repository patch is here: http://cr.openjdk.jav

Re: JDK-8153362: [jigsaw] Add javac -Xlint warning to list exposed types which are not accessible

2016-09-13 Thread Jan Lahoda
Jan On 17.6.2016 16:18, Jan Lahoda wrote: Hi, I've updated the patches, reflecting the feedback so far. The langtools change is now split into two parts, one is only adding the new lint key (but no checks are actually performed): http://cr.openjdk.java.net/~jlahoda/8153362/langtools.01-ph

hg: jigsaw/jake/langtools: 8159603: one more testcase for model for annotations on module declarations

2016-08-18 Thread jan . lahoda
Changeset: a579a4ceb686 Author:jlahoda Date: 2016-08-18 09:52 +0200 URL: http://hg.openjdk.java.net/jigsaw/jake/langtools/rev/a579a4ceb686 8159603: one more testcase for model for annotations on module declarations ! test/tools/javac/modules/AnnotationsOnModules.java

hg: jigsaw/jake/langtools: A hotfix to module info processing order so that make docs works

2016-08-12 Thread jan . lahoda
Changeset: cbc5f0fe29a7 Author:jlahoda Date: 2016-08-12 22:50 +0200 URL: http://hg.openjdk.java.net/jigsaw/jake/langtools/rev/cbc5f0fe29a7 A hotfix to module info processing order so that make docs works ! src/jdk.compiler/share/classes/com/sun/tools/javac/comp/Enter.java ! src/jdk

Re: Review request 8136930: Simplify use of module-system options by custom launchers

2016-08-09 Thread Jan Lahoda
I took a pass through langtools changes. Overall seems OK to me. Some minor comments: -src/jdk.compiler/share/classes/com/sun/tools/javac/main/Option.java: commented-out code in hasArg(). (Some more in Option.ArgKind, but that seems mostly OK.) -src/jdk.javadoc/share/classes/com/sun/tools/javado

hg: jigsaw/jake/langtools: Uncommenting tests.

2016-07-29 Thread jan . lahoda
Changeset: e5dd3d5c83a1 Author:jlahoda Date: 2016-07-29 22:34 +0200 URL: http://hg.openjdk.java.net/jigsaw/jake/langtools/rev/e5dd3d5c83a1 Uncommenting tests. ! test/tools/javac/classfiles/attributes/Module/ModuleTest.java

hg: jigsaw/jake/langtools: 8161596: Error while compiling "requires static public"

2016-07-28 Thread jan . lahoda
Changeset: 5b137cb11cf5 Author:jlahoda Date: 2016-07-28 15:44 +0200 URL: http://hg.openjdk.java.net/jigsaw/jake/langtools/rev/5b137cb11cf5 8161596: Error while compiling "requires static public" ! src/jdk.compiler/share/classes/com/sun/tools/javac/parser/JavacParser.java ! test/too

8072988: Update javax.annotation.processing for modules

2016-07-18 Thread Jan Lahoda
Hi, I'd like to discuss enhacements to the Annotation Processing API for modules. My current sketch is here (against jigsaw/jake): http://cr.openjdk.java.net/~jlahoda/8072988/webrev.00/ This patch augments Filer methods with variants that take a "module" parameter, allowing to generate classe

Re: JDK-8153362: [jigsaw] Add javac -Xlint warning to list exposed types which are not accessible

2016-07-14 Thread Jan Lahoda
ave to be updated in a lockstep. In addition to the langtools changes, only the top-level repository needs to be changed now, to disable the checks in some modules: http://cr.openjdk.java.net/~jlahoda/8153362/top-level.01/ Any feedback is welcome! Thanks, Jan On 14.6.2016 14:29, Jan Lahoda wrote:

hg: jigsaw/jake/langtools: 8159602: improving support for annotations on modules; fixing handling of deprecated modules.

2016-07-13 Thread jan . lahoda
Changeset: 150e4e7f0825 Author:jlahoda Date: 2016-07-13 22:49 +0200 URL: http://hg.openjdk.java.net/jigsaw/jake/langtools/rev/150e4e7f0825 8159602: improving support for annotations on modules; fixing handling of deprecated modules. ! src/jdk.compiler/share/classes/com/sun/source/

hg: jigsaw/jake/jdk: Adding @SuppressWarnings("deprecation") to modules that refer to a deprecated module.

2016-07-13 Thread jan . lahoda
Changeset: 179fd5181ac3 Author:jlahoda Date: 2016-07-13 20:30 +0200 URL: http://hg.openjdk.java.net/jigsaw/jake/jdk/rev/179fd5181ac3 Adding @SuppressWarnings("deprecation") to modules that refer to a deprecated module. ! src/java.base/share/classes/module-info.java ! src/java.nami

hg: jigsaw/jake/langtools: 14 new changesets

2016-07-10 Thread jan . lahoda
Changeset: d213ecfb98b2 Author:vromero Date: 2016-06-27 12:29 -0700 URL: http://hg.openjdk.java.net/jigsaw/jake/langtools/rev/d213ecfb98b2 8159439: javac throws NPE with Module attribute and super_class != 0 Reviewed-by: jjg ! src/jdk.compiler/share/classes/com/sun/tools/javac/comp

hg: jigsaw/jake/jdk: Adding ElementType.MODULE as a target for @SuppressWarnings.

2016-07-08 Thread jan . lahoda
Changeset: f985e08a0422 Author:jlahoda Date: 2016-07-08 16:20 +0200 URL: http://hg.openjdk.java.net/jigsaw/jake/jdk/rev/f985e08a0422 Adding ElementType.MODULE as a target for @SuppressWarnings. Contributed-by: joe.da...@oracle.com ! src/java.base/share/classes/java/lang/SuppressWar

Re: JDK-8153362: [jigsaw] Add javac -Xlint warning to list exposed types which are not accessible

2016-06-17 Thread Jan Lahoda
repository needs to be changed now, to disable the checks in some modules: http://cr.openjdk.java.net/~jlahoda/8153362/top-level.01/ Any feedback is welcome! Thanks, Jan On 14.6.2016 14:29, Jan Lahoda wrote: Hi Alan, On 14.6.2016 12:57, Alan Bateman wrote: On 13/06/2016 17:12, Jan Lahoda wrot

Re: Error message when accessing non-public type

2016-06-15 Thread Jan Lahoda
Hi Gunnar, I don't recall a significant change recently regarding the errors, javac (should) currently produce either the "cannot find" or "not visible" error depending on exact circumstances ("not visible" should be produced if javac have already seen the given class). We are currently lookin

Re: JDK-8153362: [jigsaw] Add javac -Xlint warning to list exposed types which are not accessible

2016-06-14 Thread Jan Lahoda
Hi Alan, On 14.6.2016 12:57, Alan Bateman wrote: On 13/06/2016 17:12, Jan Lahoda wrote: Hello, There is: https://bugs.openjdk.java.net/browse/JDK-8153362 which is about a new warning that should be produced by javac when exported API refers to types not exported/accessible to the API

Re: JDK-8153362: [jigsaw] Add javac -Xlint warning to list exposed types which are not accessible

2016-06-14 Thread Jan Lahoda
one those files and submit bugs against swing & accessibility and the area owner can then make the decision as to the appropriate treatment. You can keep the JDK buildable in the meanwhile by suppressing the lint warnings on the desktop module. -phil. On 06/13/2016 09:12 AM, Jan Lahoda wrote:

JDK-8153362: [jigsaw] Add javac -Xlint warning to list exposed types which are not accessible

2016-06-13 Thread Jan Lahoda
Hello, There is: https://bugs.openjdk.java.net/browse/JDK-8153362 which is about a new warning that should be produced by javac when exported API refers to types not exported/accessible to the API clients. I've put my current javac change here: http://cr.openjdk.java.net/~jlahoda/8153362/lang

Re: Compact profiles broken?

2016-05-19 Thread Jan Lahoda
This appears to be a bug in the current profiles handling in javac - currently (without "-release X"), javac uses "ct.properties" to determine the profile of a class. This file contains mapping from package to extra metadata, esp. profile. And this file does not contain mapping for javax.crypto

hg: jigsaw/jake/langtools: Avoiding RunCodingRules crash if the build directory is not available.

2016-04-29 Thread jan . lahoda
Changeset: 2f2d9ba7adc3 Author:jlahoda Date: 2016-04-29 13:13 +0200 URL: http://hg.openjdk.java.net/jigsaw/jake/langtools/rev/2f2d9ba7adc3 Avoiding RunCodingRules crash if the build directory is not available. ! test/tools/all/RunCodingRules.java

hg: jigsaw/jake/langtools: Putting get{Package, Type}Element(ModuleElement, CharSequence) to the API

2016-04-19 Thread jan . lahoda
Changeset: 34cf24d59a8a Author:jlahoda Date: 2016-04-19 18:39 +0200 URL: http://hg.openjdk.java.net/jigsaw/jake/langtools/rev/34cf24d59a8a Putting get{Package,Type}Element(ModuleElement, CharSequence) to the API ! src/java.compiler/share/classes/javax/lang/model/util/Elements.java

hg: jigsaw/jake/langtools: When enabling jdk.* modules, only enable such that have unqualified exports.

2016-04-19 Thread jan . lahoda
Changeset: 51ae411baf31 Author:jlahoda Date: 2016-04-19 09:47 +0200 URL: http://hg.openjdk.java.net/jigsaw/jake/langtools/rev/51ae411baf31 When enabling jdk.* modules, only enable such that have unqualified exports. ! src/jdk.compiler/share/classes/com/sun/tools/javac/comp/Modules.

hg: jigsaw/jake/langtools: Adjusting AddLimitMods to recent change in ToolBox.

2016-04-08 Thread jan . lahoda
Changeset: eb0210d6eefd Author:jlahoda Date: 2016-04-08 11:26 +0200 URL: http://hg.openjdk.java.net/jigsaw/jake/langtools/rev/eb0210d6eefd Adjusting AddLimitMods to recent change in ToolBox. ! test/tools/javac/modules/AddLimitMods.java

hg: jigsaw/jake/langtools: 8152958: Update javac to implement new policy to not resolve the EE modules

2016-04-07 Thread jan . lahoda
Changeset: 2e84845719f1 Author:jlahoda Date: 2016-04-07 13:03 +0200 URL: http://hg.openjdk.java.net/jigsaw/jake/langtools/rev/2e84845719f1 8152958: Update javac to implement new policy to not resolve the EE modules Summary: Changing root modules set for unnamed module compilation to

hg: jigsaw/jake/langtools: Tweaking comments.

2016-03-15 Thread jan . lahoda
Changeset: cc7fca5d54f3 Author:jlahoda Date: 2016-03-15 15:24 +0100 URL: http://hg.openjdk.java.net/jigsaw/jake/langtools/rev/cc7fca5d54f3 Tweaking comments. ! src/jdk.compiler/share/classes/com/sun/tools/javac/code/Flags.java ! src/jdk.compiler/share/classes/com/sun/tools/javac/co

hg: jigsaw/jake/langtools: DocTrees.getElement shouldn't crash on an invalid package#member reference.

2016-03-14 Thread jan . lahoda
Changeset: 6cacf96c868b Author:jlahoda Date: 2016-03-14 20:58 +0100 URL: http://hg.openjdk.java.net/jigsaw/jake/langtools/rev/6cacf96c868b DocTrees.getElement shouldn't crash on an invalid package#member reference. ! src/jdk.compiler/share/classes/com/sun/tools/javac/api/JavacTrees

hg: jigsaw/jake/langtools: Introducing -addmods ALL-MODULE-PATH, supporting -addmods ALL-SYSTEM; disallowing -addmods/-limitmods with -target <= 8.

2016-03-14 Thread jan . lahoda
Changeset: fe889e047657 Author:jlahoda Date: 2016-03-14 20:55 +0100 URL: http://hg.openjdk.java.net/jigsaw/jake/langtools/rev/fe889e047657 Introducing -addmods ALL-MODULE-PATH, supporting -addmods ALL-SYSTEM; disallowing -addmods/-limitmods with -target <= 8. ! src/jdk.compiler/sh

hg: jigsaw/jake/langtools: Fixing IntelliJ project after the recent langtools ant build change - change by mcimadamore

2016-03-11 Thread jan . lahoda
Changeset: 41fc9021548e Author:jlahoda Date: 2016-03-11 18:57 +0100 URL: http://hg.openjdk.java.net/jigsaw/jake/langtools/rev/41fc9021548e Fixing IntelliJ project after the recent langtools ant build change - change by mcimadamore ! make/intellij/build.xml ! make/intellij/src/idea

hg: jigsaw/jake/langtools: Must fail the build then javac fails

2016-03-11 Thread jan . lahoda
Changeset: 556fedf967ed Author:jlahoda Date: 2016-03-11 17:28 +0100 URL: http://hg.openjdk.java.net/jigsaw/jake/langtools/rev/556fedf967ed Must fail the build then javac fails ! make/build.xml

hg: jigsaw/jake/langtools: Cleanup, reflecting comments by anazarov.

2016-03-11 Thread jan . lahoda
Changeset: 5db301565973 Author:jlahoda Date: 2016-03-11 14:29 +0100 URL: http://hg.openjdk.java.net/jigsaw/jake/langtools/rev/5db301565973 Cleanup, reflecting comments by anazarov. ! src/jdk.compiler/share/classes/com/sun/tools/javac/code/Flags.java ! src/jdk.compiler/share/classes

hg: jigsaw/jake/langtools: Renaming the property holding the target JDK from jdk.home to langtools.jdk.home; using javac -m.

2016-03-11 Thread jan . lahoda
Changeset: 401b25c9ad7e Author:jlahoda Date: 2016-03-11 07:48 +0100 URL: http://hg.openjdk.java.net/jigsaw/jake/langtools/rev/401b25c9ad7e Renaming the property holding the target JDK from jdk.home to langtools.jdk.home; using javac -m. ! make/build.xml ! make/intellij/ant.xml ! m

hg: jigsaw/jake/langtools: Fixing tests on Win.

2016-03-10 Thread jan . lahoda
Changeset: 4316d49b4bb1 Author:jlahoda Date: 2016-03-10 14:35 +0100 URL: http://hg.openjdk.java.net/jigsaw/jake/langtools/rev/4316d49b4bb1 Fixing tests on Win. ! test/tools/javac/modules/AddLimitMods.java ! test/tools/javac/modules/AnnotationProcessorsInModulesTest.java ! test/tool

hg: jigsaw/jake/langtools: Reflecting feedback by mcimadamore; cleanup.

2016-03-09 Thread jan . lahoda
Changeset: 5f23a3827660 Author:jlahoda Date: 2016-03-09 15:41 +0100 URL: http://hg.openjdk.java.net/jigsaw/jake/langtools/rev/5f23a3827660 Reflecting feedback by mcimadamore; cleanup. ! src/jdk.compiler/share/classes/com/sun/tools/javac/code/ClassFinder.java ! src/jdk.compiler/shar

hg: jigsaw/jake/langtools: All tests that use ToolBox must require jdk.jdeps/com.sun.tools.javap

2016-03-09 Thread jan . lahoda
Changeset: 5805785aa08a Author:jlahoda Date: 2016-03-09 15:14 +0100 URL: http://hg.openjdk.java.net/jigsaw/jake/langtools/rev/5805785aa08a All tests that use ToolBox must require jdk.jdeps/com.sun.tools.javap ! test/tools/doclint/tool/PathsTest.java ! test/tools/javac/4846262/Check

hg: jigsaw/jake/langtools: Changing ModuleSymbol.visiblePackage from Set to Map, to avoid linear search in lookupPackage, as noted by mcimadamore.

2016-03-08 Thread jan . lahoda
Changeset: ceb8dfa70331 Author:jlahoda Date: 2016-03-08 17:41 +0100 URL: http://hg.openjdk.java.net/jigsaw/jake/langtools/rev/ceb8dfa70331 Changing ModuleSymbol.visiblePackage from Set to Map, to avoid linear search in lookupPackage, as noted by mcimadamore. ! src/jdk.compiler/sha

hg: jigsaw/jake/langtools: Temporarily deleting module-info.class-es for langtools modules, so that -Xpatch works for the langtools' ant build.

2016-03-04 Thread jan . lahoda
Changeset: 31254fcb00f2 Author:jlahoda Date: 2016-03-04 19:16 +0100 URL: http://hg.openjdk.java.net/jigsaw/jake/langtools/rev/31254fcb00f2 Temporarily deleting module-info.class-es for langtools modules, so that -Xpatch works for the langtools' ant build. ! make/build.xml

hg: jigsaw/jake/langtools: 8151202: jdk/jshell/CompletionSuggestionTest.java fails in jake after jdk-9+108 integration

2016-03-04 Thread jan . lahoda
Changeset: dd284d97bd89 Author:jlahoda Date: 2016-03-04 10:25 +0100 URL: http://hg.openjdk.java.net/jigsaw/jake/langtools/rev/dd284d97bd89 8151202: jdk/jshell/CompletionSuggestionTest.java fails in jake after jdk-9+108 integration Summary: Re-adjusting test for the java.home marker

hg: jigsaw/jake/langtools: 8148608: Intermittent java.nio.file.ProviderNotFoundException when building Jake

2016-03-01 Thread jan . lahoda
Changeset: a8d05939727f Author:jlahoda Date: 2016-03-01 17:58 +0100 URL: http://hg.openjdk.java.net/jigsaw/jake/langtools/rev/a8d05939727f 8148608: Intermittent java.nio.file.ProviderNotFoundException when building Jake Summary: Using Files.isRegularFile instead of !Files.isDirector

hg: jigsaw/jake/langtools: Addressing some of the comments by anazarov.

2016-03-01 Thread jan . lahoda
Changeset: dfccd8d116a6 Author:jlahoda Date: 2016-03-01 14:48 +0100 URL: http://hg.openjdk.java.net/jigsaw/jake/langtools/rev/dfccd8d116a6 Addressing some of the comments by anazarov. ! src/jdk.compiler/share/classes/com/sun/tools/javac/comp/Modules.java ! src/jdk.compiler/share/c

hg: jigsaw/jake/langtools: 8150030: Fix Elements.get{Type,Package}Element/JavaCompiler.resolveIdent on uninitialized javac; ...

2016-02-29 Thread jan . lahoda
Changeset: 4f320a94d1df Author:jlahoda Date: 2016-02-29 12:07 +0100 URL: http://hg.openjdk.java.net/jigsaw/jake/langtools/rev/4f320a94d1df 8150030: Fix Elements.get{Type,Package}Element/JavaCompiler.resolveIdent on uninitialized javac 8150031: Fix tools/javac/importscope/dependenci

hg: jigsaw/jake/jdk: 8150092: Named modules should not be able to access types from classpath. (adjusting jdk tests)

2016-02-17 Thread jan . lahoda
Changeset: bb550b381d37 Author:jlahoda Date: 2016-02-17 21:37 +0100 URL: http://hg.openjdk.java.net/jigsaw/jake/jdk/rev/bb550b381d37 8150092: Named modules should not be able to access types from classpath. (adjusting jdk tests) ! test/jdk/jigsaw/launcher/addreads/AddReadsTest.jav

hg: jigsaw/jake/langtools: 8150092: Named modules should not be able to access types from classpath.

2016-02-17 Thread jan . lahoda
Changeset: 1da86e0c5315 Author:jlahoda Date: 2016-02-17 21:36 +0100 URL: http://hg.openjdk.java.net/jigsaw/jake/langtools/rev/1da86e0c5315 8150092: Named modules should not be able to access types from classpath. ! src/jdk.compiler/share/classes/com/sun/tools/javac/code/ModuleFinde

hg: jigsaw/jake/langtools: Adding bug numbers to some excluded tests, enabling ProfileOptionTest

2016-02-17 Thread jan . lahoda
Changeset: 8e441ecbc324 Author:jlahoda Date: 2016-02-17 11:48 +0100 URL: http://hg.openjdk.java.net/jigsaw/jake/langtools/rev/8e441ecbc324 Adding bug numbers to some excluded tests, enabling ProfileOptionTest ! test/ProblemList.jake.txt

hg: jigsaw/jake/langtools: 2 new changesets

2016-02-12 Thread jan . lahoda
Changeset: 459dbb95694f Author:jlahoda Date: 2016-02-12 21:26 +0100 URL: http://hg.openjdk.java.net/jigsaw/jake/langtools/rev/459dbb95694f Fixing ExplodedImage.java test. ! test/ProblemList.jake.txt ! test/tools/javac/file/ExplodedImage.java Changeset: fcdba8968364 Author:jlah

hg: jigsaw/jake/langtools: Fixing new javadoc code in jake.

2016-02-11 Thread jan . lahoda
Changeset: 2035b8e758b2 Author:jlahoda Date: 2016-02-11 17:00 +0100 URL: http://hg.openjdk.java.net/jigsaw/jake/langtools/rev/2035b8e758b2 Fixing new javadoc code in jake. Contributed-by: kumar.x.sriniva...@oracle.com, jan.lah...@oracle.com ! make/CompileInterim.gmk ! src/jdk.compi

hg: jigsaw/jake/langtools: Avoid use of hardcoded reference to java.base in JavacElements.nameToSymbol.

2016-02-09 Thread jan . lahoda
Changeset: ac59d7dedd49 Author:jlahoda Date: 2016-02-09 18:02 +0100 URL: http://hg.openjdk.java.net/jigsaw/jake/langtools/rev/ac59d7dedd49 Avoid use of hardcoded reference to java.base in JavacElements.nameToSymbol. ! src/jdk.compiler/share/classes/com/sun/tools/javac/model/JavacEl

hg: jigsaw/jake/jdk: Fixing GetResourceBundleTest after recent change to enabled modules in javac - the compilation now needs to use -addmods similarly to runtime.

2016-02-08 Thread jan . lahoda
Changeset: ff715ebf0299 Author:jlahoda Date: 2016-02-08 23:14 +0100 URL: http://hg.openjdk.java.net/jigsaw/jake/jdk/rev/ff715ebf0299 Fixing GetResourceBundleTest after recent change to enabled modules in javac - the compilation now needs to use -addmods similarly to runtime. ! tes

hg: jigsaw/jake/jdk: 8144623: adjusting tests to recent change to enabled modules in javac (try 2).

2016-02-08 Thread jan . lahoda
Changeset: 9ecaf2673e3c Author:jlahoda Date: 2016-02-07 21:41 +0100 URL: http://hg.openjdk.java.net/jigsaw/jake/jdk/rev/9ecaf2673e3c 8144623: adjusting tests to recent change to enabled modules in javac (try 2). ! test/java/lang/Class/getResource/ResourcesTest.java ! test/java/lang

hg: jigsaw/jake/langtools: 8144623: adding -addmods/-limitmods options; adjusting the set of enabled modules to match runtime behavior (try 2).

2016-02-08 Thread jan . lahoda
Changeset: bfa233e22145 Author:jlahoda Date: 2016-02-07 21:40 +0100 URL: http://hg.openjdk.java.net/jigsaw/jake/langtools/rev/bfa233e22145 8144623: adding -addmods/-limitmods options; adjusting the set of enabled modules to match runtime behavior (try 2). ! src/jdk.compiler/share/

hg: jigsaw/jake/langtools: Avoid using indy concat when compiling code that needs to run inside ant itself.

2016-02-08 Thread jan . lahoda
Changeset: 7aacdf3bcf93 Author:jlahoda Date: 2016-02-08 17:53 +0100 URL: http://hg.openjdk.java.net/jigsaw/jake/langtools/rev/7aacdf3bcf93 Avoid using indy concat when compiling code that needs to run inside ant itself. ! make/build.xml

hg: jigsaw/jake/jdk: Undoing recent adjustment to set of enabled modules in javac

2016-02-07 Thread jan . lahoda
Changeset: 3178b9ae17de Author:jlahoda Date: 2016-02-07 23:01 +0100 URL: http://hg.openjdk.java.net/jigsaw/jake/jdk/rev/3178b9ae17de Undoing recent adjustment to set of enabled modules in javac ! test/java/lang/Class/getResource/ResourcesTest.java ! test/java/lang/ClassLoader/getRe

hg: jigsaw/jake/langtools: Reverting a change to enabled modules set in javac, to investigate a javadoc crash.

2016-02-07 Thread jan . lahoda
Changeset: 5070be7e2170 Author:jlahoda Date: 2016-02-07 22:59 +0100 URL: http://hg.openjdk.java.net/jigsaw/jake/langtools/rev/5070be7e2170 Reverting a change to enabled modules set in javac, to investigate a javadoc crash. ! src/jdk.compiler/share/classes/com/sun/tools/javac/code/

hg: jigsaw/jake/jdk: 8144623: adjusting tests to recent change to enabled modules in javac.

2016-02-07 Thread jan . lahoda
Changeset: b73aa4b22db6 Author:jlahoda Date: 2016-02-07 21:41 +0100 URL: http://hg.openjdk.java.net/jigsaw/jake/jdk/rev/b73aa4b22db6 8144623: adjusting tests to recent change to enabled modules in javac. ! test/java/lang/Class/getResource/ResourcesTest.java ! test/java/lang/ClassLo

hg: jigsaw/jake/langtools: 8144623: adding -addmods/-limitmods options; adjusting the set of enabled modules to match runtime behavior.

2016-02-07 Thread jan . lahoda
Changeset: 3e51fefb6cd1 Author:jlahoda Date: 2016-02-07 21:40 +0100 URL: http://hg.openjdk.java.net/jigsaw/jake/langtools/rev/3e51fefb6cd1 8144623: adding -addmods/-limitmods options; adjusting the set of enabled modules to match runtime behavior. ! src/jdk.compiler/share/classes/

hg: jigsaw/jake/jdk: Avoiding mistakenly using a last used set instead of an empty set while constructing ModuleDescriptors in InstalledModules

2016-02-04 Thread jan . lahoda
Changeset: 9f1a5962492e Author:jlahoda Date: 2016-02-04 21:50 + URL: http://hg.openjdk.java.net/jigsaw/jake/jdk/rev/9f1a5962492e Avoiding mistakenly using a last used set instead of an empty set while constructing ModuleDescriptors in InstalledModules ! src/jdk.jlink/share/cl

hg: jigsaw/jake/langtools: 8067872: simplifying the langtools' ant build.

2016-01-27 Thread jan . lahoda
Changeset: 9cf2f722fc41 Author:mcimadamore Date: 2016-01-27 19:23 +0100 URL: http://hg.openjdk.java.net/jigsaw/jake/langtools/rev/9cf2f722fc41 8067872: simplifying the langtools' ant build. ! make/build.properties ! make/build.xml ! make/intellij/ant.xml ! make/intellij/build.xml !

hg: jigsaw/jake/langtools: 8142504: Annotation processing breaks in single named-module case with module-info on classpath

2016-01-22 Thread jan . lahoda
Changeset: d913b89ff9a6 Author:jlahoda Date: 2016-01-22 18:43 +0100 URL: http://hg.openjdk.java.net/jigsaw/jake/langtools/rev/d913b89ff9a6 8142504: Annotation processing breaks in single named-module case with module-info on classpath ! src/jdk.compiler/share/classes/com/sun/tools

hg: jigsaw/jake/langtools: One more place where directory could be created while javac is running and a stale cached isDirectory information could be used.

2016-01-20 Thread jan . lahoda
Changeset: 8dded0f29712 Author:jlahoda Date: 2016-01-20 17:35 +0100 URL: http://hg.openjdk.java.net/jigsaw/jake/langtools/rev/8dded0f29712 One more place where directory could be created while javac is running and a stale cached isDirectory information could be used. ! src/jdk.com

hg: jigsaw/jake/langtools: Use jrt-fs forwarding to implement -system(modulepath) when jrt-fs is available on the platform.

2016-01-15 Thread jan . lahoda
Changeset: ac4cbad574a2 Author:jlahoda Date: 2016-01-15 23:41 +0100 URL: http://hg.openjdk.java.net/jigsaw/jake/langtools/rev/ac4cbad574a2 Use jrt-fs forwarding to implement -system(modulepath) when jrt-fs is available on the platform. ! src/jdk.compiler/share/classes/com/sun/tool

hg: jigsaw/jake/langtools: A build failure hotfix - a directory may be created while javac is running, and when a stale cached isDirectory==false is used, the path is considered to be a zip/jar file,

2016-01-11 Thread jan . lahoda
Changeset: 88a030b2b4b0 Author:jlahoda Date: 2016-01-11 13:19 +0100 URL: http://hg.openjdk.java.net/jigsaw/jake/langtools/rev/88a030b2b4b0 A build failure hotfix - a directory may be created while javac is running, and when a stale cached isDirectory==false is used, the path is con

hg: jigsaw/jake/langtools: 8144845: produce an error instead of a warning when there are conflicting visible packages.

2016-01-06 Thread jan . lahoda
Changeset: 66e7f5ddd959 Author:jlahoda Date: 2016-01-06 13:19 +0100 URL: http://hg.openjdk.java.net/jigsaw/jake/langtools/rev/66e7f5ddd959 8144845: produce an error instead of a warning when there are conflicting visible packages. ! src/jdk.compiler/share/classes/com/sun/tools/jav

hg: jigsaw/jake/jdk: 8144845: must not compile source belonging to a package that is in an exported package in a different module.

2016-01-06 Thread jan . lahoda
Changeset: b55e25e79118 Author:jlahoda Date: 2016-01-06 13:15 +0100 URL: http://hg.openjdk.java.net/jigsaw/jake/jdk/rev/b55e25e79118 8144845: must not compile source belonging to a package that is in an exported package in a different module. ! test/jdk/jigsaw/scenarios/overlappin

Re: Unable to compile modules with references to automatic modules - "cannot find module: jdk.management.resource"

2015-11-08 Thread Jan Lahoda
On 7.11.2015 15:34, Alan Bateman wrote: On 07/11/2015 10:15, Florian Troßbach wrote: : When I compile my modules with javac -d . -mp ../jars -modulesourcepath . -verbose $(find . -name "*.java") I get the attached output. The raised error is "error: cannot find module: jdk.management.resour

Re: RFR [JEP 220] Modular Run-Time Images

2014-12-01 Thread Jan Lahoda
javac changes seem generally OK to me with a few nits below (I am OK if these are handled separately as needed). Jan -ClassFinder, above getSupplementaryFlags: typo "superceded"? -Locations, method systemClasses, in the jimage branch, there is: Collection images = files .filter(f