+1
Really nice, thank you.
> On Nov 15, 2016, at 11:16 AM, Denis Kononenko
> wrote:
>
>
> Hi,
>
> Please do re-review for these changes.
>
> 1) tests for list --include were rewritten accordingly to
> https://bugs.openjdk.java.net/browse/JDK-8167384;
> 2) removed tests for '@filename', see
Hi,
Please do re-review for these changes.
1) tests for list --include were rewritten accordingly to
https://bugs.openjdk.java.net/browse/JDK-8167384;
2) removed tests for '@filename', see
https://bugs.openjdk.java.net/browse/JDK-8169720;
3) two new CRs were submitted:
https://bugs.openjdk.ja
Hi Andrey,
No, it isn't. I submitted a new CR:
https://bugs.openjdk.java.net/browse/JDK-8167384.
Thank you,
Denis.
> Hi,
>
> Looks OK. Is it 100% pass rate?
>
> —Andrey
> > On 9 Nov 2016, at 20:36, Denis Kononenko
> wrote:
> >
> >
> >
> > Hi,
> >
> > After discussion with Andrey we dec
Hi,
Looks OK. Is it 100% pass rate?
—Andrey
> On 9 Nov 2016, at 20:36, Denis Kononenko wrote:
>
>
>
> Hi,
>
> After discussion with Andrey we decided to add more tests for corner cases.
> The new changes are available by the link below.
>
> WEBREV: http://cr.openjdk.java.net/~dkononenko/8
Hi,
After discussion with Andrey we decided to add more tests for corner cases.
The new changes are available by the link below.
WEBREV: http://cr.openjdk.java.net/~dkononenko/8167240/webrev.03/
BUGURL: https://bugs.openjdk.java.net/browse/JDK-8167240
Thank you,
Denis.
> Hi,
>
> Looks OK to
Hi,
Looks OK to me.
I can suggest two more cases. A directory and file symlink can be passed in
options where tool requires a file path.
—Andrey
> On 8 Nov 2016, at 16:17, Denis Kononenko wrote:
>
>
> Hi,
>
> The new version of changes.
>
> - Switched back to jdk/test/testlibrary to avoid
Hi,
The new version of changes.
- Switched back to jdk/test/testlibrary to avoid unwanted dependencies
(JImageToolTest.java);
- Verified tests on smallest possible JDK build.
WEBREV: http://cr.openjdk.java.net/~dkononenko/8167240/webrev.02/
BUGURL: https://bugs.openjdk.java.net/browse/JDK-81
Denis,
I can see that you have switched to the top level test library with this
change. With that you are getting more module dependencies than just
java.base. First of all, it would probably make sense to build only the classes
you needed (which would be jdk.test.lib.process.ProcessTools, I
Nice work. +1
> On Nov 3, 2016, at 10:29 AM, Denis Kononenko
> wrote:
>
> Hi,
>
> I've done some rework accordingly to Alan's and Shura's comments:
>
> 1) removed overlapped tests from JImageToolTest.java;
>
> 2) added new tests JImageVerifyTest.java for jimage verify;
>
> 3) reorganized
Hi,
I've done some rework accordingly to Alan's and Shura's comments:
1) removed overlapped tests from JImageToolTest.java;
2) added new tests JImageVerifyTest.java for jimage verify;
3) reorganized jtreg's tags;
The new WEBREV can be found here:
http://cr.openjdk.java.net/~dkononenko/816724
> >
> Duplicate and overlapping tests are a pain when things are changing
> that
> require updates to the tests. So in this case then I think it would be
>
> very useful to go over the pre-existing tests to weed out some of the
>
> original tests that are obsoleted by the new tests.
Ok, I'll
On 07/10/2016 00:05, Denis Kononenko wrote:
:
Yes, they do. Overlapping occurs in very common use cases.
However I wouldn't remove JImageToolTest, we need such a test to ensure:
1) bin/jimage exists;
2) bin/jimage properly communicates to jdk.tools.jimage.JImageTask;
I think it could be simpli
> >
> > Could someone please review these new tests for jimage utility.
> >
> > There're 5 new files containing tests to cover use cases for 'info',
>
> > 'list', 'extract' and other options. No new tests for 'verify'.
> >
> > BUGURL: https://bugs.openjdk.java.net/browse/JDK-8167240
> > WEBREV: h
On 06/10/2016 17:37, Denis Kononenko wrote:
Hi,
Could someone please review these new tests for jimage utility.
There're 5 new files containing tests to cover use cases for 'info',
'list', 'extract' and other options. No new tests for 'verify'.
BUGURL: https://bugs.openjdk.java.net/browse/J
Hi, Denis,
By an agreement, @modules should go before any action tag. You use it after
@build.
Shura
> On Oct 6, 2016, at 9:37 AM, Denis Kononenko
> wrote:
>
> Hi,
>
> Could someone please review these new tests for jimage utility.
>
> There're 5 new files containing tests to cover use cas
Hi,
Could someone please review these new tests for jimage utility.
There're 5 new files containing tests to cover use cases for 'info',
'list', 'extract' and other options. No new tests for 'verify'.
BUGURL: https://bugs.openjdk.java.net/browse/JDK-8167240
WEBREV: http://cr.openjdk.java.net/
16 matches
Mail list logo
