If the test is in the FX repo then it wouldn't be able to check the
jmod, but would have to check some intermediate data that feeds into the
jmod. That might be OK, but is seems easy enough to check for the
existence of the jdk.packager module and skip the test if not present.
-- Kevin
Mandy
It can’t live in FX. FX can be built with an open, closed or custom JDK without
FX so this test needs to be in the JDK but it would be best if we can only
attempt to run it if FX is imported.
Chris
> On Feb 7, 2017, at 11:37 AM, Mandy Chung wrote:
>
> Should this test be in the FX repo where
Should this test be in the FX repo where jdk.packager resides? I would think
so. This test should only run with the build with FX modules.
Mandy
> On Feb 7, 2017, at 10:32 AM, Victor Drozdov wrote:
>
> Kevin, Mandy,
>
> Please review my new unit test for javapackager. It reads redistributabl
It will fail to compile. Is there a way to test if jdk.packager is present
before compiling?
Chris
> On Feb 7, 2017, at 10:38 AM, David DeHaven wrote:
>
>
>> Kevin, Mandy,
>>
>> Please review my new unit test for javapackager. It reads redistributable
>> module list from jdk.packager, if a
> Kevin, Mandy,
>
> Please review my new unit test for javapackager. It reads redistributable
> module list from jdk.packager, if a module in the list doesn't exist, then
> the test fails.
>
> JIRA: https://bugs.openjdk.java.net/browse/JDK-8170200
> Webrev: http://cr.openjdk.java.net/~vdrozdov
