[9] review request: 8131888: Deliver javafx.swt as a modular jar in JDK 9

2016-05-25 Thread Kevin Rushforth
Please review the following: https://bugs.openjdk.java.net/browse/JDK-8131888 http://cr.openjdk.java.net/~kcr/8131888/webrev.00/ This adds support for the javafx.embed.swt package back into the JDK, which will be delivered as an automatic module in $JAVA_HOME/lib/javafx-swt.jar (final location

Re: [9] review request: 8131888: Deliver javafx.swt as a modular jar in JDK 9

2016-05-25 Thread Mandy Chung
> On May 25, 2016, at 3:38 PM, Kevin Rushforth > wrote: > > Please review the following: > > https://bugs.openjdk.java.net/browse/JDK-8131888 > http://cr.openjdk.java.net/~kcr/8131888/webrev.00/ > > This adds support for the javafx.embed.swt package back into the JDK, which > will be delive

Re: [9] review request: 8131888: Deliver javafx.swt as a modular jar in JDK 9

2016-05-26 Thread Kevin Rushforth
Mandy, Thanks for your feedback. Comments inline. Mandy Chung wrote: On May 25, 2016, at 3:38 PM, Kevin Rushforth wrote: Please review the following: https://bugs.openjdk.java.net/browse/JDK-8131888 http://cr.openjdk.java.net/~kcr/8131888/webrev.00/ This adds support for the javafx.embed

Re: [9] review request: 8131888: Deliver javafx.swt as a modular jar in JDK 9

2016-05-26 Thread Kevin Rushforth
If you add javafx-swt.jar to the custom classpath created by the OSGI container it should work in the same way it does today when you add jfxswt.jar. Can you suggest an easy way that I can test this? -- Kevin Tom Schindl wrote: Hi, I highly doubt this will work in an OSGi-Env like Eclipse

Re: [9] review request: 8131888: Deliver javafx.swt as a modular jar in JDK 9

2016-05-26 Thread Kevin Rushforth
Yes, I've tested it in both modes (with a simple HelloFXCanvas program) -- as an automatic jar file and as just an ordinary jar on the classpath. -- Kevin Tom Schindl wrote: Rereading the jira it take that back if javafx.swt can still be loaded as a simple jar things will work Tom Von mein

Re: [9] review request: 8131888: Deliver javafx.swt as a modular jar in JDK 9

2016-05-26 Thread Mandy Chung
> On May 26, 2016, at 8:38 AM, Kevin Rushforth > wrote: > > Yes, I've tested it in both modes (with a simple HelloFXCanvas program) -- as > an automatic jar file and as just an ordinary jar on the classpath. an automatic module needs to be on modulepath. For container-like environment, it ca

Re: [9] review request: 8131888: Deliver javafx.swt as a modular jar in JDK 9

2016-05-26 Thread Tom Schindl
I'll prepare a simple osgi swt test app Tom Von meinem iPhone gesendet > Am 26.05.2016 um 17:38 schrieb Kevin Rushforth : > > Yes, I've tested it in both modes (with a simple HelloFXCanvas program) -- as > an automatic jar file and as just an ordinary jar on the classpath. > > -- Kevin > >

Re: [9] review request: 8131888: Deliver javafx.swt as a modular jar in JDK 9

2016-05-26 Thread Tom Schindl
Hi, I highly doubt this will work in an OSGi-Env like Eclipse (which the 99%) use case for SWT useage. The SWT jar is not on the application classpath so how should a module (named or unnamed) find the SWT classes? Tom Von meinem iPhone gesendet > Am 26.05.2016 um 02:43 schrieb Mandy Chung :

Re: [9] review request: 8131888: Deliver javafx.swt as a modular jar in JDK 9

2016-05-26 Thread Tom Schindl
Rereading the jira it take that back if javafx.swt can still be loaded as a simple jar things will work Tom Von meinem iPhone gesendet > Am 26.05.2016 um 16:51 schrieb Tom Schindl : > > Hi, > > I highly doubt this will work in an OSGi-Env like Eclipse (which the 99%) use > case for SWT useag

Re: [9] review request: 8131888: Deliver javafx.swt as a modular jar in JDK 9

2016-05-27 Thread Tom Schindl
Do you have an example how to construct such a Layer? Tom Von meinem iPhone gesendet > Am 26.05.2016 um 17:47 schrieb Mandy Chung : > > >> On May 26, 2016, at 8:38 AM, Kevin Rushforth >> wrote: >> >> Yes, I've tested it in both modes (with a simple HelloFXCanvas program) -- >> as an automa

Re: [9] review request: 8131888: Deliver javafx.swt as a modular jar in JDK 9

2016-05-27 Thread Alan Bateman
On 26/05/2016 16:38, Kevin Rushforth wrote: Yes, I've tested it in both modes (with a simple HelloFXCanvas program) -- as an automatic jar file and as just an ordinary jar on the classpath. Just curious, if there are qualified exports to javafx.swt then how it does when on the class path? -

Re: [9] review request: 8131888: Deliver javafx.swt as a modular jar in JDK 9

2016-05-27 Thread Kevin Rushforth
Alan Bateman wrote: On 26/05/2016 16:38, Kevin Rushforth wrote: Yes, I've tested it in both modes (with a simple HelloFXCanvas program) -- as an automatic jar file and as just an ordinary jar on the classpath. Just curious, if there are qualified exports to javafx.swt then how it does when o

Re: [9] review request: 8131888: Deliver javafx.swt as a modular jar in JDK 9

2016-05-27 Thread Alan Bateman
On 27/05/2016 13:47, Kevin Rushforth wrote: The qualified exports are done using reflection to the calling module that contains the javafx.embed.swt.FXCanvas class, irrespective of the name of the module (so it works even when the javafx.embed.swt package is in the unnamed module). I plan t

Re: [9] review request: 8131888: Deliver javafx.swt as a modular jar in JDK 9

2016-05-27 Thread Kevin Rushforth
Thanks for confirming. So it sounds like we have a workable plan. -- Kevin Alan Bateman wrote: On 27/05/2016 13:47, Kevin Rushforth wrote: The qualified exports are done using reflection to the calling module that contains the javafx.embed.swt.FXCanvas class, irrespective of the name of

Re: [9] review request: 8131888: Deliver javafx.swt as a modular jar in JDK 9

2016-05-27 Thread Mandy Chung
> On May 27, 2016, at 1:30 AM, Tom Schindl wrote: > > Do you have an example how to construct such a Layer? // path is the path to javafx-swt.jar ModuleFinder finder = ModuleFinder.of(path); Configuration cf = Layer.boot() .configuration() .resolveRequires(finder, ModuleFinder.of(), Se