>> I've updated the webrev, hopefully one last time with feedback from Joe
>> Darcy.
>> http://cr.openjdk.java.net/~ddehaven/8132743/webrev.2/
>>
>> - Relocated package Javadoc to above the package declaration in
>> package-info.java
>> - Reworded the Javadoc on the default JSObject ctor
>>
On 05/03/2016 18:54, David DeHaven wrote:
I've updated the webrev, hopefully one last time with feedback from Joe Darcy.
http://cr.openjdk.java.net/~ddehaven/8132743/webrev.2/
- Relocated package Javadoc to above the package declaration in
package-info.java
- Reworded the Javadoc on the
Looks good.
-- Kevin
David DeHaven wrote:
I've updated the webrev, hopefully one last time with feedback from Joe Darcy.
http://cr.openjdk.java.net/~ddehaven/8132743/webrev.2/
- Relocated package Javadoc to above the package declaration in
package-info.java
- Reworded the Javadoc on the
I've updated the webrev, hopefully one last time with feedback from Joe Darcy.
http://cr.openjdk.java.net/~ddehaven/8132743/webrev.2/
- Relocated package Javadoc to above the package declaration in
package-info.java
- Reworded the Javadoc on the default JSObject ctor
A point was brought up
Looks good to me.
-- Kevin
David DeHaven wrote:
Updated webrev:
http://cr.openjdk.java.net/~ddehaven/8132743/webrev.1/
Added jdk.jsobject to MAIN_MODULES
Made suggested Javadoc changes
Gave JSException a real serialVersionUID
-DrD-
On Mar 3, 2016, at 5:06 PM, David DeHaven
>>> Updated webrev:
>>> http://cr.openjdk.java.net/~ddehaven/8132743/webrev.1/
>>>
>> Looks fine to me. Thanks for the update.
>>
> Just reading the javadoc again and I wonder about this statement in the
> package description:
>
> "The classes in this package were initially specified by
On 04/03/2016 04:54, Mandy Chung wrote:
On Mar 3, 2016, at 7:36 PM, David DeHaven wrote:
Updated webrev:
http://cr.openjdk.java.net/~ddehaven/8132743/webrev.1/
Looks fine to me. Thanks for the update.
Just reading the javadoc again and I wonder about this
Adding it to MAIN_MODULES, I now see it in bootmodules.jimage:
/jdk.jsobject/jdk/internal/netscape/javascript/spi/JSObjectProvider.class
/jdk.jsobject/netscape/javascript/JSException.class
/jdk.jsobject/netscape/javascript/JSObject$ProviderLoader$1.class
jdk9-dev is not the right mailing list. I bcc’ed it and add jigsaw-dev instead.
> On Mar 3, 2016, at 3:57 PM, Kevin Rushforth
> wrote:
>
> Looks OK to me. I did a quick test build and I can see the new package in the
> exploded JDK, but not in the images. Maybe I