Re: 8170987: Module system implementation refresh (12/2016)

Langtools changes look good. —Andrey > On 15 Dec 2016, at 00:46, Alan Bateman wrote: > > Folks on jigsaw-dev will be aware that we are on yet another mission to bring > the changes accumulated in the jake forest to jdk9/dev. The plan this time is > to bring the

Re: 8170987: Module system implementation refresh (12/2016)

> On Dec 15, 2016, at 10:13 AM, Alan Bateman wrote: > > On 15/12/2016 14:13, Claes Redestad wrote: > >> >> The context here, I assume, is the increased startup cost to initialize >> java.util.regex in 9 (and a few regression fixes related to this that >> I've done in

Re: 8170987: Module system implementation refresh (12/2016)

On 15/12/2016 14:13, Claes Redestad wrote: The context here, I assume, is the increased startup cost to initialize java.util.regex in 9 (and a few regression fixes related to this that I've done in the area which may have involved avoiding adding a regex-free fast path for trivial but common

Re: 8170987: Module system implementation refresh (12/2016)

2016/12/14 15:31:18 -0800, claes.redes...@oracle.com: > ... > > WARNING could be a local anonymous class inside > printStackTraceIfExposedReflectively. ;-) Good point -- fixed. - Mark

Re: 8170987: Module system implementation refresh (12/2016)

> On 15 Dec 2016, at 01:17, Mandy Chung wrote: > ... > > src/java.base/share/classes/jdk/internal/module/ModuleResolution.java > > 64 throw new RuntimeException("cannot add deprecated to " + > value); > > This comment applies to ModuleResoluton::with*

Re: 8170987: Module system implementation refresh (12/2016)

Langtools changes look good - I like the changes in ClassReader/Writer. Maurizio On 14/12/16 21:46, Alan Bateman wrote: Folks on jigsaw-dev will be aware that we are on yet another mission to bring the changes accumulated in the jake forest to jdk9/dev. The plan this time is to bring the

Re: 8170987: Module system implementation refresh (12/2016)

On 15/12/2016 01:17, Mandy Chung wrote: I have pushed the change to rename jdk.crypto.pkcs11 and jdk.pack200 and dropped java.compact$N. So module-info.java changes will not be needed when you sync with jdk9/dev. Thank you. I'll do a merge today to see that everything works together. : Not

Re: 8170987: Module system implementation refresh (12/2016)

On 14/12/2016 23:31, Claes Redestad wrote: Hi, I took a quick pass over the jdk changes. It generally looks very good, but I've got some comments: MethodHandles.Lookup.dropLookupMode: The javadoc doesn't really roll of the tongue here. Maybe "Creates a new lookup from the current one where

Re: 8170987: Module system implementation refresh (12/2016)

> > The webrevs with the changes for this update are here: > > http://cr.openjdk.java.net/~alanb/8170987/1 I have pushed the change to rename jdk.crypto.pkcs11 and jdk.pack200 and dropped java.compact$N. So module-info.java changes will not be needed when you sync with jdk9/dev. I reviewed

Re: 8170987: Module system implementation refresh (12/2016)

Hi, I took a quick pass over the jdk changes. It generally looks very good, but I've got some comments: MethodHandles.Lookup.dropLookupMode: The javadoc doesn't really roll of the tongue here. Maybe "Creates a new lookup from the current one where the given lookup mode has been dropped. ..."

Re: 8170987: Module system implementation refresh (12/2016)

On 12/14/2016 4:46 PM, Alan Bateman wrote: Folks on jigsaw-dev will be aware that we are on yet another mission to bring the changes accumulated in the jake forest to jdk9/dev. The plan this time is to bring the changes to jdk9/dev to make jdk-9+150. The changes in this update are mostly for

8170987: Module system implementation refresh (12/2016)

Folks on jigsaw-dev will be aware that we are on yet another mission to bring the changes accumulated in the jake forest to jdk9/dev. The plan this time is to bring the changes to jdk9/dev to make jdk-9+150. The changes in this update are mostly for JSR 376 issues #VersionedDependences and