Re: RFR: 8217877: Dead code in jdk.jlink's TaskHelper

2019-01-28 Thread Severin Gehwolf
On Mon, 2019-01-28 at 11:16 -0800, Mandy Chung wrote: > > > On 1/28/19 11:01 AM, Alan Bateman wrote: > > On 28/01/2019 15:00, Severin Gehwolf wrote: > > > Hi, > > > > > > There seems to be dead code in class TaskHelper. Plugins are loaded via > > > ServiceLoader from the module boot loader. I

Re: RFR: 8217877: Dead code in jdk.jlink's TaskHelper

2019-01-28 Thread Mandy Chung
On 1/28/19 11:01 AM, Alan Bateman wrote: On 28/01/2019 15:00, Severin Gehwolf wrote: Hi, There seems to be dead code in class TaskHelper. Plugins are loaded via ServiceLoader from the module boot loader. I don't see how this code could ever be reached. The proposal is to remove it for clarit

Re: RFR: 8217877: Dead code in jdk.jlink's TaskHelper

2019-01-28 Thread Alan Bateman
On 28/01/2019 15:00, Severin Gehwolf wrote: Hi, There seems to be dead code in class TaskHelper. Plugins are loaded via ServiceLoader from the module boot loader. I don't see how this code could ever be reached. The proposal is to remove it for clarity. Bug: https://bugs.openjdk.java.net/browse

RFR: 8217877: Dead code in jdk.jlink's TaskHelper

2019-01-28 Thread Severin Gehwolf
Hi, There seems to be dead code in class TaskHelper. Plugins are loaded via ServiceLoader from the module boot loader. I don't see how this code could ever be reached. The proposal is to remove it for clarity. Bug: https://bugs.openjdk.java.net/browse/JDK-8217877 webrev: http://cr.openjdk.java.ne