Re: RFR [9] 8170859 : Run time and tool support for ModuleResolution

On 09/12/2016 14:09, Remi Forax wrote: Thanks Alan, so I withdraw my snarky comment. Not a problem. There is cleanup to be done in several areas, this is one. For the short term then we need to get the implementation aligned with the proposals in the JSR and then get the cleanup done before

Re: RFR [9] 8170859 : Run time and tool support for ModuleResolution

I'll work with Alan to get these changes re-based on top of the refactoring in jake. Consider this review request withdrawn. -Chris. On 09/12/16 14:09, Remi Forax wrote: Thanks Alan, so I withdraw my snarky comment. Rémi On December 9, 2016 12:25:19 PM GMT+01:00, Alan Bateman

Re: RFR [9] 8170859 : Run time and tool support for ModuleResolution

Thanks Alan, so I withdraw my snarky comment. Rémi On December 9, 2016 12:25:19 PM GMT+01:00, Alan Bateman wrote: >On 08/12/2016 14:41, Remi Forax wrote: > >> Chris, >> this patch is rather ugly. >> Patching the ModuleDescriptor is not a good idea, maybe it's means

Re: RFR [9] 8170859 : Run time and tool support for ModuleResolution

On 08/12/2016 14:41, Remi Forax wrote: Chris, this patch is rather ugly. Patching the ModuleDescriptor is not a good idea, maybe it's means that we need a system of metadata associated with a ModuleDescriptor, the hash of a module (which is not part of the module spec but the OpenJDK

Re: RFR [9] 8170859 : Run time and tool support for ModuleResolution

; regards, > Rémi > > - Mail original - >> De: "Chris Hegarty" <chris.hega...@oracle.com> >> À: "jigsaw-dev" <jigsaw-dev@openjdk.java.net> >> Envoyé: Jeudi 8 Décembre 2016 14:49:38 >> Objet: RFR [9] 8170859 : Run time and tool