RFR [9] 8176772: jar tool support to report automatic module names

2017-03-15 Thread Chris Hegarty
It would be useful for the jar tool to report the automatic module name that would be used if a regular jar file was put on the module path ( so there is an easy way for developers to determine the derived name ). One way to achieve this is to repurpose the somewhat finger-some '--print-module-de

Re: RFR [9] 8176772: jar tool support to report automatic module names

2017-03-15 Thread Alan Bateman
On 15/03/2017 14:21, Chris Hegarty wrote: : Webrev: http://cr.openjdk.java.net/~chegar/8176772.00/ https://bugs.openjdk.java.net/browse/JDK-8176772 If findAll returns an empty set then the error.unable.derive.automodule message might be more appropriate. Otherwise looks good to me.

Re: RFR [9] 8176772: jar tool support to report automatic module names

2017-03-15 Thread Chris Hegarty
> On 15 Mar 2017, at 14:42, Alan Bateman wrote: > > On 15/03/2017 14:21, Chris Hegarty wrote: > >> : >> >> Webrev: >> >> http://cr.openjdk.java.net/~chegar/8176772.00/ >> https://bugs.openjdk.java.net/browse/JDK-8176772 >> > If findAll returns an empty set then the error.unable.derive.au

Re: RFR [9] 8176772: jar tool support to report automatic module names

2017-03-15 Thread Alan Bateman
On 15/03/2017 15:31, Chris Hegarty wrote: : That would be better. Updated in-place. http://cr.openjdk.java.net/~chegar/8176772.00/ Looks good.

Re: RFR [9] 8176772: jar tool support to report automatic module names

2017-03-15 Thread Mandy Chung
> On Mar 15, 2017, at 8:31 AM, Chris Hegarty wrote: > > >> On 15 Mar 2017, at 14:42, Alan Bateman wrote: >> >> On 15/03/2017 14:21, Chris Hegarty wrote: >> >>> : >>> >>> Webrev: >>> >>> http://cr.openjdk.java.net/~chegar/8176772.00/ >>> https://bugs.openjdk.java.net/browse/JDK-8176772 >>

Re: RFR [9] 8176772: jar tool support to report automatic module names

2017-03-15 Thread Chris Hegarty
> On 15 Mar 2017, at 16:54, Mandy Chung wrote: > >> >> On Mar 15, 2017, at 8:31 AM, Chris Hegarty wrote: >> >> >>> On 15 Mar 2017, at 14:42, Alan Bateman wrote: >>> >>> On 15/03/2017 14:21, Chris Hegarty wrote: >>> : Webrev: http://cr.openjdk.java.net/~chegar/81

Re: RFR [9] 8176772: jar tool support to report automatic module names

2017-03-15 Thread Mandy Chung
> On Mar 15, 2017, at 10:12 AM, Chris Hegarty wrote: > >> >> Is there any reason why this option does not print the synthesized >> descriptor? I understand that the issue is specific to show the derived >> module name. But it’d be nice for this option to print the descriptor >> consistent

Re: RFR [9] 8176772: jar tool support to report automatic module names

2017-03-16 Thread Chris Hegarty
> On 15 Mar 2017, at 17:30, Mandy Chung wrote: > > ... > provides and main class, if present. > > The modifier of ModuleDescriptor will have AUTOMATIC and so all packages are > exported and open implicitly and not shown in the output which is okay. This is a good idea. Here’s an example: ja

Re: RFR [9] 8176772: jar tool support to report automatic module names

2017-03-16 Thread Chris Hegarty
On 16 Mar 2017, at 13:09, Chris Hegarty wrote: > >> On 15 Mar 2017, at 17:30, Mandy Chung wrote: >> >> ... >> provides and main class, if present. >> >> The modifier of ModuleDescriptor will have AUTOMATIC and so all packages are >> exported and open implicitly and not shown in the output wh

Re: RFR [9] 8176772: jar tool support to report automatic module names

2017-03-16 Thread Mandy Chung
> On Mar 16, 2017, at 6:09 AM, Chris Hegarty wrote: > > Updated webrev: > http://cr.openjdk.java.net/~chegar/8176772.01/ Looks good. thanks Mandy