Re: RFR 8141609: Need test for jrtfs that runs on JDK 8 to target a JDK 9 image

2016-03-30 Thread Alan Bateman
On 30/03/2016 15:11, Felix Yang wrote: Hi Alan, fixed "bin" to "classes". By the way, I need a sponsor for this change. Webrev: http://cr.openjdk.java.net/~xiaofeya/8141609/webrev.04/ No problem, I can sponsor this for you. -Alan

Re: RFR 8141609: Need test for jrtfs that runs on JDK 8 to target a JDK 9 image

2016-03-30 Thread Felix Yang
Hi Alan, fixed "bin" to "classes". By the way, I need a sponsor for this change. Webrev: http://cr.openjdk.java.net/~xiaofeya/8141609/webrev.04/ Thanks, Felix On 2016/3/30 21:49, Alan Bateman wrote: On 30/03/2016 14:39, Felix Yang wrote: Hi all, renamed the test to distinguish with ot

Re: RFR 8141609: Need test for jrtfs that runs on JDK 8 to target a JDK 9 image

2016-03-30 Thread Alan Bateman
On 30/03/2016 14:39, Felix Yang wrote: Hi all, renamed the test to distinguish with other jrt fs tests and also fixed some misc issues. New webrev: http://cr.openjdk.java.net/~xiaofeya/8141609/webrev.03/ This looks good. A minor nit is that it compiles to the bin directory, shouldn't tha

Re: RFR 8141609: Need test for jrtfs that runs on JDK 8 to target a JDK 9 image

2016-03-30 Thread Sundararajan Athijegannathan
+1 -Sundar On 3/30/2016 7:09 PM, Felix Yang wrote: > Hi all, > renamed the test to distinguish with other jrt fs tests and also > fixed some misc issues. > New webrev: http://cr.openjdk.java.net/~xiaofeya/8141609/webrev.03/ > > Thanks, > Felix > On 2016/3/3 15:48, Felix Yang wrote: >> Hi Alan

Re: RFR 8141609: Need test for jrtfs that runs on JDK 8 to target a JDK 9 image

2016-03-30 Thread Felix Yang
Hi all, renamed the test to distinguish with other jrt fs tests and also fixed some misc issues. New webrev: http://cr.openjdk.java.net/~xiaofeya/8141609/webrev.03/ Thanks, Felix On 2016/3/3 15:48, Felix Yang wrote: Hi Alan and Sundar, please review the new webrev. Simplified the test

Re: RFR 8141609: Need test for jrtfs that runs on JDK 8 to target a JDK 9 image

2016-03-02 Thread Felix Yang
Hi Alan and Sundar, please review the new webrev. Simplified the test app as discussed. http://cr.openjdk.java.net/~xiaofeya/8141609/webrev.02/ Thanks, Felix On 2016/3/1 16:07, Alan Bateman wrote: On 01/03/2016 05:47, Felix Yang wrote: Hi Alan, please review the new webrev: http://c

Re: RFR 8141609: Need test for jrtfs that runs on JDK 8 to target a JDK 9 image

2016-03-01 Thread Alan Bateman
On 01/03/2016 05:47, Felix Yang wrote: Hi Alan, please review the new webrev: http://cr.openjdk.java.net/~xiaofeya/8141609/webrev.02/ Major changes: 1. remove checking for 'java.version' in JrtfsTestMain and add new check for 'release' file 2. In order to avoid dup tests with Basic.java,

Re: RFR 8141609: Need test for jrtfs that runs on JDK 8 to target a JDK 9 image

2016-02-29 Thread Felix Yang
Hi Alan, please review the new webrev: http://cr.openjdk.java.net/~xiaofeya/8141609/webrev.02/ Major changes: 1. remove checking for 'java.version' in JrtfsTestMain and add new check for 'release' file 2. In order to avoid dup tests with Basic.java, add new BaseTest.java, which is a plain

Re: RFR 8141609: Need test for jrtfs that runs on JDK 8 to target a JDK 9 image

2016-02-25 Thread Felix Yang
On 2016/2/25 15:45, Alan Bateman wrote: On 24/02/2016 04:01, Felix Yang wrote: Jon and Alan, thanks a lot for this comment. Fixed it in new webrev: http://cr.openjdk.java.net/~xiaofeya/8141609/webrev.01/ I think JrtfsJarTest will also need to check the `release` file in $JDK8_HOME to c

Re: RFR 8141609: Need test for jrtfs that runs on JDK 8 to target a JDK 9 image

2016-02-24 Thread Alan Bateman
On 24/02/2016 04:01, Felix Yang wrote: Jon and Alan, thanks a lot for this comment. Fixed it in new webrev: http://cr.openjdk.java.net/~xiaofeya/8141609/webrev.01/ I think JrtfsJarTest will also need to check the `release` file in $JDK8_HOME to check that it's a JDK 8 release. Its a prope

Re: RFR 8141609: Need test for jrtfs that runs on JDK 8 to target a JDK 9 image

2016-02-23 Thread Felix Yang
Jon and Alan, thanks a lot for this comment. Fixed it in new webrev: http://cr.openjdk.java.net/~xiaofeya/8141609/webrev.01/ -Felix > On Feb 23, 2016, at 11:54 PM, Jonathan Gibbons > wrote: > > On 02/23/2016 06:40 AM, Alan Bateman wrote: >> This fails if JDK8_HOME is not defined and I'm sur

Re: RFR 8141609: Need test for jrtfs that runs on JDK 8 to target a JDK 9 image

2016-02-23 Thread Jonathan Gibbons
On 02/23/2016 06:40 AM, Alan Bateman wrote: This fails if JDK8_HOME is not defined and I'm sure will be annoyance for those that run jtreg directly. Should we get the test to just pass if not set? I realize that is not ideal. -Alan. It is relatively common practice for tests that require so

Re: RFR 8141609: Need test for jrtfs that runs on JDK 8 to target a JDK 9 image

2016-02-23 Thread Alan Bateman
On 23/02/2016 03:40, Felix Yang wrote: Please review the following new test. Webrev: http://cr.openjdk.java.net/~xiaofeya/8141609/webrev.00/ Bug: https://bugs.openjdk.java.net/browse/JDK-8141609 jdk 9 bundled a "jrt-fs.jar" file which expose the jrt filesystem support. It is critical that a

RFR 8141609: Need test for jrtfs that runs on JDK 8 to target a JDK 9 image

2016-02-22 Thread Felix Yang
Please review the following new test. Webrev: http://cr.openjdk.java.net/~xiaofeya/8141609/webrev.00/ Bug: https://bugs.openjdk.java.net/browse/JDK-8141609 jdk 9 bundled a "jrt-fs.jar" file which expose the jrt filesystem support. It is critical that a tool on JDK 8 can use the jrt file system