On 01/08/2016 09:31, Sundararajan Athijegannathan wrote:
I had moved that try..catch code to read module descriptor from
elsewhere. When I removed that try..catch, I got test failures. Found
another lurking issue on reading descriptor from compressed resources!
Fixed that
I had moved that try..catch code to read module descriptor from
elsewhere. When I removed that try..catch, I got test failures. Found
another lurking issue on reading descriptor from compressed resources!
Fixed that [ImagePluginStack.LastPoolManager] and removed try..catch.
All tests pass now.
On 31/07/2016 20:29, Sundararajan Athijegannathan wrote:
Hi,
I'll handle that issue in another fix.
Okay. One thing with the current patch is that the try/catch in
releaseProperties isn't clear. Also in ResourcePoolEntry, where it
defines TOP, it says "jdk image directory" then I assume
+1
> On Jul 29, 2016, at 11:42 AM, Sundararajan Athijegannathan
> wrote:
>
> Please review http://cr.openjdk.java.net/~sundar/8162782/webrev.00/ for
> https://bugs.openjdk.java.net/browse/JDK-8162782
>
> Thanks,
>
> -Sundar
>
I just checked release file in custom image generated by jlink. It has
OS_NAME, OS_ARCH (may be after current cleanup). JAVA_HOME is missing.
I'll add that.
PS. Should I do that separate fix or part of the current fix?
Thanks
-Sundar
On 7/29/2016 8:16 PM, Alan Bateman wrote:
> On 29/07/2016
On 29/07/2016 15:42, Sundararajan Athijegannathan wrote:
Please review http://cr.openjdk.java.net/~sundar/8162782/webrev.00/ for
https://bugs.openjdk.java.net/browse/JDK-8162782
Sundar - is this this time to address JDK-8159487 too?
-Alan
Please review http://cr.openjdk.java.net/~sundar/8162782/webrev.00/ for
https://bugs.openjdk.java.net/browse/JDK-8162782
Thanks,
-Sundar