Re: RFR 8174718: "Module 's descriptor returns inconsistent package set" confusing

2017-02-14 Thread Mandy Chung
> On Feb 14, 2017, at 5:52 AM, Sundararajan Athijegannathan > wrote: > > Please review http://cr.openjdk.java.net/~sundar/8174718/webrev.00/ for > https://bugs.openjdk.java.net/browse/JDK-8174718 JLinkNegativeTest.java - line 352 is not really needed. Otherwise looks fine to me. Mandy

Re: RFR 8174718: "Module 's descriptor returns inconsistent package set" confusing

2017-02-14 Thread Jim Laskey (Oracle)
+1 > On Feb 14, 2017, at 9:52 AM, Sundararajan Athijegannathan > wrote: > > Please review http://cr.openjdk.java.net/~sundar/8174718/webrev.00/ for > https://bugs.openjdk.java.net/browse/JDK-8174718 > > Thanks, > -Sundar

Re: RFR 8174718: "Module 's descriptor returns inconsistent package set" confusing

2017-02-14 Thread Alan Bateman
On 14/02/2017 15:56, Sundararajan Athijegannathan wrote: Yes - because the test module's name is "inconsistentJar" and jlink adds module name to the error message. -Sundar Got it, I thought it was a typo initially. -Alan.

Re: RFR 8174718: "Module 's descriptor returns inconsistent package set" confusing

2017-02-14 Thread Sundararajan Athijegannathan
Yes - because the test module's name is "inconsistentJar" and jlink adds module name to the error message. -Sundar On 14/02/17, 9:08 PM, Alan Bateman wrote: On 14/02/2017 13:52, Sundararajan Athijegannathan wrote: Please review http://cr.openjdk.java.net/~sundar/8174718/webrev.00/ for https:

Re: RFR 8174718: "Module 's descriptor returns inconsistent package set" confusing

2017-02-14 Thread Alan Bateman
On 14/02/2017 13:52, Sundararajan Athijegannathan wrote: Please review http://cr.openjdk.java.net/~sundar/8174718/webrev.00/ for https://bugs.openjdk.java.net/browse/JDK-8174718 Is the output matching in the test correct to check for "Module inconsistentJar's descriptor ..."? -Alan

RFR 8174718: "Module 's descriptor returns inconsistent package set" confusing

2017-02-14 Thread Sundararajan Athijegannathan
Please review http://cr.openjdk.java.net/~sundar/8174718/webrev.00/ for https://bugs.openjdk.java.net/browse/JDK-8174718 Thanks, -Sundar